Created attachment 2048196 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/ SRPM URL: https://music.fedorapeople.org/ Description: Macro for custom destructuring. Fedora Account System Username: music New rust-munge/rust-munge_macro packages are needed for rust-rkyv 0.8.8.
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://music.fedorapeople.org/rust-munge_macro.spec SRPM URL: https://music.fedorapeople.org/rust-munge_macro-0.4.1-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8056755 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314104-rust-munge_macro/fedora-rawhide-x86_64/08056755-rust-munge_macro/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Have you submitted the fix for the mix-of-CRLF-and-LF-line-endings to upstream? Those kind of issues are usually unintentional and caused by careless moving between Windows and Linux without setting the necessary git attributes. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review! (In reply to Fabio Valentini from comment #5) > Have you submitted the fix for the mix-of-CRLF-and-LF-line-endings to > upstream? > Those kind of issues are usually unintentional and caused by careless moving > between Windows and Linux without setting the necessary git attributes. Hmm, I could. I usually do offer a PR when there are just a couple of files and it looks like an accident, but several projects I looked at under https://github.com/rkyv/ or https://github.com/djkoloski/ (at least munge_macro, munge, rancor, and rkyv) had a significant number of CRLF-terminated files in the released crates, so I kind of surmised that upstream just doesn’t consider it a problem. I just submitted https://github.com/djkoloski/munge/pull/5 as a trial balloon. I can open PR’s on other rkyv/djkoloski repos if that one goes well.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-munge_macro
https://release-monitoring.org/project/374649/
FEDORA-2024-afefd0c839 (rust-munge_macro-0.4.1-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-afefd0c839
FEDORA-2024-afefd0c839 (rust-munge_macro-0.4.1-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-04932f90d1 (rust-munge_macro-0.4.1-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-04932f90d1
FEDORA-2024-37a9acf7cb (rust-munge_macro-0.4.1-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-37a9acf7cb
FEDORA-2024-852f62022a (rust-munge_macro-0.4.1-2.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-852f62022a
FEDORA-2024-852f62022a has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-852f62022a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-852f62022a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-04932f90d1 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-04932f90d1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-04932f90d1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-37a9acf7cb has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-37a9acf7cb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-37a9acf7cb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-04932f90d1 (rust-munge_macro-0.4.1-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-852f62022a (rust-munge_macro-0.4.1-2.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-37a9acf7cb (rust-munge_macro-0.4.1-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.