Bug 2314105 - Review Request: rust-munge - Macro for custom destructuring
Summary: Review Request: rust-munge - Macro for custom destructuring
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/munge
Whiteboard:
Depends On: 2314104
Blocks: 2311783
TreeView+ depends on / blocked
 
Reported: 2024-09-22 18:57 UTC by Ben Beasley
Modified: 2024-10-19 01:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-10-08 18:56:46 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-09-22 18:57:38 UTC
Spec URL: https://music.fedorapeople.org/rust-munge.spec
SRPM URL: https://music.fedorapeople.org/rust-munge-0.4.1-1.fc40.src.rpm
Description: Macro for custom destructuring.
Fedora Account System Username: music

New rust-munge/rust-munge_macro packages are needed for rust-rkyv 0.8.8.

Pending COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/uv/build/8056765/

Comment 1 Fedora Review Service 2024-09-22 19:00:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8056772
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314105-rust-munge/fedora-rawhide-x86_64/08056772-rust-munge/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2024-10-01 13:40:16 UTC
I sent https://github.com/djkoloski/munge/pull/5 upstream for fixing the mixture of newline styles, and it was merged. Upon import, I will add a link to the PR above "find . -type f | xargs -r -t dos2unix --keepdate" in %prep.

Comment 3 Fabio Valentini 2024-10-08 15:42:34 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Ben Beasley 2024-10-08 15:56:01 UTC
Thank you for the review! I will import this later today. I plan to build it in Rawhide and request and push to the F41/F40/F39 branches, but I’ll wait on the initial builds so they can be done in the side tags for rkyv 0.8.

https://release-monitoring.org/project/374816/

Comment 5 Fedora Admin user for bugzilla script actions 2024-10-08 18:04:55 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-munge

Comment 6 Fedora Update System 2024-10-08 18:52:18 UTC
FEDORA-2024-231f47ea02 (rust-munge-0.4.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-231f47ea02

Comment 7 Fedora Update System 2024-10-08 18:56:46 UTC
FEDORA-2024-231f47ea02 (rust-munge-0.4.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-10-09 19:53:03 UTC
FEDORA-2024-0954b642d0 (rust-bytecheck0.6-0.6.12-1.fc41, rust-bytecheck-0.8.0-1.fc41, and 14 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0954b642d0

Comment 9 Fedora Update System 2024-10-10 03:17:49 UTC
FEDORA-2024-0954b642d0 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0954b642d0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0954b642d0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-10-10 10:15:16 UTC
FEDORA-2024-df7046e381 (rust-bytecheck0.6-0.6.12-1.fc40, rust-bytecheck-0.8.0-1.fc40, and 14 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-df7046e381

Comment 11 Fedora Update System 2024-10-10 10:15:24 UTC
FEDORA-2024-3a741ce360 (rust-bytecheck0.6-0.6.12-1.fc39, rust-bytecheck-0.8.0-1.fc39, and 14 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3a741ce360

Comment 12 Fedora Update System 2024-10-11 01:08:38 UTC
FEDORA-2024-3a741ce360 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3a741ce360`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3a741ce360

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-10-11 01:45:00 UTC
FEDORA-2024-df7046e381 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-df7046e381`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-df7046e381

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-10-15 00:17:16 UTC
FEDORA-2024-0954b642d0 (rust-bytecheck0.6-0.6.12-1.fc41, rust-bytecheck-0.8.0-1.fc41, and 14 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2024-10-19 01:19:33 UTC
FEDORA-2024-3a741ce360 (rust-bytecheck0.6-0.6.12-1.fc39, rust-bytecheck-0.8.0-1.fc39, and 14 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-10-19 01:52:26 UTC
FEDORA-2024-df7046e381 (rust-bytecheck0.6-0.6.12-1.fc40, rust-bytecheck-0.8.0-1.fc40, and 14 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.