Bug 231680 - Review Request: vdccm - Serial connection daemon for Pocket PC devices
Review Request: vdccm - Serial connection daemon for Pocket PC devices
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Andreas Bierfert
Fedora Package Reviews List
Depends On: 231679
Blocks: 231681
  Show dependency treegraph
Reported: 2007-03-09 17:22 EST by Aurelien Bompard
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-01 17:22:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
andreas.bierfert: fedora‑review+
wtogami: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Aurelien Bompard 2007-03-09 17:22:02 EST
Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/vdccm.spec
SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/vdccm-0.9.3-1.src.rpm
Vdccm is a daemon running as the user on the desktop machine, which
the Pocket PC connects to.
This vdccm is a replacement of the original dccm and the vdccm comming
with SynCE-KDE.

SynCE is already in Fedora Extras, but in the form of a monolithic package : all the components are in the same RPM. I've splitted it, this is one of the components.
Comment 1 Andreas Bierfert 2007-04-27 05:33:28 EDT
Hash: SHA1

 * OK: E: vdccm setuid-binary /usr/bin/vdccm root 04755
       E: vdccm non-standard-executable-perm /usr/bin/vdccm 04755
    This is ok and should be setuid root
 * W: vdccm-devel no-documentation can be ignored
 * OK: package is named according to the guidelines
 * OK: spec file name matches base package name
 * OK: package meets packaging guidelines
 * OK: license
 * OK: license field matches actual license
 * OK: license is not included as own file and thus is not included in %doc
 * OK: spec file seems to be in AE
 * OK: no obfuscated code spec
 * OK: sources match upstream:
996236320a6b4c9410050c4dc6e53164  synce-vdccm-0.9.3.tar.gz                     
 * OK: Builds fine on x86_64/fc6
 * OK: BR seem fine
 * OK: package has no locale support
 * OK: ldconfig is run 
 * OK: package is not explicitly designed to be relocatable
 * OK: does not create own dirs
 * OK: no duplicate files in file listing
 * OK: %defattr and permissions seem ok
 * OK: %clean section is present
 * OK: macros are used consistently
 * OK: content is ok
 * OK: no doc package needed
 * OK: %doc files do not affect runtime
 * OK: header files are in -devel
 * OK: no static lib
 * OK: pkgconfig is not needed
 * OK: .so file in -devel package
 * OK: -devel requires main package
 * OK: package does not contain .la archives
 * OK: no .desktop needed
 * OK: does not own files/directories from other packages
 * OK: buildroot is rm at beginning of install
 * OK: filenames seem to be valid utfp

Package APPROVED with the following patch:

- --- vdccm.spec.1	2007-03-09 22:59:44.000000000 +0100
+++ vdccm.spec	2007-04-27 11:27:34.000000000 +0200
@@ -10,6 +10,7 @@
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires:  libsynce-devel
+BuildRequires:  libtool
 Requires:       synce-serial
@@ -34,14 +35,14 @@
 %configure --disable-static
- -make %{?_smp_mflags}
+make LIBTOOL=%{_bindir}/libtool %{?_smp_mflags}
- -rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
+rm -f $RPM_BUILD_ROOT%{_libdir}/*.{la,a}
Version: GnuPG v1.4.7 (GNU/Linux)

Comment 2 Aurelien Bompard 2007-04-28 01:42:48 EDT
New Package CVS Request
Package Name: vdccm
Short Description: Serial connection daemon for Pocket PC devices
Owners: andreas.bierfert@lowlatency.de,gauret@free.fr
Branches: FC-6

Note You need to log in before you can comment on or make changes to this bug.