Hi, Could you please branch and build koji for EPEL 10 ? It is needed to build another package. Regards, Xavier
What package requires Koji installed inside the buildroot and why?
To answer my own question, looks like a number of builds such as: centpkg, packit, fedpkg, rpkg, bodhi-client, osh, sigul. Likely (hopefully), the buildtime dep is simply that these tools import koji and need it installed for their unit tests to work.
So, it builds fine currently... but I have no easy way to test that all the requirements are there, it could be uninstallable. ;( Is there some way to get a stream10 container to test in?
centos:stream10-development perhaps? https://quay.io/repository/centos/centos?tab=tags
ok, some simple tests seem to work fine. :) So, lets get it in and go from there for any issues.
FEDORA-EPEL-2024-75c9a716d4 (koji-1.35.1-3.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-75c9a716d4
FEDORA-EPEL-2024-75c9a716d4 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-75c9a716d4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
*** Bug 2325201 has been marked as a duplicate of this bug. ***
And my tests were too simple. There's some subpackages with missing deps... ;(
koji-builder depends on /usr/bin/cvs. Is this really something we would like to keep in EPEL 10 for the next 10 years to come ? Is cvs still really needed nowadays ?
For python3-koji-hub-plugins which depends on the non existing package python3-qpid-proton it seems that was already the case in EPEL 9: see https://bugzilla.redhat.com/show_bug.cgi?id=2168181 Not sure if we shall ask for the whole qpid-proton package to be branched or if this is actually not needed for koji in EPEL 10 ?
I noticed that too about cvs. I have no idea how important it is as a koji dependency, but I did want to point out that according to the upstream news page the last release was 16 years ago. That certainly has the appearance of an unmaintained upstream, and should probably get evaluated for deprecation/retirement in Fedora. https://savannah.nongnu.org/news/?group=cvs
Yeah, we can drop cvs most likely. I'll try and look at this this weekend if I have time.
> I have no idea how important it is as a koji dependency It only matters if folks are building from cvs. Should be fine to drop it.
We should probably drop it in the upstream spec too -- https://pagure.io/koji/issue/4265
Perhaps the way to go here is to move those all (cvs/svn/git) to Reccomends? python-multilib is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2325337 qpid-proton is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2325348 (and is/was a problem in epel9 too): https://bugzilla.redhat.com/show_bug.cgi?id=2168181
Recommends is one way to go about it. Another would be to move the Requires to subpackages that can be conditionally disabled when the SCM tool is not available. For example, koji-git would require git and would be built everywhere. koji-cvs would require cvs, and could be disabled on new EPEL branches until/unless cvs is added.
Here's a PR for the approach I was describing. If y'all would rather go another route, such as just dropping the cvs dependency outright, feel free to close it. https://src.fedoraproject.org/rpms/koji/pull-request/22
FWIW, I'd prefer fedora packages go with whatever upstream prefers here so we don't diverge. :)
Note that I have submitted https://src.fedoraproject.org/rpms/koji/pull-request/23 and https://pagure.io/koji/pull-request/4271 to remove this strong requirement on the cvs package both upstream and in the Fedora/Epel packaging repo.
FEDORA-EPEL-2024-9b800ea56b (koji-1.35.1-5.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-9b800ea56b
FEDORA-EPEL-2024-9b800ea56b has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-9b800ea56b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-9b800ea56b (koji-1.35.1-5.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.