Bug 2322184 - Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate
Summary: Review Request: rust-asn1-rs-derive - Derive macros for rust-asn1-rs crate
Keywords:
Status: CLOSED DUPLICATE of bug 2312632
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/asn1-rs-derive
Whiteboard:
: 2322185 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-10-28 19:09 UTC by Tyler Fanelli
Modified: 2024-10-31 18:57 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-10-30 10:46:28 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2024-10-28 19:15:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8184261
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2322184-rust-asn1-rs-derive/fedora-rawhide-x86_64/08184261-rust-asn1-rs-derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tyler Fanelli 2024-10-29 16:18:16 UTC
*** Bug 2322185 has been marked as a duplicate of this bug. ***

Comment 3 Tyler Fanelli 2024-10-29 16:21:35 UTC
Hi Fabio,

I've submitted all required information and the build succeeded, I just need approval to continue with the new package process.

For the future, am I able to do this process on my own, without the approval of anyone else? I only ask because I have to introduce a few more packages and don't want to interrupt others if not necessary.

Comment 4 Fabio Valentini 2024-10-30 10:46:28 UTC
> For the future, am I able to do this process on my own, without the approval of anyone else?

No, all new packages need approval by a second person.
To some degree, I really wonder how you got to be a packager without knowing these basics 😅

Additionally, in this case, a request for this package was already submitted elsewhere, so I'll close this one as a duplicate.

*** This bug has been marked as a duplicate of bug 2312632 ***

Comment 5 Cole Robinson 2024-10-31 14:19:32 UTC
(In reply to Fabio Valentini from comment #4)
> > For the future, am I able to do this process on my own, without the approval of anyone else?
> 
> No, all new packages need approval by a second person.
> To some degree, I really wonder how you got to be a packager without knowing
> these basics 😅

Lame and unhelpful comment. Not everyone lives and breaths fedora policy and packaging.

I think it's reasonable for someone who rarely submits new packages to ask
if there's a simpler process they are missing, especially considering how much
you've helped streamline the rust package process with rust2rpm

Comment 6 Fabio Valentini 2024-10-31 18:57:12 UTC
I apologize for yesterday's quip - it was indeed not helpful.

I guess the NEEDINFO request for me threw me off - at least in Fedora, it's only used for really important actions and many contributors perceive it as "aggressive nagging". Just CCing me on this bug would have sufficed to get my attention.

> I think it's reasonable for someone who rarely submits new packages to ask
> if there's a simpler process they are missing, especially considering how much
> you've helped streamline the rust package process with rust2rpm

I'm happy that you perceive it as streamlined.

But no, there are usually no shortcuts you can take for adding a new package to Fedora - with some small exceptions,
see https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_process

wrt/ Rust packages, the only relevant exception is usually the one for "compat" packages, i.e. for providing more than one version of a crate that is already packaged.


Note You need to log in before you can comment on or make changes to this bug.