Bug 2312632 - Review Request: rust-asn1-rs-derive - Derive macros for the asn1-rs crate
Summary: Review Request: rust-asn1-rs-derive - Derive macros for the asn1-rs crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/asn1-rs-derive
Whiteboard:
: 2322184 (view as bug list)
Depends On:
Blocks: rust-asn1-rs
TreeView+ depends on / blocked
 
Reported: 2024-09-16 19:34 UTC by Davide Cavalca
Modified: 2024-11-07 17:42 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-11-07 17:42:32 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-09-16 19:34:42 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs-derive/rust-asn1-rs-derive.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs-derive/rust-asn1-rs-derive-0.5.1-1.fc42.src.rpm

Description:
Derive macros for the `asn1-rs` crate.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-09-16 19:34:45 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=123501938

Comment 2 Fedora Review Service 2024-09-16 19:35:03 UTC
There seems to be some problem with the following file.
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-asn1-rs-derive/rust-asn1-rs-derive-0.5.1-1.fc42.src.rpm
Fetching it results in a 403 Forbidden error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-10-15 12:24:56 UTC
Files can't be downloaded, please fix.

Comment 4 Fabio Valentini 2024-10-30 10:46:28 UTC
*** Bug 2322184 has been marked as a duplicate of this bug. ***

Comment 5 Tyler Fanelli 2024-10-31 15:19:39 UTC
Hi Davide,

Polite ping on if you intend to resubmit the files needed for this be accepted? I'd like to add a few crates that rely on asn1-rs (and subsequently, this crate). If you also would like to release asn1-rs, maybe we can coordinate on that?

Comment 6 Davide Cavalca 2024-11-05 23:55:11 UTC
Sorry, looks like there was a permission issue on the directory on fedorapeople.org, this should be fixed now.

Comment 7 Davide Cavalca 2024-11-05 23:56:11 UTC
[fedora-review-service-build]

Comment 8 Fedora Review Service 2024-11-06 00:00:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8218118
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2312632-rust-asn1-rs-derive/fedora-rawhide-x86_64/08218118-rust-asn1-rs-derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Fabio Valentini 2024-11-07 16:35:34 UTC
Thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 10 Fedora Admin user for bugzilla script actions 2024-11-07 17:30:01 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-asn1-rs-derive

Comment 11 Fedora Update System 2024-11-07 17:40:04 UTC
FEDORA-2024-9205bd3d41 (rust-asn1-rs-derive-0.5.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9205bd3d41

Comment 12 Fedora Update System 2024-11-07 17:42:32 UTC
FEDORA-2024-9205bd3d41 (rust-asn1-rs-derive-0.5.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.