Bug 2323721 - Reenable the colored feature
Summary: Reenable the colored feature
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rust-fern
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Rust SIG
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2320099
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-04 20:22 UTC by wojnilowicz
Modified: 2024-12-01 16:19 UTC (History)
2 users (show)

Fixed In Version: rust-fern-0.7.0-1.fc42
Clone Of:
Environment:
Last Closed: 2024-11-09 22:41:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description wojnilowicz 2024-11-04 20:22:37 UTC
Could you reenable the colored feature? aw-server-rust, that I would like to package soon, depends on it as seen at https://github.com/ActivityWatch/aw-server-rust/blob/master/aw-server/Cargo.toml#L25

Reproducible: Always

Comment 1 Fabio Valentini 2024-11-04 20:45:56 UTC
I'd really like to avoid doing that. It was dropped on purpose, because colored v2.1 pulls in some outdated dependencies:
https://src.fedoraproject.org/rpms/rust-fern/c/7a9b80f34af1d255f1ad2a7a6a5a73bcb787b337?branch=rawhide

Comment 2 wojnilowicz 2024-11-05 06:33:08 UTC
(In reply to Fabio Valentini from comment #1)
> I'd really like to avoid doing that. It was dropped on purpose, because
> colored v2.1 pulls in some outdated dependencies:
> https://src.fedoraproject.org/rpms/rust-fern/c/
> 7a9b80f34af1d255f1ad2a7a6a5a73bcb787b337?branch=rawhide

You mean this would pull rust-colored1 (outdated) and not rust-colored (current), right?

fern 0.6 is already outdated itself. Could you update fern to 0.7 then? I would try to update the fern depenency in the the upstream aw-server-rust then. Not preferable though (I don't know rust language, so I might fail), but do you have any better ideas?

Comment 3 Fabio Valentini 2024-11-05 20:53:43 UTC
> You mean this would pull rust-colored1 (outdated) and not rust-colored (current), right?

Yes.

> fern 0.6 is already outdated itself. Could you update fern to 0.7 then?

That might be a good idea regardless - I just noticed that they have a security warning for <0.7 in their readme:
https://github.com/daboross/fern/blob/main/README.md

Might be easy to port things from fern 0.6 to 0.7, might not be.

I'll put it on my TODO list.

Comment 4 Fabio Valentini 2024-11-06 12:50:50 UTC
I opened an upstream issue in aw-server:
https://github.com/ActivityWatch/aw-server-rust/issues/496

Comment 5 wojnilowicz 2024-11-06 15:57:52 UTC
(In reply to Fabio Valentini from comment #4)
> I opened an upstream issue in aw-server:
> https://github.com/ActivityWatch/aw-server-rust/issues/496

Thanks for the extra mile :) I already tested the switch 0.6->0.7 and found no issues (I even might provide a PR against the issue you opened), so the blocking part now is bumping the version in Fedora.

Comment 6 Fedora Update System 2024-11-09 22:37:42 UTC
FEDORA-2024-fe8ea9b77d (rust-fern0.6-0.6.2-1.fc42, rust-fern-0.7.0-1.fc42, and 13 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fe8ea9b77d

Comment 7 Fedora Update System 2024-11-09 22:41:55 UTC
FEDORA-2024-fe8ea9b77d (rust-fern0.6-0.6.2-1.fc42, rust-fern-0.7.0-1.fc42, and 13 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 wojnilowicz 2024-11-20 18:40:27 UTC
A surprising error when trying to build a real package that depends on fern/colored as seen at
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327650-aw-server-rust/fedora-rawhide-x86_64/08287138-aw-server-rust/builder-live.log.gz

The exact error is:
"Problem: nothing provides requested (crate(fern/colored) >= 0.6.0 with crate(fern/colored) < 0.7.0~)"

I see that the package was built at https://kojipkgs.fedoraproject.org//packages/rust-fern/0.7.0/1.fc42/noarch/rust-fern+colored-devel-0.7.0-1.fc42.noarch.rpm

f40 and f39 work.

Any clue what's going on?

Comment 9 Fabio Valentini 2024-11-28 23:58:30 UTC
Yes, the "colored" feature is only available for fern v0.7, not in fern v0.6.

Comment 10 wojnilowicz 2024-11-29 16:32:22 UTC
Yes, and rawhide uses v0.7, so why doesn't it work there?

Comment 11 Fabio Valentini 2024-12-01 16:19:56 UTC
The repository setup in COPR doesn't match the one in koji. I assume it works in stable branches in COPR because they have the old fern v0.6 package that still has the "colored" feature available in the "fedora" repo, whereas in rawhide that version is no longer available.


Note You need to log in before you can comment on or make changes to this bug.