Bugzilla will be upgraded to version 5.0 on a still to be determined date in the near future. The original upgrade date has been delayed.
Bug 232618 - Review Request: perl-XML-Filter-BufferText - Filter to put all characters() in one event
Review Request: perl-XML-Filter-BufferText - Filter to put all characters() i...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ville Skyttä
Fedora Package Reviews List
Depends On:
Blocks: 232619 232622
  Show dependency treegraph
Reported: 2007-03-16 09:24 EDT by Andreas Thienemann
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-03-23 06:18:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ville.skytta: fedora‑review+
wtogami: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Andreas Thienemann 2007-03-16 09:24:55 EDT
Spec URL: http://home.bawue.de/~ixs/perl-XML-Filter-BufferText/perl-XML-Filter-BufferText.spec
SRPM URL: http://home.bawue.de/~ixs/perl-XML-Filter-BufferText/perl-XML-Filter-BufferText-1.01-1.src.rpm
This is a very simple filter. One common cause of grief (and programmer
error) is that XML parsers aren't required to provide character events in
one chunk. They can, but are not forced to, and most don't. This filter
does the trivial but oft-repeated task of putting all characters into a
single event.
Comment 1 Ville Skyttä 2007-03-16 17:39:39 EDT
* Wrong permissions on installed files, there's no need for these to be
executable (please use rpmlint before submitting to save reviewer time):

E: perl-XML-Filter-BufferText script-without-shebang
W: perl-XML-Filter-BufferText spurious-executable-perm
W: perl-XML-Filter-BufferText spurious-executable-perm

* Use "BuildRequires: perl(ExtUtils::MakeMaker)" - that'll work for all distro
versions without need to do %if %fedora conditionals.

* Dependency on perl(XML::SAX::Base) missing - the auto dep generator doesn't
know how to extract dependencies from "use base qw(...)"
Comment 2 Andreas Thienemann 2007-03-17 05:47:43 EDT

New package adding the Requires.
About the rpmlint warnings and errors. I don't know when you pulled the srpm,
there was a wrong one online for a few minutes as I pulled the wrong revision
from the local RCS. Sorry for that. The rpmline failures were already fixed.

Please check again.
Comment 3 Ville Skyttä 2007-03-17 06:14:37 EDT
Looks good, approved.
Comment 4 Andreas Thienemann 2007-03-17 07:07:38 EDT
New Package CVS Request
Package Name: perl-XML-Filter-BufferText
Short Description: Filter to put all characters() in one event
Owners: andreas@bawue.net
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list@redhat.com
Comment 5 Andreas Thienemann 2007-03-23 06:18:02 EDT
Thanks for the review. Package has been built for FC-5, FC-6 and rawhide.

Note You need to log in before you can comment on or make changes to this bug.