Red Hat Bugzilla – Bug 232618
Review Request: perl-XML-Filter-BufferText - Filter to put all characters() in one event
Last modified: 2007-11-30 17:11:59 EST
Spec URL: http://home.bawue.de/~ixs/perl-XML-Filter-BufferText/perl-XML-Filter-BufferText.spec SRPM URL: http://home.bawue.de/~ixs/perl-XML-Filter-BufferText/perl-XML-Filter-BufferText-1.01-1.src.rpm Description: This is a very simple filter. One common cause of grief (and programmer error) is that XML parsers aren't required to provide character events in one chunk. They can, but are not forced to, and most don't. This filter does the trivial but oft-repeated task of putting all characters into a single event.
* Wrong permissions on installed files, there's no need for these to be executable (please use rpmlint before submitting to save reviewer time): E: perl-XML-Filter-BufferText script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/XML/Filter/BufferText.pm W: perl-XML-Filter-BufferText spurious-executable-perm /usr/share/doc/perl-XML-Filter-BufferText-1.01/README W: perl-XML-Filter-BufferText spurious-executable-perm /usr/share/doc/perl-XML-Filter-BufferText-1.01/Changes * Use "BuildRequires: perl(ExtUtils::MakeMaker)" - that'll work for all distro versions without need to do %if %fedora conditionals. * Dependency on perl(XML::SAX::Base) missing - the auto dep generator doesn't know how to extract dependencies from "use base qw(...)"
http://home.bawue.de/~ixs/perl-XML-Filter-BufferText/perl-XML-Filter-BufferText-1.01-2.src.rpm New package adding the Requires. About the rpmlint warnings and errors. I don't know when you pulled the srpm, there was a wrong one online for a few minutes as I pulled the wrong revision from the local RCS. Sorry for that. The rpmline failures were already fixed. Please check again.
Looks good, approved.
New Package CVS Request ======================= Package Name: perl-XML-Filter-BufferText Short Description: Filter to put all characters() in one event Owners: andreas@bawue.net Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list@redhat.com
Thanks for the review. Package has been built for FC-5, FC-6 and rawhide.