Bug 232619 - Review Request: perl-XML-SAX-Writer - SAX2 Writer
Summary: Review Request: perl-XML-SAX-Writer - SAX2 Writer
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On: 232618
Blocks: 232620
TreeView+ depends on / blocked
 
Reported: 2007-03-16 13:26 UTC by Andreas Thienemann
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-23 10:18:20 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ville.skytta: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Andreas Thienemann 2007-03-16 13:26:13 UTC
Spec URL: http://home.bawue.de/~ixs/perl-XML-SAX-Writer/perl-XML-SAX-Writer.spec
SRPM URL: http://home.bawue.de/~ixs/perl-XML-SAX-Writer/perl-XML-SAX-Writer-0.50-1.src.rpm
Description:

A new XML Writer to match the SAX2 effort.

Comment 1 Ville Skyttä 2007-03-17 20:13:03 UTC
* These explicit dependencies are dupes of (unversioned) autogenerated ones,
just remove them?  The versions seem to come from Makefile.PL but upstream has
chose to not require any particular version of things at runtime.
perl(Text::Iconv) >= 1.2
perl(XML::Filter::BufferText) >= 1.00
perl(XML::NamespaceSupport) >= 1.00
perl(XML::SAX::Exception) >= 1.01

* Doing the iconv-to-UTF-8 stuff for the man page only doesn't help perldoc. 
Doing it for Writer.pm in %prep would work for both man and perldoc.

Comment 2 Andreas Thienemann 2007-03-17 22:24:52 UTC
http://home.bawue.de/~ixs/perl-XML-SAX-Writer/perl-XML-SAX-Writer-0.50-2.src.rpm

new spec, fixing these issues.

Comment 3 Ville Skyttä 2007-03-18 10:35:14 UTC
Approved

Comment 4 Andreas Thienemann 2007-03-18 11:53:30 UTC
New Package CVS Request
=======================
Package Name: perl-XML-SAX-Writer
Short Description: SAX2 Writer
Owners: andreas@bawue.net
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list@redhat.com


Comment 5 Jens Petersen 2007-03-20 00:06:31 UTC
done

Comment 6 Andreas Thienemann 2007-03-23 10:18:20 UTC
Thanks for the review. Package has been built for FC-5, FC-6 and rawhide.


Note You need to log in before you can comment on or make changes to this bug.