Spec URL: http://home.bawue.de/~ixs/perl-XML-Filter-XInclude/perl-XML-Filter-XInclude.spec SRPM URL: http://home.bawue.de/~ixs/perl-XML-Filter-XInclude/perl-XML-Filter-XInclude-1.0-1.src.rpm Description: This module implements a simple SAX filter that provides XInclude support. It does NOT support XPointer.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6fd41f32027f3dbf6993fcef0ee81578 XML-Filter-XInclude-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00basic.......ok t/01xinclude....ok All tests successful. Files=2, Tests=3, 1 wallclock secs ( 0.20 cusr + 0.03 csys = 0.23 CPU) + Provides: perl(XML::Filter::XInclude) = 1.0 APPROVED.
New Package CVS Request ======================= Package Name: perl-XML-Filter-XInclude Short Description: XInclude as a SAX Filter Owners: andreas Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list
Thx for the review. Package has been built for devel, FC-5 and FC-6. Closing as NEXTRELEASE.