Bug 2326991 - Review Request: rust-base64-url - Base64 encode, decode, escape and unescape for URL applications.
Summary: Review Request: rust-base64-url - Base64 encode, decode, escape and unescape ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/base64-url
Whiteboard:
Depends On:
Blocks: 2327782
TreeView+ depends on / blocked
 
Reported: 2024-11-18 13:45 UTC by Uri Lublin
Modified: 2024-12-29 10:37 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-29 10:37:50 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)

Description Uri Lublin 2024-11-18 13:45:49 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08272752-rust-base64-url/rust-base64-url.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08272752-rust-base64-url/rust-base64-url-3.0.0-1.fc42.src.rpm

Description:
 - Encode data to a Base64-URL string.
 - Decode a Base64-URL string to data.
 - Escape a Base64 string to a Base64-URL string.
 - Unescape a Base64-URL string to a Base64-URL string.

Fedora Account System Username: uril

Comment 1 Fedora Review Service 2024-11-18 13:51:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8276066
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326991-rust-base64-url/fedora-rawhide-x86_64/08276066-rust-base64-url/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Cole Robinson 2024-12-07 17:07:48 UTC
Straight forward rust crate, nothing fancy here. Setting fedora-review+

Comment 3 Fabio Valentini 2024-12-07 18:47:57 UTC
(In reply to Cole Robinson from comment #2)
> Straight forward rust crate, nothing fancy here. Setting fedora-review+

That's a *very* minimalistic review :O but the package looks OK to me too.

Comment 4 Cole Robinson 2024-12-07 20:18:59 UTC
I'll document my work next time. Here's what I did:

* Submitted my own rawhide scratch build
* Confirmed output matched my own rust2rpm call
* Gave the spec a quick look to ensure nothing was weird
* Checked unpacked srpm contents to make sure I wasn't missing anything
* Looked at upstream code a bit to make sure I wasn't missing anything since the crate dep chain was so simple

@fabio what do you use for your rust package review template comment, is that just a custom thing? (obviously it's not fedora-review)

Comment 5 Fabio Valentini 2024-12-10 14:58:53 UTC
It's a custom snippet I use for Rust reviews (that I have adapted and extended from other people's snippets for Rust reviews).
I do check all the things on the list, though. :)

Comment 6 Fedora Admin user for bugzilla script actions 2024-12-23 17:27:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-base64-url

Comment 7 Fedora Update System 2024-12-29 10:33:08 UTC
FEDORA-2024-e4bac5294c (rust-base64-url-3.0.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e4bac5294c

Comment 8 Fedora Update System 2024-12-29 10:37:50 UTC
FEDORA-2024-e4bac5294c (rust-base64-url-3.0.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.