Bug 2327782 - Review Request: rust-az-tdx-vtpm - vTPM based TDX attestation for Azure Confidential VMs
Summary: Review Request: rust-az-tdx-vtpm - vTPM based TDX attestation for Azure Confi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Cole Robinson
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/az-tdx-vtpm
Whiteboard:
Depends On: 2326991 2327778
Blocks: 2328647
TreeView+ depends on / blocked
 
Reported: 2024-11-21 11:40 UTC by Uri Lublin
Modified: 2025-02-24 18:14 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-24 18:14:47 UTC
Type: ---
Embargoed:
crobinso: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8341341 to 8343839 (1019 bytes, patch)
2024-12-05 10:45 UTC, Fedora Review Service
no flags Details | Diff

Description Uri Lublin 2024-11-21 11:40:34 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08272805-rust-az-tdx-vtpm/rust-az-tdx-vtpm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08272805-rust-az-tdx-vtpm/rust-az-tdx-vtpm-0.7.0-1.fc42.src.rpm

Description: Enables getting confidential computing information from the
hardware/firmware, when running on a confidential VM (CVM) with Intel TDX on Azure.
The confidential computing "evidence" is used for attestation.

A part of https://github.com/kinvolk/azure-cvm-tooling/

Fedora Account System Username: uril

Comment 1 Uri Lublin 2024-12-04 16:02:22 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08335945-rust-az-tdx-vtpm/rust-az-tdx-vtpm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08335945-rust-az-tdx-vtpm/rust-az-tdx-vtpm-0.7.1-1.fc42.src.rpm

# rust2rpm az-tdx-vtpm -I

rust2rpm.toml:
[package]
extra-sources = [
    { "number" = 1, "file" = "LICENSE", "comments" = [ "SOURCES were copied from copied from github:",
	"http://github.com/kinvolk/azure-cvm-tooling/" ] },
    { "number" = 2, "file" = "hcl-report-tdx.bin", "comments" = [ "required by tests" ] },
    { "number" = 3, "file" = "certs.pem", "comments" = [ "required by tests" ] },
]
cargo-install-lib = true
cargo-install-bin = false

[scripts]
prep.pre = [ "cp -f %{SOURCE1} ." ]
check.pre = [ "mkdir -p ../test", "cp -f %{SOURCE2} %{SOURCE3} ../test" ]
check.post = [ "rm -rf ../test" ]

[features]
hide = ["integration_test"]

# Add to the %files:
# %license %{crate_instdir}/LICENSE

Comment 2 Fedora Review Service 2024-12-04 16:09:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8341341
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327782-rust-az-tdx-vtpm/fedora-rawhide-x86_64/08341341-rust-az-tdx-vtpm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Uri Lublin 2024-12-05 10:43:00 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08341824-rust-az-tdx-vtpm/rust-az-tdx-vtpm-0.7.1-1.fc42.src.rpm
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08341824-rust-az-tdx-vtpm/rust-az-tdx-vtpm-0.7.1-1.fc42.src.rpm

# rust2rpm az-tdx-vtpm -I

rust2rpm.toml:
[package]
extra-sources = [
    { "number" = 1, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/LICENSE", "comments" = [ "The crate does not contain LICENSE; Get it from upstream git repo" ] },
    { "number" = 2, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/az-cvm-vtpm/test/hcl-report-tdx.bin", "comments" = [ "required by tests" ] },
    { "number" = 3, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/az-cvm-vtpm/test/certs.pem", "comments" = [ "required by tests" ] },
]
cargo-install-lib = true
cargo-install-bin = false

[scripts]
prep.pre = [ "cp -f %{SOURCE1} ." ]
check.pre = [ "mkdir -p ../test", "cp -f %{SOURCE2} %{SOURCE3} ../test" ]
check.post = [ "rm -rf ../test" ]

[features]
hide = ["integration_test"]

# Add to the %files:
# %license %{crate_instdir}/LICENSE

Comment 4 Fedora Review Service 2024-12-05 10:45:07 UTC
Created attachment 2061331 [details]
The .spec file difference from Copr build 8341341 to 8343839

Comment 5 Fedora Review Service 2024-12-05 10:45:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8343839
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327782-rust-az-tdx-vtpm/fedora-rawhide-x86_64/08343839-rust-az-tdx-vtpm/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Uri Lublin 2025-02-16 15:02:44 UTC
SPEC URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08661169-rust-az-tdx-vtpm/rust-az-tdx-vtpm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/uril/trustee-attester/fedora-rawhide-x86_64/08661169-rust-az-tdx-vtpm/rust-az-tdx-vtpm-0.7.1-1.fc43.src.rpm

rust2rpm.toml:
[package]
extra-sources = [
    { "number" = 11, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/LICENSE", "comments" = [ "The crate does not contain LICENSE; Get it from upstream git repo", "http://github.com/kinvolk/azure-cvm-tooling/", "A patch was sent upstream:", "https://github.com/kinvolk/azure-cvm-tooling/pull/64" ] },
    { "number" = 12, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/az-cvm-vtpm/test/hcl-report-tdx.bin", "comments" = [ "required by tests" ] },
    { "number" = 13, "file" = "https://raw.githubusercontent.com/kinvolk/azure-cvm-tooling/2bef60b88db7554935177ec63dd169190a39eab7/az-cvm-vtpm/test/certs.pem", "comments" = [ "required by tests" ] },
]
cargo-install-lib = true
cargo-install-bin = false
supported-arches = [ "x86_64"]

[scripts]
prep.pre = [ "cp -f %{SOURCE11} ." ]
check.pre = [ "mkdir -p ../test", "cp -f %{SOURCE12} %{SOURCE13} ../test" ]
check.post = [ "rm -rf ../test" ]

[features]
hide = ["integration_test"]

# Add to the %files:
# %license %{crate_instdir}/LICENSE

#======================================

Fixing the package according to Cole's review comments in bug 2327780#c3

Comment 7 Fedora Review Service 2025-02-16 15:12:36 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8661290
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327782-rust-az-tdx-vtpm/fedora-rawhide-x86_64/08661290-rust-az-tdx-vtpm/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Cole Robinson 2025-02-16 18:58:07 UTC
rust2rpm.toml looks good to me

+ content matches rust2rpm.toml output (with the mentioned %license tweak)
+ builds on rawhide
+ installs on rawhide
+ content looks fine

setting fedora-review+

Comment 9 Fedora Admin user for bugzilla script actions 2025-02-24 13:57:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-az-tdx-vtpm

Comment 10 Fedora Update System 2025-02-24 18:11:18 UTC
FEDORA-2025-7ea26dce88 (rust-az-tdx-vtpm-0.7.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7ea26dce88

Comment 11 Fedora Update System 2025-02-24 18:14:47 UTC
FEDORA-2025-7ea26dce88 (rust-az-tdx-vtpm-0.7.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.