Bug 232703 - Review Request: perl-IO-Compress-Bzip2 - Write bzip2 files/buffers
Review Request: perl-IO-Compress-Bzip2 - Write bzip2 files/buffers
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Andreas Thienemann
Fedora Package Reviews List
Depends On: 228537 232702
  Show dependency treegraph
Reported: 2007-03-16 14:20 EDT by Steven Pritchard
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-06-27 18:20:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Steven Pritchard 2007-03-16 14:20:48 EDT
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-IO-Compress-Bzip2/perl-IO-Compress-Bzip2.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-IO-Compress-Bzip2-2.004-1.src.rpm
This module provides a Perl interface that allows writing bzip2 compressed
data to files or buffer.
Comment 1 Andreas Thienemann 2007-03-18 08:11:59 EDT
+ source files match upstream:    5ddb54bf0f91187786952cfbcf66cd00 
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ license is "GPL or Artistic".
+ latest version is being packaged.
- BuildRequires are somewhat proper. perl(IO::Compress::Base) is however not
+ compiler flags are appropriate.
o noarch package. $RPM_OPT_FLAGS are not necessary.
+ %clean is present.
+ package installs properly
o noarch package. no debuginfo package is being generated.
+ rpmlint is silent.
+ final provides and requires are sane:
== provides
perl(IO::Compress::Adapter::Bzip2) = 2.004
perl(IO::Compress::Bzip2) = 2.004
perl(IO::Uncompress::Adapter::Bunzip2) = 2.004
perl(IO::Uncompress::Bunzip2) = 2.004
perl-IO-Compress-Bzip2 = 2.004-1.fc7
== requires
perl(Compress::Raw::Bzip2) >= 2.004
perl(IO::Compress::Adapter::Bzip2) >= 2.004
perl(IO::Compress::Base) >= 2.004
perl(IO::Compress::Base::Common) >= 2.004
perl(IO::Uncompress::Adapter::Bunzip2) >= 2.004
perl(IO::Uncompress::Base) >= 2.004
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
- %check is present and all supported tests pass. However, Test::POD would be
useful as a BR
+ no shared libraries are added to the regular linker search paths.
+ no duplication of system libraries.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

The package looks okay and I'd approve it. Unfortunately, it does not build in
mock as of right now.
As soon as perl(IO::Compress::Base) 2.004 or higher is available I'll approve
that package.
Comment 2 Steven Pritchard 2007-06-27 17:21:34 EDT
It looks like perl-IO-Compress-Base 2.004 is in rawhide.  Can I get an 
official approval for this package?
Comment 3 Steven Pritchard 2007-06-27 17:26:52 EDT
Oh, wait, perl-IO-Compress-Bzip2 is there too.
Comment 4 Andreas Thienemann 2007-06-27 17:41:24 EDT
so we scrap this?
Comment 5 Jason Tibbitts 2007-06-27 18:11:20 EDT
I reviewed and approved perl-IO-Compress-Bzip2 as part of bug 243016 earlier
this month.  I had no idea this bug existed.
Comment 6 Steven Pritchard 2007-06-27 18:20:12 EDT
Let's chalk it up to merge confusion then and move on...

Note You need to log in before you can comment on or make changes to this bug.