Spec URL: https://pkgs.rpmfusion.org/cgit/free/mixxx.git/plain/mixxx.spec SRPM URL: https://ftp-stud.hs-esslingen.de/pub/Mirrors/rpmfusion.org/free/fedora/updates/testing/41/SRPMS/m/mixxx-2.4.2-3.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia
Copr build: https://copr.fedorainfracloud.org/coprs/build/8333314 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08333314-mixxx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking review. 1. Drop faad2 from BuildRequires and Requires. 2. Replace ffmpeg-devel with: pkgconfig(libavcodec) pkgconfig(libavformat) pkgconfig(libavutil) pkgconfig(libswresample) and let's see how far it goes then.
Updated spec file with suggestions. Does this trigger a new build?
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8335059 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08335059-mixxx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build] Fully remove ffmpeg from build
The spec file was unchanged. You're probably better off uploading the spec file and SRPM to a different location.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8335089 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08335089-mixxx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
You can upload the spec and SRPM via ssh to fedorapeople.org:public_html/ . It'll then be accessible as https://luisfcorreia.fedorapeople.org/ .
It seems that I can't login or access fedorapeople, perhaps because I don't belong to another group besides CLA
(In reply to Luís Correia from comment #10) > It seems that I can't login or access fedorapeople, perhaps because I don't > belong to another group besides CLA https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor ... If you have no place to put your spec and SRPM, use [copr](https://copr.fedorainfracloud.org/).
Ping.
I'm sorry, was away organizing and attending an event from all of last week. Will resume today or tomorrow.
Spec URL: https://luiscorreia.eu/files/mixxx.spec SRPM URL: https://luiscorreia.eu/files/mixxx-2.4.2-3.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia
Spec URL: https://luiscorreia.eu/files/mixxx.spec SRPM URL: https://luiscorreia.eu/files/mixxx-2.4.2-4.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8371530 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/srpm-builds/08371530/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8371531 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08371531-mixxx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://luiscorreia.eu/files/mixxx.spec SRPM URL: https://luiscorreia.eu/files/mixxx-2.4.2-5.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia
Created attachment 2061850 [details] The .spec file difference from Copr build 8371531 to 8372240
Copr build: https://copr.fedorainfracloud.org/coprs/build/8372240 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08372240-mixxx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://luiscorreia.eu/files/mixxx.spec SRPM URL: https://luiscorreia.eu/files/mixxx-2.4.2-6.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia
Created attachment 2061863 [details] The .spec file difference from Copr build 8372240 to 8372720
Copr build: https://copr.fedorainfracloud.org/coprs/build/8372720 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08372720-mixxx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://luiscorreia.eu/files/mixxx.spec SRPM URL: https://luiscorreia.eu/files/mixxx-2.4.2-7.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia
Created attachment 2061879 [details] The .spec file difference from Copr build 8372720 to 8372928
Copr build: https://copr.fedorainfracloud.org/coprs/build/8372928 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08372928-mixxx/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'GPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://luiscorreia.eu/files/mixxx.spec SRPM URL: https://luiscorreia.eu/files/mixxx-2.4.2-8.fc41.src.rpm Description: Mixxx is open source software for DJ'ing Fedora Account System Username: luisfcorreia
Created attachment 2061916 [details] The .spec file difference from Copr build 8372928 to 8373408
Copr build: https://copr.fedorainfracloud.org/coprs/build/8373408 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329895-mixxx/fedora-rawhide-x86_64/08373408-mixxx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There were some tests that failed and I took the liberty to comment them. However the MIXXX developers said that: "These tests indicated, that there is an issue with a sample offset using this MP3 decoder. This means that hotcues from existing Mixxx files/Mixxx library will have a time offset. To make this compatible, you need to add/substract this offset but leave the test case unmodified. Otherwise all users switching between rpmfusion builds of Mixxx and Fedora builds of Mixxx will have a lot of trouble adjusting all of there tracks."
Disclaimer: I am no longer affiliated with the Mixxx project. Just stumbled over this bug report as a long term Fedora user (and also contributor to both Fedora and RPM Fusion in the past). All failing tests reveal real issues that will affect users. The failing test firstSoundTest indicates that cue points and loops won't be accurate when switching the default decoder(s). Automatically adjusting track positions when using a different decoder has not been implemented yet. It was the main reason that prevented switching to FFmpeg for audio decoding, see https://github.com/mixxxdj/mixxx/issues/10313. The other failing tests (seekForwardBackward, seekBoundaries) indicate that decoding M4A files with FFmpeg is not working correctly. Maybe caused by the same code changes that prevent decoding of many MP3 files: https://github.com/mixxxdj/mixxx/issues/11923.
Thank you Uwe for explaining this is such detail. If FFAD2 and FFMPEG aren't allowed as is in Fedora, I'll close this bug and will continue to releade through RPMFusion.
(In reply to Uwe Klotz from comment #31) > Disclaimer: I am no longer affiliated with the Mixxx project. Just stumbled > over this bug report as a long term Fedora user (and also contributor to > both Fedora and RPM Fusion in the past). > > All failing tests reveal real issues that will affect users. > > The failing test firstSoundTest indicates that cue points and loops won't be > accurate when switching the default decoder(s). Automatically adjusting > track positions when using a different decoder has not been implemented yet. > It was the main reason that prevented switching to FFmpeg for audio > decoding, see https://github.com/mixxxdj/mixxx/issues/10313. Ok, this looks like a valid issue. We can't do much about missing FAAD2 until it's cleared by Red Hat legal folks. > The other failing tests (seekForwardBackward, seekBoundaries) indicate that > decoding M4A files with FFmpeg is not working correctly. Maybe caused by the > same code changes that prevent decoding of many MP3 files: > https://github.com/mixxxdj/mixxx/issues/11923. But I don't understand why you're pointing to this one. All MP3 decoders are permitted and available in Fedora: libmad, libmpg123, FFmpeg. So, if mixxx needs to use a specific one, it can. (In reply to Luís Correia from comment #30) > There were some tests that failed and I took the liberty to comment them. > > However the MIXXX developers said that: > "These tests indicated, that there is an issue with a sample offset using > this MP3 decoder. Which decoder should be used, then? > This means that hotcues from existing Mixxx files/Mixxx library will have a > time offset. > To make this compatible, you need to add/substract this offset but leave the > test case unmodified. > Otherwise all users switching between rpmfusion builds of Mixxx and Fedora > builds of Mixxx will have a lot of trouble adjusting all of there tracks." Was this an e-mail or is there an upstream issue open about this? I think that, apart from FAAD2, all other dependencies are present in Fedora, so I would not expect test failures other than related to AAC decoding.
Personally I use the RPM Fusion version of FFmpeg for both MP3 and M4A/AAC decoding, including the reverted changes in SoundSourceFFmpeg as proposed. All decoding tests are passing. Only the upstream firstSoundTest fails as expected. I had to adjust my stored cue points and loops manually over time after switching the decoder(s). The upstream version of Mixxx uses libmad for MP3 and FAAD2 for M4A decoding on Linux, hard-coded as defaults. FFmpeg is only used as a fallback if opening a file fails. All track positions created with the Linux-version depend on this configuration.
Closing this as it is currently not advisable to release with these bugs/features. Thank you all for all the provided insight on the issue.
Regarding these three failed tests: The following tests FAILED: 736 - SoundSourceProxyTest.seekForwardBackward (Failed) 738 - SoundSourceProxyTest.seekBoundaries (Failed) 741 - SoundSourceProxyTest.firstSoundTest (Failed) there seems to be a difference between FFmpeg build from RPM Fusion and Fedora that's causing this. I reproduced this in mock (with faad2 installed) by swapping ffmpeg-devel with ffmpeg-free-devel.
Note: faad2 presence makes no change here, the same 3 tests fail.