Spec URL: https://rathann.fedorapeople.org/review/mixxx/mixxx.spec SRPM URL: https://rathann.fedorapeople.org/review/mixxx/mixxx-2.5.3-2.fc44.src.rpm Description: Mixxx is open source software for DJ'ing. You can use AIFF/FLAC/M4A/MP3/OggVorbis/Opus/WAV/WavPack files, and other formats as audio input. Playback can be controlled through the GUI or with external controllers including MIDI and HID devices. Fedora Account System Username: rathann
Previous review.
Spec URL: https://rathann.fedorapeople.org/review/mixxx/mixxx.spec SRPM URL: https://rathann.fedorapeople.org/review/mixxx/mixxx-2.5.3-2.fc44.src.rpm Re-uploaded with some minor changes.
Taking this review.
The ticket summary is not in the correct format. Expected: Review Request: <main package name here> - <short summary here> Found: mixxx - Mixxx is open source software for DJ'ing As a consequence, the package name cannot be parsed and submitted to be automatically build. Please modify the ticket summary and trigger a build by typing [fedora-review-service-build]. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9763438 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412004-mixxx/fedora-rawhide-x86_64/09763438-mixxx/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'LGPL-2.1-or-later AND (BSD-3-Clause OR GPL-3.0-only OR HIDAPI) AND MIT AND GPL-2.0-or-later AND BSD-3-Clause AND AND MPL-1.1 AND GPL-3.0-or-later'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fedora Review Service from comment #7) > Found issues: > > - Not a valid SPDX expression 'LGPL-2.1-or-later AND (BSD-3-Clause OR > GPL-3.0-only OR HIDAPI) AND MIT AND GPL-2.0-or-later AND BSD-3-Clause AND > AND MPL-1.1 AND GPL-3.0-or-later'. I can see the duplicate AND. Fixing.
I noticed just one thing during the spec review: > BuildRequires: faad2-libs%{?_isa} Having %{?_isa} in a BR is not allowed. It results in a broken SRPM.
Created attachment 2112545 [details] The .spec file difference from Copr build 9763438 to 9763564
Copr build: https://copr.fedorainfracloud.org/coprs/build/9763564 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412004-mixxx/fedora-rawhide-x86_64/09763564-mixxx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed. Spec URL: https://rathann.fedorapeople.org/review/mixxx/mixxx.spec SRPM URL: https://rathann.fedorapeople.org/review/mixxx/mixxx-2.5.3-3.fc44.src.rpm
Created attachment 2112608 [details] The .spec file difference from Copr build 9763564 to 9763857
Copr build: https://copr.fedorainfracloud.org/coprs/build/9763857 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412004-mixxx/fedora-rawhide-x86_64/09763857-mixxx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> [ ]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/256x256, > /usr/lib/udev/rules.d, /usr/share/icons/hicolor/128x128, > /usr/share/icons/hicolor/512x512/apps, > /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor, > /usr/share/icons/hicolor/32x32, /usr/lib/udev, > /usr/share/icons/hicolor/128x128/apps, > /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/64x64, > /usr/share/icons/hicolor/256x256/apps, > /usr/share/icons/hicolor/scalable, > /usr/share/icons/hicolor/scalable/apps This package is missing "Requires: hicolor-icon-theme". Alas, there's no systemd-filesystem package, so it probably needs co-ownership of "/usr/lib/udev/rules.d" and "/usr/lib/udev".
Spec URL: https://rathann.fedorapeople.org/review/mixxx/mixxx.spec SRPM URL: https://rathann.fedorapeople.org/review/mixxx/mixxx-2.5.3-3.fc44.src.rpm Fixed.
I mean: Spec URL: https://rathann.fedorapeople.org/review/mixxx/mixxx.spec SRPM URL: https://rathann.fedorapeople.org/review/mixxx/mixxx-2.5.3-4.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9780363 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412004-mixxx/fedora-rawhide-x86_64/09780363-mixxx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2113446 [details] The .spec file difference from Copr build 9780362 to 9780363
Copr build: https://copr.fedorainfracloud.org/coprs/build/9780362 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2412004-mixxx/fedora-rawhide-x86_64/09780362-mixxx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I think at this point everything looks good. PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/mixxx
FEDORA-2025-c503dce0f9 (mixxx-2.5.3-4.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c503dce0f9
FEDORA-2025-d1c65b0718 (mixxx-2.5.3-4.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d1c65b0718
FEDORA-2025-c503dce0f9 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c503dce0f9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c503dce0f9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-d1c65b0718 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-d1c65b0718 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-d1c65b0718 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-d1c65b0718 (mixxx-2.5.3-4.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-c503dce0f9 (mixxx-2.5.3-4.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.