Bug 2330103 - Review Request: rust-asn1-rs - Rust parsers/encoders for ASN.1 BER/DER data
Summary: Review Request: rust-asn1-rs - Rust parsers/encoders for ASN.1 BER/DER data
Keywords:
Status: CLOSED DUPLICATE of bug 2312637
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/asn1-rs
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-03 03:15 UTC by Tyler Fanelli
Modified: 2024-12-05 22:13 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-05 19:25:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 8335889 to 8335929 (2.59 KB, patch)
2024-12-03 05:24 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8335929 to 8335947 (2.42 KB, patch)
2024-12-03 05:58 UTC, Fedora Review Service
no flags Details | Diff

Description Tyler Fanelli 2024-12-03 03:15:16 UTC
Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/refs/heads/main/rust-asn1-rs.spec
SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/main/rust-asn1-rs-0.6.2-1.fc42.src.rpm
Description: Rust parsers/encoders for ASN.1 BER/DER data
Fedora Account System Username: tfanelli

Comment 1 Fedora Review Service 2024-12-03 03:19:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8335820
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330103-rust-asn1-rs/fedora-rawhide-x86_64/08335820-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tyler Fanelli 2024-12-03 04:29:19 UTC
Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/refs/heads/main/rust-asn1-rs.spec
SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/main/rust-asn1-rs-0.6.2-1.fc42.src.rpm
Description: Rust parsers/encoders for ASN.1 BER/DER data
Fedora Account System Username: tfanelli

Comment 3 Fedora Review Service 2024-12-03 04:31:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8335889
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330103-rust-asn1-rs/fedora-rawhide-x86_64/08335889-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Tyler Fanelli 2024-12-03 05:21:29 UTC
Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/refs/heads/main/rust-asn1-rs.spec
SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/main/rust-asn1-rs-0.6.2-1.fc42.src.rpm
Description: Rust parsers/encoders for ASN.1 BER/DER data
Fedora Account System Username: tfanelli

Comment 5 Fedora Review Service 2024-12-03 05:24:53 UTC
Created attachment 2060904 [details]
The .spec file difference from Copr build 8335889 to 8335929

Comment 6 Fedora Review Service 2024-12-03 05:24:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8335929
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330103-rust-asn1-rs/fedora-rawhide-x86_64/08335929-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Tyler Fanelli 2024-12-03 05:55:50 UTC
Spec URL: https://raw.githubusercontent.com/tylerfanelli/f42-rust-asn1-rs-candidate/refs/heads/main/rust-asn1-rs.spec
SRPM URL: https://github.com/tylerfanelli/f42-rust-asn1-rs-candidate/raw/refs/heads/main/rust-asn1-rs-0.6.2-1.fc42.src.rpm
Description: Rust parsers/encoders for ASN.1 BER/DER data
Fedora Account System Username: tfanelli

Comment 8 Fedora Review Service 2024-12-03 05:58:40 UTC
Created attachment 2060907 [details]
The .spec file difference from Copr build 8335929 to 8335947

Comment 9 Fedora Review Service 2024-12-03 05:58:42 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8335947
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330103-rust-asn1-rs/fedora-rawhide-x86_64/08335947-rust-asn1-rs/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Daniel Berrangé 2024-12-05 17:48:26 UTC
The automated builds being reported here are useless as they're against outdated stable Fedora which lacks the pre-req rust packages.

Doing a rawhide build though, shows a dependency flaw breaking test suite execution:

https://koji.fedoraproject.org/koji/taskinfo?taskID=126548833

error: no matching package named `bitvec` found
location searched: registry `crates-io`
required by package `asn1-rs-tests v0.0.0 (/builddir/build/BUILD/rust-asn1-rs-0.6.2-build/asn1-rs-0.6.2/target/tests/trybuild/asn1-rs)`

Comment 11 Fabio Valentini 2024-12-05 19:25:02 UTC
This package has also already been submitted for review.

And it looks like Davide has figured out how to fix the tests.

*** This bug has been marked as a duplicate of bug 2312637 ***

Comment 12 Tyler Fanelli 2024-12-05 22:07:55 UTC
Thanks for letting me know. In the future, how can I check if a package was already submitted for review?

Comment 13 Fabio Valentini 2024-12-05 22:13:13 UTC
There's a dashboard of pending package reviews here (reviewable are packages that aren't blocked, there's also other views for "hidden" / blocked or "in progress" reviews):
https://fedoraproject.org/PackageReviewStatus/reviewable.html

If you use the fedora-create-review for filing your package review request tickets, it will also warn you about a pre-existing ticket for the same package before filing a new one.


Note You need to log in before you can comment on or make changes to this bug.