Spec URL: https://slaanesh.fedorapeople.org/review/python-symengine.spec SRPM URL: https://slaanesh.fedorapeople.org/review/python-symengine-0.13.0-1.fc41.src.rpm Description: Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. Fedora Account System Username: slaanesh
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Building this like a normal python package, with all its macros, makes the %pyproject_install macro fail in the middle as the files get installed in both %python3_sitelib and %python3_sitearch. Also, compiler flags for the cython library are not passed correctly to CMAke in this case. Upstream and other distributions use CMake for building, so here it is.
(In reply to Fedora Review Service from comment #1) > Cannot find any valid SRPM URL for this ticket. Common causes are: > > - You didn't specify `SRPM URL: ...` in the ticket description > or any of your comments > - The URL schema isn't HTTP or HTTPS > - The SRPM package linked in your URL doesn't match the package name > specified > in the ticket summary > > > --- > This comment was created by the fedora-review-service > https://github.com/FrostyX/fedora-review-service > > If you want to trigger a new Copr build, add a comment containing new > Spec and SRPM URLs or [fedora-review-service-build] string. Don't know where this message comes from, but both spec file and package are available at the URL specified.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8422642 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333030-python-symengine/fedora-rawhide-x86_64/08422642-python-symengine/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://slaanesh.fedorapeople.org/review/python-symengine.spec SRPM URL: https://slaanesh.fedorapeople.org/review/python-symengine-0.13.0-1.fc41.src.rpm - Added cereal-devel builde dependency, now that symengine is using that. - Add ExcludeArch: %{ix86} since symengine does not build on i686.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8451126 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333030-python-symengine/srpm-builds/08451126/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://slaanesh.fedorapeople.org/review/python-symengine.spec SRPM URL: https://slaanesh.fedorapeople.org/review/python-symengine-0.13.0-1.fc41.src.rpm - Switch to building as a Python module that calls in the back CMake, and not viceversa. - Reassemble the wheel before %install to get everything in %python3_sitearch. - Reassembling the wheel makes the build patch useless.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8452477 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333030-python-symengine/fedora-rawhide-x86_64/08452477-python-symengine/fedora-review/review.txt Found issues: - python3-symengine : /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-symengine : /usr/lib64/python3.13/site- packages/symengine/lib/pywrapper.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 88 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/python-symengine/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13/site- packages, /usr/lib64/python3.13 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4695 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-symengine , python3-symengine-tests [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-symengine-0.13.0-1.fc42.x86_64.rpm python3-symengine-tests-0.13.0-1.fc42.x86_64.rpm python-symengine-debugsource-0.13.0-1.fc42.x86_64.rpm python-symengine-0.13.0-1.fc42.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp50wa70u4')] checks: 32, packages: 4 python3-symengine.x86_64: W: python-bytecode-without-source /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.opt-1.pyc python3-symengine.x86_64: W: python-bytecode-without-source /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.pyc python3-symengine-tests.x86_64: W: no-documentation python3-symengine.x86_64: E: invalid-soname /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so symengine_wrapper.cpython-313-x86_64-linux-gnu.so python3-symengine.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h python-symengine.src: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. python3-symengine.x86_64: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. python3-symengine-tests.x86_64: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. ========= 4 packages and 0 specfiles checked; 4 errors, 4 warnings, 17 filtered, 4 badness; has taken 0.6 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 python3-symengine.x86_64: W: python-bytecode-without-source /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.opt-1.pyc python3-symengine.x86_64: W: python-bytecode-without-source /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.pyc python3-symengine-tests.x86_64: W: no-documentation python3-symengine.x86_64: E: invalid-soname /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so symengine_wrapper.cpython-313-x86_64-linux-gnu.so python3-symengine.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h python3-symengine.x86_64: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. python3-symengine-tests.x86_64: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. 3 packages and 0 specfiles checked; 3 errors, 4 warnings, 13 filtered, 3 badness; has taken 0.2 s Unversioned so-files -------------------- python3-symengine: /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/symengine/symengine.py/archive/v0.13.0/symengine.py-0.13.0.tar.gz : CHECKSUM(SHA256) this package : fa48beb9b8d4574482edf19dc8671d4cb78f53c2511047a0e52bb88fbdeb6d0c CHECKSUM(SHA256) upstream package : fa48beb9b8d4574482edf19dc8671d4cb78f53c2511047a0e52bb88fbdeb6d0c Requires -------- python3-symengine (rpmlib, GLIBC filtered): libc.so.6()(64bit) libflint.so.19()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libmpfr.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsymengine.so.0.13()(64bit) python(abi) rtld(GNU_HASH) python3-symengine-tests (rpmlib, GLIBC filtered): python(abi) python3-symengine python-symengine-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-symengine: python-symengine python-symengine.py python3-symengine python3-symengine(x86-64) python3.13-symengine python3.13-symengine.py python3.13dist(symengine) python3dist(symengine) python3-symengine-tests: python-symengine-tests python3-symengine-tests python3-symengine-tests(x86-64) python3.13-symengine-tests python-symengine-debugsource: python-symengine-debugsource python-symengine-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n python-symengine-0.13.0-1.fc41.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api, Python Disabled plugins: Perl, fonts, Ocaml, R, Haskell, SugarActivity, Java, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: Package is not known to require an ExcludeArch tag. Noting that we are excluding 32bit. [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-symengine , python3-symengine-tests Update the Requires to match. [!]: Packages should try to preserve timestamps of original installed files. unzip/zip will preserve. We need to add -a or -p to the cp commands. python3-symengine.x86_64: W: python-bytecode-without-source /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.opt-1.pyc python3-symengine.x86_64: W: python-bytecode-without-source /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities.cpython-313.pyc We need to ship the source of these. [!]: Development files must be in a -devel package python3-symengine.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h https://docs.fedoraproject.org/en-US/packaging-guidelines/#_exceptions_3 seems to indicate we need to put this one file in a -devel subpackage? If not, maybe we need to delete it? python-symengine.src: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. python3-symengine.x86_64: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. python3-symengine-tests.x86_64: E: description-line-too-long Python wrappers to the C++ library SymEngine, a fast C++ symbolic manipulation library. Let's just change this to "Python wrappers to the C++ library SymEngine" to make this happy. Issues: ======= - Header files in -devel subpackage, if present. Note: python3-symengine : /usr/lib64/python3.13/site- packages/symengine/lib/pywrapper.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Unversioned so-files -------------------- python3-symengine: /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so python3-symengine.x86_64: E: invalid-soname /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so symengine_wrapper.cpython-313-x86_64-linux-gnu.so Per https://docs.fedoraproject.org/en-US/packaging-guidelines/Unversioned_shared_objects/ this is okay.
- in %check please indent the contents of the for loop - %{?python_provide:%python_provide python3-%{srcname}} shouldn't be needed anymore - you're using %pyproject_buildrequires -t but this package isn't using tox, so the -t is probably not needed?
(In reply to Jonathan Steffan from comment #10) > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > python3-symengine , python3-symengine-tests > > Update the Requires to match. Fixed, python3-symengine Requires: %{name}%{?_isa} = %{version}-%{release}, and python3-symengine-tests Requires: python3-symengine = %{version}-%{release} > [!]: Packages should try to preserve timestamps of original installed > files. > > unzip/zip will preserve. > We need to add -a or -p to the cp commands. Changed cp -fr to cp -ar. > python3-symengine.x86_64: W: python-bytecode-without-source > /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities. > cpython-313.opt-1.pyc > python3-symengine.x86_64: W: python-bytecode-without-source > /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities. > cpython-313.pyc > > We need to ship the source of these. Adjust the %files section, the source for the compiled python file is in the tests subpackage: %files -n python3-symengine -f %{pyproject_files} %license LICENSE %doc AUTHORS README.md %exclude %{python3_sitearch}/symengine/test_utilities.py %exclude %{python3_sitearch}/symengine/tests %exclude %{python3_sitearch}/symengine/__pycache__/test_utilities.*.pyc %files -n python3-symengine-tests %{python3_sitearch}/symengine/test_utilities.py %{python3_sitearch}/symengine/tests %{python3_sitearch}/symengine/__pycache__/test_utilities.*.pyc > [!]: Development files must be in a -devel package > python3-symengine.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_exceptions_3 > seems to indicate we need to put this one file in a -devel subpackage? If > not, maybe we need to delete it? It's required by the symengine.pxd file, so we must ship it: cdef extern from "pywrapper.h" namespace "SymEngine": > > python-symengine.src: E: description-line-too-long Python wrappers to the > C++ library SymEngine, a fast C++ symbolic manipulation library. > python3-symengine.x86_64: E: description-line-too-long Python wrappers to > the C++ library SymEngine, a fast C++ symbolic manipulation library. > python3-symengine-tests.x86_64: E: description-line-too-long Python wrappers > to the C++ library SymEngine, a fast C++ symbolic manipulation library. > > Let's just change this to "Python wrappers to the C++ library SymEngine" to > make this happy. I've just put a new line in the middle. Please note that fedora-review is not in good shape, rpmlint does not complain about this. (In reply to Davide Cavalca from comment #11) > - in %check please indent the contents of the for loop Done. > - %{?python_provide:%python_provide python3-%{srcname}} shouldn't be needed > anymore Right, removed. > - you're using %pyproject_buildrequires -t but this package isn't using tox, > so the -t is probably not needed? Correct, I don't know why, but in my mind the -t means "test" and not "tox". Removed.
Spec URL: https://slaanesh.fedorapeople.org/review/python-symengine.spec SRPM URL: https://slaanesh.fedorapeople.org/review/python-symengine-0.13.0-1.fc41.src.rpm - Save file timestamps in the Python wheel - Adjust files section for test_utilities.pyc - Adjust description. - Drop "-t" in %pyproject_buildrequires. - Indent for loop in %check. - Adjust package Provides/Requires.
(In reply to Simone Caronni from comment #12) > Fixed, python3-symengine Requires: %{name}%{?_isa} = %{version}-%{release}, > and python3-symengine-tests Requires: python3-symengine = > %{version}-%{release} Correction: python3-symengine Requires: symengine%{?_isa} >= %{version} python3-symengine-tests Requires: python3-symengine = %{version}-%{release}
No changes required on cnkalman.
Created attachment 2064348 [details] The .spec file difference from Copr build 8452477 to 8458072
Copr build: https://copr.fedorainfracloud.org/coprs/build/8458072 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333030-python-symengine/fedora-rawhide-x86_64/08458072-python-symengine/fedora-review/review.txt Found issues: - python3-symengine : /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-symengine : /usr/lib64/python3.13/site- packages/symengine/lib/pywrapper.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 88 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/python-symengine/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13/site- packages, /usr/lib64/python3.13 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4695 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-symengine , python3-symengine-tests [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-symengine-0.13.0-1.fc42.x86_64.rpm python3-symengine-tests-0.13.0-1.fc42.x86_64.rpm python-symengine-debugsource-0.13.0-1.fc42.x86_64.rpm python-symengine-0.13.0-1.fc42.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfyjiitiq')] checks: 32, packages: 4 python3-symengine-tests.x86_64: W: no-documentation python3-symengine.x86_64: E: invalid-soname /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so symengine_wrapper.cpython-313-x86_64-linux-gnu.so python3-symengine.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h ========= 4 packages and 0 specfiles checked; 1 errors, 2 warnings, 18 filtered, 1 badness; has taken 0.6 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 python3-symengine-tests.x86_64: W: no-documentation python3-symengine.x86_64: E: invalid-soname /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so symengine_wrapper.cpython-313-x86_64-linux-gnu.so python3-symengine.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h 3 packages and 0 specfiles checked; 1 errors, 2 warnings, 14 filtered, 1 badness; has taken 0.2 s Unversioned so-files -------------------- python3-symengine: /usr/lib64/python3.13/site-packages/symengine/lib/symengine_wrapper.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/symengine/symengine.py/archive/v0.13.0/symengine.py-0.13.0.tar.gz : CHECKSUM(SHA256) this package : fa48beb9b8d4574482edf19dc8671d4cb78f53c2511047a0e52bb88fbdeb6d0c CHECKSUM(SHA256) upstream package : fa48beb9b8d4574482edf19dc8671d4cb78f53c2511047a0e52bb88fbdeb6d0c Requires -------- python3-symengine (rpmlib, GLIBC filtered): libc.so.6()(64bit) libflint.so.19()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libmpfr.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libsymengine.so.0.13()(64bit) python(abi) rtld(GNU_HASH) symengine(x86-64) python3-symengine-tests (rpmlib, GLIBC filtered): python(abi) python3-symengine python-symengine-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-symengine: python-symengine python3-symengine python3-symengine(x86-64) python3.13-symengine python3.13dist(symengine) python3dist(symengine) python3-symengine-tests: python-symengine-tests python3-symengine-tests python3-symengine-tests(x86-64) python3.13-symengine-tests python-symengine-debugsource: python-symengine-debugsource python-symengine-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n python-symengine-0.13.0-1.fc41.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic, Python Disabled plugins: SugarActivity, R, Haskell, Ocaml, fonts, Perl, Java, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Issues: ======= - Header files in -devel subpackage, if present. Note: python3-symengine : /usr/lib64/python3.13/site- packages/symengine/lib/pywrapper.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages [!]: Development files must be in a -devel package python3-symengine.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h Are we sure this should not be a -devel package? It seems alright to me but I wanted to check. [!]: Package is not known to require an ExcludeArch tag. Noting that 32bit is excluded so anything that requires this will need to also have the ExcludeArch: %{ix86}. [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-symengine , python3-symengine-tests Still needs updated.
(In reply to Jonathan Steffan from comment #19) > Issues: > ======= > - Header files in -devel subpackage, if present. > Note: python3-symengine : /usr/lib64/python3.13/site- > packages/symengine/lib/pywrapper.h > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_devel_packages > > [!]: Development files must be in a -devel package > python3-symengine.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h > > Are we sure this should not be a -devel package? It seems alright to me but > I wanted to check. Again, it's sourced in the pxd file. We need it there. > [!]: Package is not known to require an ExcludeArch tag. > > Noting that 32bit is excluded so anything that requires this will need to > also have the ExcludeArch: %{ix86}. > > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > python3-symengine , python3-symengine-tests > > Still needs updated. No, it does not, please read. The source package is called python-symengine, we don't want python3-symengine to require python-symengine (which is not even a package).
(In reply to Simone Caronni from comment #14) > python3-symengine Requires: symengine%{?_isa} >= %{version} > > python3-symengine-tests Requires: python3-symengine = %{version}-%{release} These are the correct requirements.
(In reply to Simone Caronni from comment #20) > > [!]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > > python3-symengine , python3-symengine-tests > > > > Still needs updated. > > No, it does not, please read. The source package is called python-symengine, > we don't want python3-symengine to require python-symengine (which is not > even a package). >%package -n python3-symengine >Summary: %{summary} >Requires: symengine%{?_isa} >= %{version} This doesn't seem like it should be ">=" and should rather be "="? Because this is an unversioned SONAME we need to be sure to install the exact matching C libs? >%description -n python3-symengine %{common_description} > >%package -n python3-symengine-tests >Summary: %{summary} tests >Requires: python3-symengine = %{version}-%{release} Shouldn't this be "python3-symengine%{?_isa} = %{version}-%{release}"?
(In reply to Jonathan Steffan from comment #22) > (In reply to Simone Caronni from comment #20) > > > [!]: Fully versioned dependency in subpackages if applicable. > > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > > > python3-symengine , python3-symengine-tests > > > > > > Still needs updated. > > > > No, it does not, please read. The source package is called python-symengine, > > we don't want python3-symengine to require python-symengine (which is not > > even a package). > > >%package -n python3-symengine > >Summary: %{summary} > >Requires: symengine%{?_isa} >= %{version} > > This doesn't seem like it should be ">=" and should rather be "="? Because > this is an unversioned SONAME we need to be sure to install the exact > matching C libs? To be honest I don't know how the versioning of the two components is, I don't know if symengine.py requires a minimum version or if the project need to be in sync with releases. > >%description -n python3-symengine %{common_description} > > > >%package -n python3-symengine-tests > >Summary: %{summary} tests > >Requires: python3-symengine = %{version}-%{release} > > Shouldn't this be "python3-symengine%{?_isa} = %{version}-%{release}"? Sounds correct, considering we're making everything go into %python3_sitearch.
Spec URL: https://slaanesh.fedorapeople.org/review/python-symengine.spec SRPM URL: https://slaanesh.fedorapeople.org/review/python-symengine-0.13.0-1.fc41.src.rpm - python3-symengine-tests requires python3-symengine%{?_isa} = %{version}-%{release}
APPROVED
thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-symengine
Adding xr-sig as admins.
FEDORA-2025-2afdb51b12 (python-symengine-0.13.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2afdb51b12
FEDORA-2025-2b715814f5 (python-symengine-0.13.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2b715814f5
FEDORA-2025-2afdb51b12 (python-symengine-0.13.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-2b715814f5 (python-symengine-0.13.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.