Spec URL: https://slaanesh.fedorapeople.org/review/cnkalman.spec SRPM URL: https://slaanesh.fedorapeople.org/review/cnkalman-0.1%5e20230315gitf0c11f7-1.fc41.src.rpm Description: Low level implementation of a kalman filter; with support for extended and iterative extended kalman filters. The goals of the project are to provide a numerically stable, robust EKF implementation which is both fast and portable. Fedora Account System Username: slaanesh
Requires https://bugzilla.redhat.com/show_bug.cgi?id=2333030 and cnmatrix, symengine and sciplot0.2 currently in updates-testing.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8452119 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334700-cnkalman/fedora-rawhide-x86_64/08452119-cnkalman/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 51 files have unknown license. [!]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13/site- packages, /usr/lib64/python3.13 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5742 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cnkalman [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: cnkalman-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-devel-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm python3-cnkalman-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-debuginfo-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-debugsource-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-0.1^20230315gitf0c11f7-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpby627sj5')] checks: 32, packages: 6 cnkalman-devel.x86_64: W: no-documentation python3-cnkalman.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 36 filtered, 0 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: cnkalman-debuginfo-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpz1uk_uaw')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 cnkalman.x86_64: E: undefined-non-weak-symbol /usr/lib64/libcnkalman.so.0 cnSetZero (/usr/lib64/libcnkalman.so.0) cnkalman-devel.x86_64: W: no-documentation python3-cnkalman.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 2 warnings, 32 filtered, 1 badness; has taken 0.4 s Unversioned so-files -------------------- python3-cnkalman: /usr/lib64/python3.13/site-packages/filter.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/cntools/cnkalman/archive/f0c11f7ca17311fc488933a6cc253953c1b54273.tar.gz#/cnkalman-f0c11f7.tar.gz : CHECKSUM(SHA256) this package : fdb2228d19c6236a74f55b1016d0e8b31cea34a7b5480d4a868f8c098cb44d8c CHECKSUM(SHA256) upstream package : fdb2228d19c6236a74f55b1016d0e8b31cea34a7b5480d4a868f8c098cb44d8c Requires -------- cnkalman (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcnmatrix.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) cnkalman-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cnkalman(x86-64) libcnkalman.so.0()(64bit) python3-cnkalman (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcnkalman.so.0()(64bit) libcnmatrix.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3.13dist(cmake) python3.13dist(symengine) python3.13dist(sympy) rtld(GNU_HASH) cnkalman-debuginfo (rpmlib, GLIBC filtered): cnkalman-debugsource (rpmlib, GLIBC filtered): Provides -------- cnkalman: cnkalman cnkalman(x86-64) libcnkalman.so.0()(64bit) cnkalman-devel: cnkalman-devel cnkalman-devel(x86-64) pkgconfig(cnkalman) python3-cnkalman: python-cnkalman python3-cnkalman python3-cnkalman(x86-64) python3.13-cnkalman python3.13dist(cnkalman) python3dist(cnkalman) cnkalman-debuginfo: cnkalman-debuginfo cnkalman-debuginfo(x86-64) debuginfo(build-id) libcnkalman.so.0-0.1^20230315gitf0c11f7-1.fc42.x86_64.debug()(64bit) cnkalman-debugsource: cnkalman-debugsource cnkalman-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n cnkalman-0.1^20230315gitf0c11f7-1.fc41.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python, C/C++ Disabled plugins: R, fonts, Perl, Haskell, Ocaml, PHP, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 %{python3_sitearch}/* needs to be updated to only define files for this package or use the macros. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. We are likely going to need to patch to add a SONAME and punt upstream. [!]: License file installed when any subpackage combination is installed. LICENSE is not installed when python3-%{name} is installed. [!]: Package is not known to require an ExcludeArch tag. [!]: Package should compile and build into binary rpms on all supported architectures. Due to ExcludeArch for 32bit on python3-symengine we will need to do that in this package too. https://koji.fedoraproject.org/koji/taskinfo?taskID=127468995 [!]: Package complies to the Packaging Guidelines Unversioned SONAME in the loader path without a clear exception. %{_libdir}/lib%{name}.so.* included in both the main file and the -devel package. [!]: Package meets the Packaging Guidelines::Python Need to clean up the %files for this. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Patch0: cnkalman-shared.patch [!]: %check is present and all tests pass. There are tests, we should try to run them.
(In reply to Jonathan Steffan from comment #4) > Issues: > ======= > - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files > Note: Package contains %{pythonX_site(lib|arch)}/* in %files > See: https://pagure.io/packaging-committee/issue/782 > > %{python3_sitearch}/* needs to be updated to only define files for this > package or use the macros. Fixed by listing files and folders. As written in the SPEC file comments, we can't use the %pyproject_save_files macro. > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > > We are likely going to need to patch to add a SONAME and punt upstream. This is not an unversioned library, this is the Python filter library and it's correct: $ rpm -qpl python3-cnkalman-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm | grep \.so /usr/lib64/python3.13/site-packages/filter.cpython-313-x86_64-linux-gnu.so > [!]: License file installed when any subpackage combination is installed. > > LICENSE is not installed when python3-%{name} is installed. This is not correct, as the Python package depends on the library file due to the Python filter library: $ rpm -qp --requires python3-cnkalman-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm | grep libcnkalman libcnkalman.so.0()(64bit) > [!]: Package is not known to require an ExcludeArch tag. > [!]: Package should compile and build into binary rpms on all supported > architectures. > > Due to ExcludeArch for 32bit on python3-symengine we will need to do that in > this package too. > > https://koji.fedoraproject.org/koji/taskinfo?taskID=127468995 Fixed. > [!]: Package complies to the Packaging Guidelines > > Unversioned SONAME in the loader path without a clear exception. > %{_libdir}/lib%{name}.so.* included in both the main file and the -devel > package. This is not the case, I think the output is from an earlier version of the spec file: $ rpm -qpl 'cnkalman-devel-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm' | grep lib64 /usr/lib64/libcnkalman.so /usr/lib64/pkgconfig/cnkalman.pc $ rpm -qpl 'cnkalman-0.1^20230315gitf0c11f7-1.fc41.x86_64.rpm' | grep lib64 /usr/lib64/libcnkalman.so.0 > [!]: Package meets the Packaging Guidelines::Python > > Need to clean up the %files for this. Fixed in the first step. > [!]: %check is present and all tests pass. > > There are tests, we should try to run them. Struggling a bit with tests/TestKalmanModels.cc, I can't link properly cnmatrix for the cnSetZero function.
Spec URL: https://slaanesh.fedorapeople.org/review/cnkalman.spec SRPM URL: https://slaanesh.fedorapeople.org/review/cnkalman-0.1%5e20230315gitf0c11f7-1.fc41.src.rpm - Adjust Python subpackage in %files section. - Excluded i686. - Enable tests.
Created attachment 2065037 [details] The .spec file difference from Copr build 8452119 to 8481260
Copr build: https://copr.fedorainfracloud.org/coprs/build/8481260 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334700-cnkalman/fedora-rawhide-x86_64/08481260-cnkalman/fedora-review/review.txt Found issues: - Package contains %{pythonX_site(lib|arch)}/* in %files Read more: https://pagure.io/packaging-committee/issue/782 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # Run both intallation methods and then remove the overlapping files installed s/intallation/installation/ > %{_libdir}/lib%{name}.so.* This globbing is too coarse, you want to have the soversion in there, like in libfoo.so.1{,.*} so that if upstream ever bumps it the build will fail and you'll notice.
(In reply to Davide Cavalca from comment #9) > > # Run both intallation methods and then remove the overlapping files installed > > s/intallation/installation/ > > > %{_libdir}/lib%{name}.so.* > > This globbing is too coarse, you want to have the soversion in there, like > in libfoo.so.1{,.*} so that if upstream ever bumps it the build will fail > and you'll notice. Usually yes, but if you remember upstream does not provide the necessary glue to build a shared library at all, so the soversion is set to an arbitrary 0.0.0 the patch.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 51 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/cnkalman/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13, /usr/lib64/python3.13/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5742 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cnkalman [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: cnkalman-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-devel-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm python3-cnkalman-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-debuginfo-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-debugsource-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm cnkalman-0.1^20230315gitf0c11f7-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpflqrvhwp')] checks: 32, packages: 6 cnkalman-devel.x86_64: W: no-documentation python3-cnkalman.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 2 warnings, 37 filtered, 0 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: cnkalman-debuginfo-0.1^20230315gitf0c11f7-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2h3djemi')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 cnkalman.x86_64: E: undefined-non-weak-symbol /usr/lib64/libcnkalman.so.0 cnSetZero (/usr/lib64/libcnkalman.so.0) python3-cnkalman.x86_64: W: no-documentation cnkalman-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 1 errors, 2 warnings, 34 filtered, 1 badness; has taken 0.4 s Unversioned so-files -------------------- python3-cnkalman: /usr/lib64/python3.13/site-packages/filter.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/cntools/cnkalman/archive/f0c11f7ca17311fc488933a6cc253953c1b54273.tar.gz#/cnkalman-f0c11f7.tar.gz : CHECKSUM(SHA256) this package : fdb2228d19c6236a74f55b1016d0e8b31cea34a7b5480d4a868f8c098cb44d8c CHECKSUM(SHA256) upstream package : fdb2228d19c6236a74f55b1016d0e8b31cea34a7b5480d4a868f8c098cb44d8c Requires -------- cnkalman (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcnmatrix.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) cnkalman-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cnkalman(x86-64) libcnkalman.so.0()(64bit) python3-cnkalman (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcnkalman.so.0()(64bit) libcnmatrix.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3.13dist(cmake) python3.13dist(symengine) python3.13dist(sympy) rtld(GNU_HASH) cnkalman-debuginfo (rpmlib, GLIBC filtered): cnkalman-debugsource (rpmlib, GLIBC filtered): Provides -------- cnkalman: cnkalman cnkalman(x86-64) libcnkalman.so.0()(64bit) cnkalman-devel: cnkalman-devel cnkalman-devel(x86-64) pkgconfig(cnkalman) python3-cnkalman: python-cnkalman python3-cnkalman python3-cnkalman(x86-64) python3.13-cnkalman python3.13dist(cnkalman) python3dist(cnkalman) cnkalman-debuginfo: cnkalman-debuginfo cnkalman-debuginfo(x86-64) debuginfo(build-id) libcnkalman.so.0-0.1^20230315gitf0c11f7-1.fc42.x86_64.debug()(64bit) cnkalman-debugsource: cnkalman-debugsource cnkalman-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n cnkalman-0.1^20230315gitf0c11f7-1.fc41.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic, C/C++ Disabled plugins: Perl, R, Ocaml, PHP, fonts, Java, Haskell, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. I think this is fine: /usr/lib64/python3.13/site-packages/filter.cpython-313-x86_64-linux-gnu.so [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Publish our patch upstream and link to it. [!]: License file installed when any subpackage combination is installed. [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cnkalman Adding this BR fixes both issues. [!]: Package is not known to require an ExcludeArch tag. [!]: Package should compile and build into binary rpms on all supported architectures. Package fails to build on 32bit. https://koji.fedoraproject.org/koji/taskinfo?taskID=127741108 [!]: Package complies to the Packaging Guidelines [!]: Package meets the Packaging Guidelines::Python Why can't we use the files automation? If we can't, be more explicit: %files -n python3-%{name} %{python3_sitearch}/%{name}/ %{python3_sitearch}/%{name}/filter.cpython-313-x86_64-linux-gnu.so Also, update the main %files for the DSO to be: %{_libdir}/lib%{name}.so.0{,.*} [!]: %check is present and all tests pass. Add %check but disable by default. cnkalman.x86_64: E: undefined-non-weak-symbol /usr/lib64/libcnkalman.so.0 cnSetZero (/usr/lib64/libcnkalman.so.0) I'm not sure what to do here. This seems like an upsteam bug and I know is also impacting testing.
(In reply to Jonathan Steffan from comment #13) > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > > Publish our patch upstream and link to it. Will do as soon as I get it working. > [!]: License file installed when any subpackage combination is installed. > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > python3-cnkalman > > Adding this BR fixes both issues. Which BR?... > [!]: Package is not known to require an ExcludeArch tag. > [!]: Package should compile and build into binary rpms on all supported > architectures. > > Package fails to build on 32bit. > https://koji.fedoraproject.org/koji/taskinfo?taskID=127741108 Yes, this was already fixed here: https://bugzilla.redhat.com/show_bug.cgi?id=2334700#c5 > [!]: Package complies to the Packaging Guidelines > [!]: Package meets the Packaging Guidelines::Python > > Why can't we use the files automation? If we can't, be more explicit: This was already fixed here: https://bugzilla.redhat.com/show_bug.cgi?id=2334700#c5 There are 15 lines of comments about it, have you checked the SPEC file? > %files -n python3-%{name} > %{python3_sitearch}/%{name}/ > %{python3_sitearch}/%{name}/filter.cpython-313-x86_64-linux-gnu.so > > Also, update the main %files for the DSO to be: > > %{_libdir}/lib%{name}.so.0{,.*} Fixed. > [!]: %check is present and all tests pass. > > Add %check but disable by default. > > cnkalman.x86_64: E: undefined-non-weak-symbol /usr/lib64/libcnkalman.so.0 > cnSetZero (/usr/lib64/libcnkalman.so.0) > > I'm not sure what to do here. This seems like an upsteam bug and I know is > also impacting testing. This needs to be fixed, it also throws the same errors as in the test binary in libsurvive. I'm on it.
(In reply to Simone Caronni from comment #14) > > [!]: License file installed when any subpackage combination is installed. > > [!]: Fully versioned dependency in subpackages if applicable. > > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > > python3-cnkalman > > > > Adding this BR fixes both issues. > > Which BR?... Add Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cnkalman
package is now included in the source of libsurvive and it's no longer a standalone project.