Bug 2341787 - qemu fails to build against libnfs 6
Summary: qemu fails to build against libnfs 6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: qemu
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fedora Virtualization Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2342514 2342831
Blocks: 2331668
TreeView+ depends on / blocked
 
Reported: 2025-01-23 17:25 UTC by Adam Williamson
Modified: 2025-03-15 00:26 UTC (History)
10 users (show)

Fixed In Version: qemu-9.2.0-23.fc43 qemu-9.2.0-20.fc42
Clone Of:
Environment:
Last Closed: 2025-02-24 13:11:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2025-01-23 17:25:47 UTC
Description of problem:
libnfs 6 introduces a significant API change - https://github.com/sahlberg/libnfs/commit/5e8f7ce273308eb77f94248f4501e574a703c1a5 - which breaks build of qemu's NFS support. For now libnfs is being held at version 5, but the maintainer would like to bump it to 6. We need to either fix qemu to build against the new API, or drop the NFS support from qemu.

See upstream discussions https://lists.nongnu.org/archive/html/qemu-block/2024-12/msg00151.html and https://lists.nongnu.org/archive/html/qemu-block/2025-01/msg00480.html .

Current upstream qemu attempts to disable the NFS support if it detects the newer libnfs API, but this doesn't "work" for us as our build explicitly enables it - https://src.fedoraproject.org/rpms/qemu/blob/rawhide/f/qemu.spec#_1861 . We'd have to set have_block_nfs to 0 to disable it in the package build.

Comment 1 Daniel Berrangé 2025-01-27 14:30:01 UTC
I've committed a patch to rawhide that should be compatible with libnfs6.  We'll need libnfs6 re-tagged into rawhide before I trigger a new QEMU build though.

Comment 2 Adam Williamson 2025-01-27 17:01:35 UTC
"There's a side tag available for the rebuilds: fedpkg build --target=f42-build-side-102002" - https://bugzilla.redhat.com/show_bug.cgi?id=2331668#c11 

can you build it on that side tag? Thanks.

Comment 3 Adam Williamson 2025-01-27 17:02:43 UTC
I don't see any patch, though? The last commit at https://src.fedoraproject.org/rpms/qemu/commits/rawhide as I write this was by me, four days ago.

Comment 4 Daniel Berrangé 2025-01-27 18:41:31 UTC
(In reply to Adam Williamson from comment #3)
> I don't see any patch, though? The last commit at
> https://src.fedoraproject.org/rpms/qemu/commits/rawhide as I write this was
> by me, four days ago.

My bad, forgot to push it.

(In reply to Adam Williamson from comment #2)
> "There's a side tag available for the rebuilds: fedpkg build
> --target=f42-build-side-102002" -
> https://bugzilla.redhat.com/show_bug.cgi?id=2331668#c11 

That doesn't seem to actually exist :-(

Comment 5 Adam Williamson 2025-01-27 21:54:36 UTC
current side tag: f42-build-side-104263

Comment 6 Daniel Berrangé 2025-01-28 10:17:49 UTC
We're now blocked from building QEMU because ncurses is broken since GCC 15

https://bugzilla.redhat.com/show_bug.cgi?id=2342514

Comment 7 Daniel Berrangé 2025-01-29 17:42:46 UTC
We're now blocked from buildnig QEMU because gcc broken int128 support on s390x

https://bugzilla.redhat.com/show_bug.cgi?id=2342831

Comment 8 Cole Robinson 2025-02-02 17:30:50 UTC
Fixed in qemu-9.2.0-17.fc42

Comment 9 Daniel Berrangé 2025-02-03 14:17:52 UTC
> Fixed in qemu-9.2.0-17.fc42

Nope, you built it into the main f42 target, not the side-tag, so it still used old libnfs5

Comment 10 Cole Robinson 2025-02-03 18:01:15 UTC
Sorry for screwing that up.

Looks like latest side tag build is still failing, gcc in it is missing the s390 fix.

Comment 11 Daniel Berrangé 2025-02-03 21:10:19 UTC
Ok, finally  built into the side tag as qemu-9.2.0-20.fc42.

So presumably we should be good to merge the side tag into rawhide if QEMU was the last blocker for libnfs6.

Comment 12 Fedora Update System 2025-02-19 20:27:23 UTC
FEDORA-2025-d3a96f5085 (gvfs-1.56.1-6.fc43, libnfs-6.0.2-2.fc43, and 3 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d3a96f5085

Comment 13 Fedora Update System 2025-02-19 20:30:21 UTC
FEDORA-2025-052559f83a (gvfs-1.56.1-6.fc42, libnfs-6.0.2-2.fc42, and 3 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-052559f83a

Comment 14 Fedora Update System 2025-02-21 02:57:50 UTC
FEDORA-2025-052559f83a has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-052559f83a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-052559f83a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Xavier Bachelot 2025-02-21 22:26:56 UTC
There's a failing CI test on F43 preventing the whole update to be pushed:
https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/dist-git-pipeline/job/master/486472/

Comment 16 Fedora Update System 2025-02-24 13:11:53 UTC
FEDORA-2025-d3a96f5085 (gvfs-1.56.1-6.fc43, libnfs-6.0.2-2.fc43, and 3 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2025-03-15 00:26:46 UTC
FEDORA-2025-052559f83a (gvfs-1.56.1-6.fc42, libnfs-6.0.2-2.fc42, and 3 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.