Bug 2341788 - gvfs 1.56.1 fails to build against libnfs 6
Summary: gvfs 1.56.1 fails to build against libnfs 6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gvfs
Version: rawhide
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: GNOME SIG Unassigned
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2331668
TreeView+ depends on / blocked
 
Reported: 2025-01-23 17:28 UTC by Adam Williamson
Modified: 2025-03-15 00:26 UTC (History)
3 users (show)

Fixed In Version: gvfs-1.56.1-6.fc43 gvfs-1.56.1-6.fc42
Clone Of:
Environment:
Last Closed: 2025-02-24 13:11:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gvfs merge_requests 257 0 None merged nfs: Support libnfs 6 2025-01-23 17:28:42 UTC

Description Adam Williamson 2025-01-23 17:28:22 UTC
libnfs 6 introduces a significant API change - https://github.com/sahlberg/libnfs/commit/5e8f7ce273308eb77f94248f4501e574a703c1a5 - which breaks build of gvfs's NFS support. For now libnfs is being held at version 5, but the maintainer would like to bump it to 6. We need to fix gvfs to build against the new API.

This has been done upstream - https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/257 - but that landed in 1.57.1 I think. 1.56.1 doesn't have it. I did do a backport for 1.56.1 in case we needed to fix this urgently (in the end, we untagged libnfs 6 instead) but now we have more time it's probably best just to update to 1.57.1.

Comment 1 Xavier Bachelot 2025-02-07 22:44:56 UTC
Hi,

Could either a patched gvfs 1.56.1 or an updated gvfs 1.57.1 be rebuild against libnfs 6 in f42-build-side-104263 ?

Regards,
Xavier

Comment 2 Ondrej Holy 2025-02-14 15:50:08 UTC
I have just started preparing gvfs update to 1.57.2. Sorry that it took so long, but I was out for most of the time. The updated version unfortunately requires msgraph 0.3.3 with bumped soname and there is a circular dependency over gnome-online-accounts that leads to mock failures. I will try to fix it somehow next week. Then I will prepare builds against libnfs 6. But we will need side tag for f43 also at this point. Xavier, can you please prepare it in the meantime?

Comment 3 Xavier Bachelot 2025-02-14 16:17:45 UTC
Sure, libnfs 6 will soon be there :
f43-build-side-105744

Comment 4 Ondrej Holy 2025-02-17 13:24:22 UTC
I have just kicked off the gvfs builds for both side tags. I decided it would be better to backport libnfs 6 support to 1.56.1 and update to 1.57.x once it's resolved so as not to complicate things even more now.

Comment 5 Fedora Update System 2025-02-19 20:27:27 UTC
FEDORA-2025-d3a96f5085 (gvfs-1.56.1-6.fc43, libnfs-6.0.2-2.fc43, and 3 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d3a96f5085

Comment 6 Fedora Update System 2025-02-19 20:30:25 UTC
FEDORA-2025-052559f83a (gvfs-1.56.1-6.fc42, libnfs-6.0.2-2.fc42, and 3 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-052559f83a

Comment 7 Fedora Update System 2025-02-21 02:57:53 UTC
FEDORA-2025-052559f83a has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-052559f83a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-052559f83a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2025-02-24 13:11:58 UTC
FEDORA-2025-d3a96f5085 (gvfs-1.56.1-6.fc43, libnfs-6.0.2-2.fc43, and 3 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2025-03-15 00:26:49 UTC
FEDORA-2025-052559f83a (gvfs-1.56.1-6.fc42, libnfs-6.0.2-2.fc42, and 3 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.