Spec URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS-0.05-1.fc41.src.rpm Description: libnfs allows you to access NFS shares in user-space. Thus you can read & write files via NFS even if you can’t (or just would rather not) mount(8) them locally. Fedora Account System Username: cmadams
Hi Chris, Some notes after a first look at this review. - _fixperms macro uses chmod so BR: coreutils is missing - in files section """ %dir %{perl_vendorarch}/auto/Net %{perl_vendorarch}/auto/Net/LibNFS* %dir %{perl_vendorarch}/Net %{perl_vendorarch}/Net/LibNFS* """ could be simplified to """ %{perl_vendorarch}/auto/Net/ %{perl_vendorarch}/Net/ """ - It's is usually preferred to reference the tarball by module rather than by author. Source0 could be changed to use https://www.cpan.org/modules/by-module/Net/Net-LibNFS-%{version}.tar.gz - Package fails to build for Rawhide and F42, but succeeds with F41 Likely induced by gcc 15 but possibly also libnfs update from libnfs 5 to libnfs 6 Regards, Xavier
The failure to build is actually an issue with newer perl, with a simple fix in an upstream github issue. Added the BR:coreutils (which... is still debatable since chmod is pulled in by RPM itself). I left the %files alone; if a later version installed unexpected files outside, they'd be caught this way (similar to not just doing %{_bindir}/*). Spec URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-Net-LibNFS/perl-Net-LibNFS-0.05-2.fc41.src.rpm
Still failing to build in mock against Rawhide, Here's a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=135388300 libnfs needs at least an upstream patch applied, I will take care of that. https://github.com/sahlberg/libnfs/commit/2cdfedaba379cbb512d3c203a1b9eae795f4fb23 But there's more to fix in Net::LibNFS
libnfs in Rawhide is fixed and F42 update has been submitted: https://bodhi.fedoraproject.org/updates/FEDORA-2025-8ca9cb3ee3
Thanks, I'll look more. I built it locally in mock fedora-rawhide to see a local log, then found the perl fix, then forgot to specify rawhide when I built again. Sigh...
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9819836 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2346429-perl-net-libnfs/fedora-rawhide-x86_64/09819836-perl-Net-LibNFS/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The upstream devs are not interested in continuing the module. I'm really rusty at perl XS, but I'm going to take a look when I get some time; if I don't feel confident in maintaining it, I'll close this review.