Bug 2351032 - Review Request: python-tatsu - Python parser generator from grammars in a variation of EBNF
Summary: Review Request: python-tatsu - Python parser generator from grammars in a var...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://tatsu.readthedocs.io
Whiteboard:
Depends On:
Blocks: 2351033
TreeView+ depends on / blocked
 
Reported: 2025-03-10 05:13 UTC by Davide Cavalca
Modified: 2025-05-19 16:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2025-03-10 05:13:19 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-tatsu/python-tatsu.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-tatsu/python-tatsu-5.13.1-1.fc43.src.rpm

Description:
TatSu is a tool that takes grammars in a variation of EBNF as input, and
outputs memoizing (Packrat) PEG parsers in Python.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-03-10 05:13:21 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=130072086

Comment 2 Fedora Review Service 2025-03-10 15:29:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8746843
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351032-python-tatsu/fedora-rawhide-x86_64/08746843-python-tatsu/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2025-05-19 16:13:17 UTC
This fails to build with:

+ /usr/bin/python3 -m tox --current-env --assert-config -q --recreate -e py313
tatsu/bootstrap.py:12:1: RUF100 [*] Unused `noqa` directive (unused: `C405`)
   |
10 | #  the file is generated.
11 |
12 | # ruff: noqa: C405, COM812, I001, F401, PLR1702, PLC2801, SIM117
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF100
13 |
14 | import sys
   |
   = help: Remove unused `noqa` directive
tatsu/tool.py:5:1: RUF100 [*] Unused `noqa` directive (unused: `PLR0912`)
  |
3 | the described language.
4 | """
5 | # ruff: noqa: PLR0912
  | ^^^^^^^^^^^^^^^^^^^^^ RUF100
6 | from __future__ import annotations
  |
  = help: Remove unused `noqa` directive
test/grammar/semantics_test.py:1:1: RUF100 [*] Unused `noqa` directive (non-enabled: `S102`)
  |
1 | # ruff: noqa: S102
  | ^^^^^^^^^^^^^^^^^^ RUF100
2 | import unittest
  |
  = help: Remove unused `noqa` directive
test/parser_equivalence_test.py:1:1: RUF100 [*] Unused `noqa` directive (non-enabled: `S102`)
  |
1 | # ruff: noqa: S102
  | ^^^^^^^^^^^^^^^^^^ RUF100
2 | import types
  |
  = help: Remove unused `noqa` directive
Found 4 errors.
[*] 4 fixable with the `--fix` option.
py313: exit 1 (0.04 seconds) /builddir/build/BUILD/python-tatsu-5.13.1-build/TatSu-5.13.1> ruff check --preview tatsu test examples pid=817

You should patch out the ruff and mypy invocations from tox.ini as prescribed by https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters, or (easier) bypass tox, drop -t from %pyproject_requires, add a manual BuildRequires on pytest and just run the test suite with %pytest.


Note You need to log in before you can comment on or make changes to this bug.