Spec URL: https://dcavalca.fedorapeople.org/review/python-beanprice/python-beanprice.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beanprice/python-beanprice-2.0.0-1.fc43.src.rpm Description: This package provides a script to fetch market data prices from various sources on the Internet and render them for plain text accounting price syntax (and Beancount). Fedora Account System Username: dcavalca
Copr build: https://copr.fedorainfracloud.org/coprs/build/8746863 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351113-python-beanprice/fedora-rawhide-x86_64/08746863-python-beanprice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The package is APPROVED as-is, although I hope you will take a little time to read through the "Notes" below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Notes ===== I submitted a PR to fix installing "experiments" in site-packages in future releases, https://github.com/beancount/beanprice/pull/109. Manually removing it in %install is fine for now. ---- I think that sources/coincap_test.py has an implicit assumption that the system timezone is UTC. Instead of # Remove broken test rm beanprice/sources/coincap_test.py you can just use # coincap_test expects the system timezone to be UTC TZ=UTC %pytest -v and the tests in coincap_test.py pass. ---- A man page is always desired, but not required, for a command-line tool. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages In this case, help2man does not produce an acceptable result. ---- Regarding the following rpmlint messages, python3-beanprice.noarch: E: incorrect-fsf-address /usr/lib/python3.13/site-packages/beanprice-2.0.0.dist-info/METADATA python3-beanprice.noarch: E: incorrect-fsf-address /usr/lib/python3.13/site-packages/beanprice-2.0.0.dist-info/licenses/COPYING I opened https://github.com/beancount/beanprice/pull/110 to update the license text upstream. This should *not* be patched downstream, at least not until/unless upstream merges the PR, but the updated text will hopefully appear in the next upsream release. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2", "Unknown or generated". 40 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2351113-python-beanprice/licensecheck.txt SPDX GPL-2.0-only is consistent with license="GNU GPLv2 only" in setup.py, and with the following note at the bottom of COPYING: Note: This is a GNU GPL "v2 only" license. This is not a GNU GPL "v2 or any later version" license. ---Martin Blais [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 Diagnostic is spurious; python3-libs owns these. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5470 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in beanprice , python3-beanprice [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=132970709 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: beanprice-2.0.0-1.fc43.noarch.rpm python3-beanprice-2.0.0-1.fc43.noarch.rpm python-beanprice-2.0.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0lkd58gn')] checks: 32, packages: 3 beanprice.noarch: W: no-manual-page-for-binary bean-price python3-beanprice.noarch: W: no-documentation python3-beanprice.noarch: E: incorrect-fsf-address /usr/lib/python3.13/site-packages/beanprice-2.0.0.dist-info/METADATA python3-beanprice.noarch: E: incorrect-fsf-address /usr/lib/python3.13/site-packages/beanprice-2.0.0.dist-info/licenses/COPYING 3 packages and 0 specfiles checked; 2 errors, 2 warnings, 11 filtered, 2 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 beanprice.noarch: W: no-manual-page-for-binary bean-price python3-beanprice.noarch: W: no-documentation python3-beanprice.noarch: E: incorrect-fsf-address /usr/lib/python3.13/site-packages/beanprice-2.0.0.dist-info/METADATA python3-beanprice.noarch: E: incorrect-fsf-address /usr/lib/python3.13/site-packages/beanprice-2.0.0.dist-info/licenses/COPYING 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 7 filtered, 2 badness; has taken 0.2 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/b/beanprice/beanprice-2.0.0.tar.gz : CHECKSUM(SHA256) this package : 0908ae2af79a6549e7be1708745c09a101bbb6681fd41f492294e1d9dc77dfb6 CHECKSUM(SHA256) upstream package : 0908ae2af79a6549e7be1708745c09a101bbb6681fd41f492294e1d9dc77dfb6 Requires -------- beanprice (rpmlib, GLIBC filtered): /usr/bin/python3 python3-beanprice python3-beanprice (rpmlib, GLIBC filtered): python(abi) python3.13dist(beancount) python3.13dist(python-dateutil) python3.13dist(requests) Provides -------- beanprice: beanprice python3-beanprice: python-beanprice python3-beanprice python3.13-beanprice python3.13dist(beanprice) python3dist(beanprice) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2351113 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Ocaml, SugarActivity, Haskell, PHP, Perl, Java, R, C/C++, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-beanprice
FEDORA-2025-0607b25b8f (python-beanprice-2.0.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-0607b25b8f
FEDORA-2025-0607b25b8f (python-beanprice-2.0.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-93ca5d76c6 (python-beanprice-2.0.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-93ca5d76c6
FEDORA-2025-e0a21bbbe2 (python-beanprice-2.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e0a21bbbe2
FEDORA-2025-e0a21bbbe2 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e0a21bbbe2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e0a21bbbe2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-93ca5d76c6 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-93ca5d76c6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-93ca5d76c6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-93ca5d76c6 (python-beanprice-2.0.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-e0a21bbbe2 (python-beanprice-2.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.