Spec URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount-2.3.6-1.fc40.src.rpm Description: Beancount is double-entry bookkeeping computer language that lets you define financial transaction records in a text file, read them in memory, generate a variety of reports from them, and provides a web interface. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109524070
Copr build: https://copr.fedorainfracloud.org/coprs/build/6693240 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251448-python-beancount/fedora-rawhide-x86_64/06693240-python-beancount/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There's something fishy with the dependencies here -- this package installs fine in mock, but on a live system I get Problem: problem with installed package python3-file-magic-5.44-5.fc39.noarch - package python3-file-magic-5.44-5.fc39.noarch from @System conflicts with python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - installed package python3-file-magic-5.44-5.fc39.noarch obsoletes python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - package python3-file-magic-5.44-5.fc39.noarch from fedora conflicts with python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - package python3-file-magic-5.44-5.fc39.noarch from fedora obsoletes python3-magic < 5.44-5.fc39 provided by python3-magic-0.4.27-5.fc39.noarch from fedora - package beancount-2.3.6-1.fc39.x86_64 from @commandline requires python3.12dist(python-magic) >= 0.4.12, but none of the providers can be installed - conflicting requests I assume this is because python3-file-magic is obsoleting python3-magic but doesn't actually provide python3.12dist(python-magic).
Spec URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount-2.3.6-1.fc40.src.rpm Changelog: - replace python-magic with python-file-magic to avoid install conflict
Created attachment 2001539 [details] The .spec file difference from Copr build 6693240 to 6695807
Copr build: https://copr.fedorainfracloud.org/coprs/build/6695807 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251448-python-beancount/fedora-rawhide-x86_64/06695807-python-beancount/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I also created a spec file without knowing that this bug existed. https://copr.fedorainfracloud.org/coprs/kanru/beancount/ Overall your package looks great. Just two small questions related to naming. > %global srcname beancount > %global forgeurl https://github.com/beancount/beancount > > Name: python-%{srcname} Would it make sense to name the srpm `beancount` instead? Python packaging guideline https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming > Packages that primarily provide applications, services or any kind of executables > SHOULD be named according to the general Fedora naming guidelines (e.g. ansible). Since upstream already release the package as `beancount` I feel this should be preferred. This also make the auto-generated debugsource and debuginfo package named correctly.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
Will get this updated
Spec URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount-3.1.0-1.fc43.src.rpm Changelog: - update to 3.1.0 - gate tests and test deps behind a bcond - split binaries and docs into their own package for ease of installation
The new files are not available at the above url.
Should be fixed now
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-beancount : /usr/lib64/python3.13/site- packages/beancount/parser/decimal.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount : /usr/lib64/python3.13/site- packages/beancount/parser/parser.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1700642 bytes in 36 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2". 225 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/beancount/2251448-python-beancount/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13, /usr/lib64/python3.13/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in beancount , python3-beancount [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1751040 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: beancount-3.1.0-1.fc43.x86_64.rpm python3-beancount-3.1.0-1.fc43.x86_64.rpm python-beancount-3.1.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpv_ycci3x')] checks: 32, packages: 3 beancount.x86_64: E: zero-length /usr/share/doc/beancount/examples/ingest/office/importers/acme/acmebank1.pdf.extract beancount.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/beancount/examples/tutorial/holdings-csv.output beancount.x86_64: W: package-with-huge-docs 99% beancount.x86_64: W: no-manual-page-for-binary bean-check beancount.x86_64: W: no-manual-page-for-binary bean-doctor beancount.x86_64: W: no-manual-page-for-binary bean-example beancount.x86_64: W: no-manual-page-for-binary bean-format beancount.x86_64: W: no-manual-page-for-binary treeify python3-beancount.x86_64: W: no-documentation beancount.x86_64: E: no-binary beancount.x86_64: E: env-script-interpreter /usr/share/doc/beancount/examples/simple/starter.beancount /usr/bin/env bean-web python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h 3 packages and 0 specfiles checked; 3 errors, 14 warnings, 11 filtered, 3 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 beancount.x86_64: E: zero-length /usr/share/doc/beancount/examples/ingest/office/importers/acme/acmebank1.pdf.extract beancount.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/beancount/examples/tutorial/holdings-csv.output beancount.x86_64: W: package-with-huge-docs 99% beancount.x86_64: W: no-manual-page-for-binary bean-check beancount.x86_64: W: no-manual-page-for-binary bean-doctor beancount.x86_64: W: no-manual-page-for-binary bean-example beancount.x86_64: W: no-manual-page-for-binary bean-format beancount.x86_64: W: no-manual-page-for-binary treeify python3-beancount.x86_64: W: no-documentation beancount.x86_64: E: no-binary beancount.x86_64: E: env-script-interpreter /usr/share/doc/beancount/examples/simple/starter.beancount /usr/bin/env bean-web python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h 2 packages and 0 specfiles checked; 3 errors, 14 warnings, 7 filtered, 3 badness; has taken 0.5 s Unversioned so-files -------------------- python3-beancount: /usr/lib64/python3.13/site-packages/beancount/parser/_parser.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/b/beancount/beancount-3.1.0.tar.gz : CHECKSUM(SHA256) this package : 1e70aba21fae648bc069452999d62c94c91edd7567f41697395c951be791ee0b CHECKSUM(SHA256) upstream package : 1e70aba21fae648bc069452999d62c94c91edd7567f41697395c951be791ee0b Requires -------- beancount (rpmlib, GLIBC filtered): /usr/bin/python3 python3-beancount python3-beancount (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) python(abi) python3.13dist(click) python3.13dist(python-dateutil) python3.13dist(regex) rtld(GNU_HASH) Provides -------- beancount: beancount beancount(x86-64) python3-beancount: python-beancount python3-beancount python3-beancount(x86-64) python3.13-beancount python3.13dist(beancount) python3dist(beancount) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251448 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Python Disabled plugins: R, fonts, Java, SugarActivity, Ocaml, Perl, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please mark the COPYING file as the license b) Please make a doc subpackage
Spec URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-beancount/python-beancount-3.1.0-1.fc43.src.rpm Changelog: - add license file - split examples into doc subpackage
Created attachment 2079681 [details] The .spec file difference from Copr build 6695807 to 8750444
Copr build: https://copr.fedorainfracloud.org/coprs/build/8750444 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251448-python-beancount/fedora-rawhide-x86_64/08750444-python-beancount/fedora-review/review.txt Found issues: - python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/decimal.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/parser.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
@benson_muite could you please do another pass on this? Thanks!
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-beancount : /usr/lib64/python3.13/site- packages/beancount/parser/decimal.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount : /usr/lib64/python3.13/site- packages/beancount/parser/parser.h python3-beancount : /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2". 225 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/beancount/2251448-python- beancount/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.13, /usr/lib64/python3.13/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4438 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in beancount , python3-beancount [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: beancount-3.1.0-1.fc43.x86_64.rpm beancount-doc-3.1.0-1.fc43.noarch.rpm python3-beancount-3.1.0-1.fc43.x86_64.rpm python-beancount-3.1.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpust5_six')] checks: 32, packages: 4 beancount-doc.noarch: E: zero-length /usr/share/doc/beancount-doc/examples/ingest/office/importers/acme/acmebank1.pdf.extract beancount-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/beancount-doc/examples/tutorial/holdings-csv.output beancount.x86_64: W: no-manual-page-for-binary bean-check beancount.x86_64: W: no-manual-page-for-binary bean-doctor beancount.x86_64: W: no-manual-page-for-binary bean-example beancount.x86_64: W: no-manual-page-for-binary bean-format beancount.x86_64: W: no-manual-page-for-binary treeify python3-beancount.x86_64: W: no-documentation beancount.x86_64: E: no-binary beancount-doc.noarch: E: env-script-interpreter /usr/share/doc/beancount-doc/examples/simple/starter.beancount /usr/bin/env bean-web python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h 4 packages and 0 specfiles checked; 3 errors, 13 warnings, 16 filtered, 3 badness; has taken 1.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 beancount-doc.noarch: E: zero-length /usr/share/doc/beancount-doc/examples/ingest/office/importers/acme/acmebank1.pdf.extract beancount-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/beancount-doc/examples/tutorial/holdings-csv.output beancount.x86_64: W: no-manual-page-for-binary bean-check beancount.x86_64: W: no-manual-page-for-binary bean-doctor beancount.x86_64: W: no-manual-page-for-binary bean-example beancount.x86_64: W: no-manual-page-for-binary bean-format beancount.x86_64: W: no-manual-page-for-binary treeify python3-beancount.x86_64: W: no-documentation beancount.x86_64: E: no-binary python3-beancount.x86_64: E: incorrect-fsf-address /usr/share/licenses/python3-beancount/COPYING beancount-doc.noarch: E: incorrect-fsf-address /usr/share/licenses/beancount-doc/COPYING beancount-doc.noarch: E: env-script-interpreter /usr/share/doc/beancount-doc/examples/simple/starter.beancount /usr/bin/env bean-web python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/decimal.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/macros.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.c python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/parser.h python3-beancount.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.13/site-packages/beancount/parser/tokens.h 3 packages and 0 specfiles checked; 5 errors, 13 warnings, 12 filtered, 5 badness; has taken 0.6 s Unversioned so-files -------------------- python3-beancount: /usr/lib64/python3.13/site-packages/beancount/parser/_parser.cpython-313-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/b/beancount/beancount-3.1.0.tar.gz : CHECKSUM(SHA256) this package : 1e70aba21fae648bc069452999d62c94c91edd7567f41697395c951be791ee0b CHECKSUM(SHA256) upstream package : 1e70aba21fae648bc069452999d62c94c91edd7567f41697395c951be791ee0b Requires -------- beancount (rpmlib, GLIBC filtered): /usr/bin/python3 python3-beancount beancount-doc (rpmlib, GLIBC filtered): python3-beancount python3-beancount (rpmlib, GLIBC filtered): /usr/bin/python3 libc.so.6()(64bit) python(abi) python3.13dist(click) python3.13dist(python-dateutil) python3.13dist(regex) rtld(GNU_HASH) Provides -------- beancount: beancount beancount(x86-64) beancount-doc: beancount-doc python3-beancount: python-beancount python3-beancount python3-beancount(x86-64) python3.13-beancount python3.13dist(beancount) python3dist(beancount) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251448 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, C/C++, Shell-api Disabled plugins: Perl, SugarActivity, Ocaml, fonts, Java, PHP, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Koji build: b) Please raise an issue upstream to update the COPYING file to have the correct FSF address: https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt c) Please change end of line encoding for: /usr/share/doc/beancount-doc/examples/tutorial/holdings-csv.output d) beancount-doc.noarch: E: env-script-interpreter /usr/share/doc/beancount-doc/examples/simple/starter.beancount /usr/bin/env bean-web $ rpmlint -e env-script-interpreter env-script-interpreter: This script uses 'env' as an interpreter. For the rpm runtime dependency detection to work, the shebang #!/usr/bin/env <interpreter> needs to be patched into #!/usr/bin/<interpreter> otherwise the package dependency generator merely adds a dependency on /usr/bin/env rather than the actual interpreter /usr/bin/<interpreter>. Alternatively, if the file should not be executed, then ensure that it is not marked as executable or don't install it in a path that is reserved for executables. e) Please fix above before import, or explain why not needed. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-beancount
FEDORA-2025-3a353195be (python-beancount-3.1.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3a353195be
FEDORA-2025-3a353195be (python-beancount-3.1.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-a5a0d105a0 (python-beancount-3.1.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a5a0d105a0
FEDORA-2025-a3ec9aa6e8 (python-beancount-3.1.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a3ec9aa6e8
FEDORA-2025-ee7a43c87b (python-beancount-3.1.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ee7a43c87b
FEDORA-2025-ee7a43c87b has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ee7a43c87b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ee7a43c87b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-a5a0d105a0 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a5a0d105a0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a5a0d105a0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-a3ec9aa6e8 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a3ec9aa6e8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a3ec9aa6e8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-a3ec9aa6e8 (python-beancount-3.1.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-ee7a43c87b (python-beancount-3.1.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-a5a0d105a0 (python-beancount-3.1.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.