Bug 2352745 - Review Request: rust-libbz2-rs-sys - Drop-in compatible rust bzip2 implementation
Summary: Review Request: rust-libbz2-rs-sys - Drop-in compatible rust bzip2 implementa...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cristian Le
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/libbz2-rs-sys
Whiteboard:
Depends On:
Blocks: 2331688
TreeView+ depends on / blocked
 
Reported: 2025-03-16 00:20 UTC by Fabio Valentini
Modified: 2025-03-21 21:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-21 21:33:02 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2025-03-16 00:20:22 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-libbz2-rs-sys.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-libbz2-rs-sys-0.1.3-1.fc41.src.rpm

Description:
A drop-in compatible rust bzip2 implementation.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2025-03-16 00:20:25 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=130319560

Comment 2 Fedora Review Service 2025-03-16 00:27:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8771001
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352745-rust-libbz2-rs-sys/fedora-rawhide-x86_64/08771001-rust-libbz2-rs-sys/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Cristian Le 2025-03-17 09:12:41 UTC
LGTM. A bit confused at first with the naming, thought it made public the C or CMake interface, but it's just written-in-rust.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2025-03-21 09:44:18 UTC
Thank you for the review!

> LGTM. A bit confused at first with the naming, thought it made public the C or CMake interface, but it's just written-in-rust.

Yes, it doesn't really follow the conventions for crate naming. :)

Comment 5 Fedora Admin user for bugzilla script actions 2025-03-21 09:45:12 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libbz2-rs-sys

Comment 6 Fedora Update System 2025-03-21 21:27:31 UTC
FEDORA-2025-bcafc8adca (rust-apple-xar-0.18.0-3.fc43, rust-async-compression-0.4.19-1.fc43, and 8 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-bcafc8adca

Comment 7 Fedora Update System 2025-03-21 21:33:02 UTC
FEDORA-2025-bcafc8adca (rust-apple-xar-0.18.0-3.fc43, rust-async-compression-0.4.19-1.fc43, and 8 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.