Spec URL: https://music.fedorapeople.org/python-snakemake-interface-logger-plugins.spec SRPM URL: https://music.fedorapeople.org/python-snakemake-interface-logger-plugins-1.2.3-1.fc41.src.rpm Description: This package provides a stable interface for interactions between Snakemake and its logger plugins. Fedora Account System Username: music This is a new dependency for Snakemake 9.0. It will be a neuro-sig package.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8802844 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354169-python-snakemake-interface-logger-plugins/fedora-rawhide-x86_64/08802844-python-snakemake-interface-logger-plugins/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Notes ===== 1. In the spec file you mention: > # See: [tool.poetry.dev-dependencies] in pyproject.toml However, there is no such table in pyproject.toml. There is [tool.pixi.feature.dev.dependencies], though, and the test requirements are correct. 2. The project uses hatchling, which supports PEP 639. Thus you can make use of `%pyproject_save_files -l` and drop LICENSE from %files. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5341 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-snakemake-interface-logger-plugins-1.2.3-1.fc43.noarch.rpm python-snakemake-interface-logger-plugins-1.2.3-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpizebi9_l')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/snakemake/snakemake-interface-logger-plugins/archive/v1.2.3/snakemake-interface-logger-plugins-1.2.3.tar.gz : CHECKSUM(SHA256) this package : b2cf926f06bc73f97a82cf7713f4f607f8735f128be3465ad1badfa8b9a04bb4 CHECKSUM(SHA256) upstream package : b2cf926f06bc73f97a82cf7713f4f607f8735f128be3465ad1badfa8b9a04bb4 Requires -------- python3-snakemake-interface-logger-plugins (rpmlib, GLIBC filtered): python(abi) python3.13dist(snakemake-interface-common) Provides -------- python3-snakemake-interface-logger-plugins: python-snakemake-interface-logger-plugins python3-snakemake-interface-logger-plugins python3.13-snakemake-interface-logger-plugins python3.13dist(snakemake-interface-logger-plugins) python3dist(snakemake-interface-logger-plugins) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2354169 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: C/C++, Ocaml, R, fonts, Java, SugarActivity, Perl, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Sandro from comment #2) > Notes > ===== > > 1. In the spec file you mention: > > > # See: [tool.poetry.dev-dependencies] in pyproject.toml > > However, there is no such table in pyproject.toml. There is > [tool.pixi.feature.dev.dependencies], though, and the test requirements are > correct. > > 2. The project uses hatchling, which supports PEP 639. Thus you can make use > of `%pyproject_save_files -l` and drop LICENSE from %files. Both excellent points! Thanks. I wonder if any of the extant snakemake packages need to be updated similarly yet. I’ll have to check over them as I prepare the snakemake 9 updates. New Spec URL: https://music.fedorapeople.org/20250410/python-snakemake-interface-logger-plugins.spec New SRPM URL: https://music.fedorapeople.org/20250410/python-snakemake-interface-logger-plugins-1.2.3-1.fc41.src.rpm
Created attachment 2084260 [details] The .spec file difference from Copr build 8802844 to 8885992
Copr build: https://copr.fedorainfracloud.org/coprs/build/8885992 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354169-python-snakemake-interface-logger-plugins/fedora-rawhide-x86_64/08885992-python-snakemake-interface-logger-plugins/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package is APPROVED. Good luck with updating snakemake!
Thank you for the (careful) review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-snakemake-interface-logger-plugins
FEDORA-2025-677fe6dd98 (python-snakemake-interface-logger-plugins-1.2.3-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-677fe6dd98
FEDORA-2025-677fe6dd98 (python-snakemake-interface-logger-plugins-1.2.3-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.