Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-qapi-qmp/rust-qapi-qmp.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08848105/rust-qapi-qmp-0.15.0-1.src.rpm Description: QEMU Machine Protocol types Fedora Account System Username: elmarco
Copr build: https://copr.fedorainfracloud.org/coprs/build/8848109 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356837-rust-qapi-qmp/fedora-rawhide-x86_64/08848109-rust-qapi-qmp/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This package contains some JSON schema files that are GPL-2.0-or-later licensed: GNU General Public License v2.0 or later ---------------------------------------- rust-qapi-qmp-0.15.0-build/qapi-qmp-0.15.0/schema/qapi/audio.json rust-qapi-qmp-0.15.0-build/qapi-qmp-0.15.0/schema/qapi/introspect.json rust-qapi-qmp-0.15.0-build/qapi-qmp-0.15.0/schema/qapi/stats.json rust-qapi-qmp-0.15.0-build/qapi-qmp-0.15.0/schema/qapi/trace.json > # This work is licensed under the terms of the GNU GPL, version 2 or later. > # See the COPYING file in the top-level directory. The toplevel COPYING file is for the MIT license (not even included in published crates). The fact that this package contains files licensed GPL-2.0-or-later needs to be reflected in the license tag, and probably a copy of the GPLv2 should be included, too.
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-qapi-qmp/rust-qapi-qmp.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08874055/rust-qapi-qmp-0.15.0-1.src.rpm Description: QEMU Machine Protocol types Fedora Account System Username: elmarco
Created attachment 2083890 [details] The .spec file difference from Copr build 8848109 to 8874171
Copr build: https://copr.fedorainfracloud.org/coprs/build/8874171 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2356837-rust-qapi-qmp/fedora-rawhide-x86_64/08874171-rust-qapi-qmp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, the adapted upstream PR looks good to me. Where did you get the COPYING.GPLv2 file from? If it's the official text from GNU, can you use a URL for it so it's clear that it's the official one?
(In reply to Fabio Valentini from comment #6) > Thanks, the adapted upstream PR looks good to me. > > Where did you get the COPYING.GPLv2 file from? > If it's the official text from GNU, can you use a URL for it so it's clear > that it's the official one? I got it from QEMU source repo: https://gitlab.com/qemu-project/qemu/-/blob/master/COPYING
Ok, this looks equivalent to the canonical license text, so that should be fine for now. Hopefully this can be cleared up with the crate project's upstream soon. Note that the COPYING.GPLv2 file contains some weird non-printable characters between license text and appendix, not sure if that is intentional or not. I'll go ahead and approve this package because the formal requirements are met (as far as I can tell). But please drop the manually included "canonical" license files in favor of those from upstream as soon as that is possible. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged 🫤 license matches upstream specification and is acceptable for Fedora (added GPLv2 to License tag, due to JSON schemas included in the package) 🫤 license files are included with %license in %files (manually included from upstream and / or canonical license text) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qapi-qmp
FEDORA-2025-4ed593d810 (rust-qapi-qmp-0.15.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-4ed593d810
FEDORA-2025-4ed593d810 (rust-qapi-qmp-0.15.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.