Spec URL: https://lecris.fedorapeople.org/reviews/rust-protox/rust-protox.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-protox/rust-protox-0.7.2-1.fc43.src.rpm Description: A rust implementation of the protobuf compiler. Fedora Account System Username: lecris
Copr build: https://copr.fedorainfracloud.org/coprs/build/8888427 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358966-rust-protox/fedora-rawhide-x86_64/08888427-rust-protox/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-protox/rust-protox.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-protox/rust-protox-0.8.0-1.fc43.src.rpm Update to 0.8.0
Created attachment 2084438 [details] The .spec file difference from Copr build 8888427 to 8891289
Copr build: https://copr.fedorainfracloud.org/coprs/build/8891289 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358966-rust-protox/fedora-rawhide-x86_64/08891289-rust-protox/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-protox/rust-protox.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-protox/rust-protox-0.8.0-1.fc43.src.rpm Moved the patches to `rust2rpm -p`
Created attachment 2084768 [details] The .spec file difference from Copr build 8891289 to 8899926
Copr build: https://copr.fedorainfracloud.org/coprs/build/8899926 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358966-rust-protox/fedora-rawhide-x86_64/08899926-rust-protox/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Do you still need to package protox v0.8.0? It looks like your upstream PR to update the license tag was merged in time for 0.9.0, but then reverted it again? I'm a bit confused by the upstream history. It also looks like the test files were first included in published crates, but then moved from protobuf/ to tests/protobuf and excluded from published crates again? ...
> but then reverted it again? Yes, because they have debundled protobuf. > Do you still need to package protox v0.8.0? For now I would prefer to package this version since I have already tested these with atuin. I will try to update these asap, but I would like to get the atuin update in first. But yeah, we know what upstream has fixed now, so we don't need to worry about the hacky commands in %prep, I will remove them afterwards.
Thanks for confirming - package looks good to me then. Good to know that this will all be cleared up in 0.9.0 eventually :) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (where possible) 🫤 latest version of the crate is packaged (0.8.0 needed for now, update to 0.9.0 planned) ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review, Fabio
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-protox
FEDORA-2025-03c099d47a (rust-protox-0.8.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-03c099d47a
FEDORA-2025-03c099d47a (rust-protox-0.8.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-b429adf5e6 (rust-protox-0.8.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b429adf5e6
FEDORA-2025-428abd9872 (rust-protox-0.8.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-428abd9872
FEDORA-2025-b429adf5e6 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b429adf5e6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b429adf5e6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-428abd9872 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-428abd9872` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-428abd9872 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-428abd9872 (rust-protox-0.8.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-b429adf5e6 (rust-protox-0.8.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.