Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect-0.14.7-1.fc43.src.rpm Description: A protobuf library extending prost with reflection support and dynamic messages. Fedora Account System Username: lecris Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131384076
Copr build: https://copr.fedorainfracloud.org/coprs/build/8888705 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358970-rust-prost-reflect/fedora-rawhide-x86_64/08888705-rust-prost-reflect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect-0.15.0-1.fc43.src.rpm Update prost-reflect which eliminates most workarounds. Also disabled the unused features that I have not packaged the dependencies for. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131401674
Created attachment 2084426 [details] The .spec file difference from Copr build 8888705 to 8890008
Copr build: https://copr.fedorainfracloud.org/coprs/build/8890008 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358970-rust-prost-reflect/fedora-rawhide-x86_64/08890008-rust-prost-reflect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect-0.15.0-1.fc43.src.rpm Relaxed the logos constraint and updated the features hidden Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131404714
Created attachment 2084440 [details] The .spec file difference from Copr build 8890008 to 8891288
Copr build: https://copr.fedorainfracloud.org/coprs/build/8891288 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358970-rust-prost-reflect/fedora-rawhide-x86_64/08891288-rust-prost-reflect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect-0.15.1-1.fc43.src.rpm Move the patches to `rust2rpm -p` Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131518671
Created attachment 2084783 [details] The .spec file difference from Copr build 8891288 to 8899939
Copr build: https://copr.fedorainfracloud.org/coprs/build/8899939 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358970-rust-prost-reflect/fedora-rawhide-x86_64/08899939-rust-prost-reflect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Some issues in the package as-is: > # * - dynamic::type_sizes This test uses std::mem::size_of which is inconsistent > # on i686 This might be indicative of a real problem (or not), would be good to check with upstream. > LICENSE-APACHE > LICENSE-MIT These files don't contain actual license texts, but the literal strings "../LICENSE-APACHE" and "../LICENSE-MIT", respectively. Looks like the current version was published on a Windows system without working symbolic links (or the files are actually messed up in git too, I haven't checked). > # Broken test because tests.rs is not in crate > sed -i '/#\[cfg(test)\]/,/mod tests/d' src/descriptor/mod.rs This is unfortunate, but likely not avoidable. I usually recommend to upstream projects to at least include all the files to make tests *compile* (if not run). If tests at least *compile* you can "--skip" as appropriate. But if they don't even compile, it's a lot more annoying.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect-0.15.2-1.fc43.src.rpm Update to 0.15.2. They've fixed the license file and newline characters. They've also added the files necessary for testing. One file is a binary file used for testing only so I've removed it from the devel package to be safe. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131818565
Created attachment 2086204 [details] The .spec file difference from Copr build 8899939 to 8949183
Copr build: https://copr.fedorainfracloud.org/coprs/build/8949183 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358970-rust-prost-reflect/fedora-rawhide-x86_64/08949183-rust-prost-reflect/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Update to 0.15.2. They've fixed the license file and newline characters. Looks like it, yeah. That makes things easier :) > They've also added the files necessary for testing. :party: One file is a binary file used for testing only so I've removed it from the devel package to be safe. The "file_descriptor_set.bin" file looks harmless in a hexdump, it's just the compiled binary for doctest.proto. Both are only referenced by doctests, so you can exclude both from the built package. You might also want to exclude the doc/ and tests/ folders - they're unused too and contain a large amount of test-only files.
Oh, and I'm wondering why the subpackage for the "derive" feature is missing.
Spec URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-prost-reflect/rust-prost-reflect-0.15.2-1.fc43.src.rpm Removed more files. Re derive subpackage, it is intentionally removed because I did not package the dependencies and it doesn't seem to be needed for protox. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=132065840
Hm, this looks good, with one potential exception - I think the fact that the tests/main.rs file is now excluded but still referenced in the Cargo.toml file might break things when building this crate as a dependency of something else, but I'm not sure. You might need to change the %exclude from tests/ to tests/data and tests/snapshots then. But you can cross that bridge when you get to it. As for excluding the "derive" feature - fair enough, if you don't need it and it would involve packaging more dependencies, then this is a perfectly fine solution. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prost-reflect
Thank you for the review, Fabio
FEDORA-2025-f646a7828c (rust-prost-reflect-0.15.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f646a7828c
FEDORA-2025-f646a7828c (rust-prost-reflect-0.15.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-c9ce6e00f5 (rust-prost-reflect-0.15.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c9ce6e00f5
FEDORA-2025-9e28110097 (rust-prost-reflect-0.15.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e28110097
FEDORA-2025-bc57d873bf (rust-prost-reflect-0.15.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-bc57d873bf
FEDORA-2025-bc57d873bf has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-bc57d873bf` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-bc57d873bf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-c9ce6e00f5 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c9ce6e00f5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c9ce6e00f5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-9e28110097 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-9e28110097` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-9e28110097 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-c9ce6e00f5 (rust-prost-reflect-0.15.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-9e28110097 (rust-prost-reflect-0.15.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-bc57d873bf (rust-prost-reflect-0.15.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.