Spec URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny.spec SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny-0.001-2.fc43.src.rpm Description: Quite often you want or need your Perl module (CPAN or otherwise) to have access to a large amount of read-only data that is stored on the file-system at run-time. On a linux-like system, this would be in a place such as /usr/share, however Perl runs on a wide variety of different systems, and so the use of any one location is unreliable. This module provides a more portable way to have (read-only) data for your module. Fedora Account System Username: cra
perl-Crypt-Argon2-0.030 build now requires: perl-Dist-Build-0.020-1.fc43 which requires: perl-ExtUtils-Builder-0.017-1.fc43 perl-ExtUtils-Builder-Compiler-0.031-1.fc43 perl-File-ShareDir-Tiny-0.001-1.fc43
Copr build: https://copr.fedorainfracloud.org/coprs/build/8994406 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363929-perl-file-sharedir-tiny/fedora-rawhide-x86_64/08994406-perl-File-ShareDir-Tiny/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Swap you for a review of https://bugzilla.redhat.com/show_bug.cgi?id=2360688 ?
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Add build-require 'coreutils' it is needed for %{_fixperms} TODO: Please replace perl-blib by 'perl(blib)' TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-File-ShareDir-Tiny-0.001-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 2 perl(Exporter) >= 5.57 1 perl(File::Spec::Functions) 1 perl-libs 1 perl(strict) 1 perl(warnings) FIX: Remove duplicit definition of run-require perl(Exporter). Otherwise binary requires are Ok. $ rpm -qp --provides perl-File-ShareDir-Tiny-0.001-2.fc43.noarch.rpm | sort | uniq -c 1 perl(File::ShareDir::Tiny) = 0.001 1 perl-File-ShareDir-Tiny = 0.001-2.fc43 Binary provides are Ok. $ rpmlint ./perl-File-ShareDir-Tiny* ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 perl-File-ShareDir-Tiny.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user') 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 9 filtered, 1 badness; has taken 0.3 s Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT Approved
(In reply to Jitka Plesnikova from comment #4) > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > TODO: Please replace perl-blib by 'perl(blib)' > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. > TODO: Explicitly name packaged files in %{_mandir}/man* and > %{perl_vendorlib} directories The above items are all fixed: Spec URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny.spec SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny-0.001-3.fc43.src.rpm Thanks.
There seems to be some problem with the following file. SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny-0.001-3.fc43.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Corrected URLs: Spec URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny.spec SRPM URL: https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny-0.001-3.fc44.src.rpm (In reply to Fedora Review Service from comment #6) > There seems to be some problem with the following file. > SRPM URL: > https://cra.fedorapeople.org/perl-File-ShareDir-Tiny/perl-File-ShareDir-Tiny- > 0.001-3.fc43.src.rpm > Fetching it results in a 404 Not Found error. > Please make sure the URL is correct and publicly available.
Created attachment 2104196 [details] The .spec file difference from Copr build 8994406 to 9450914
Copr build: https://copr.fedorainfracloud.org/coprs/build/9450914 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363929-perl-file-sharedir-tiny/fedora-rawhide-x86_64/09450914-perl-File-ShareDir-Tiny/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Charles R. Anderson from comment #5) > (In reply to Jitka Plesnikova from comment #4) > > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > > TODO: Please replace perl-blib by 'perl(blib)' > > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > > NO_PACKLIST is provided since this version. > > TODO: Explicitly name packaged files in %{_mandir}/man* and > > %{perl_vendorlib} directories 10a11 + BuildRequires: coreutils 12c13 - BuildRequires: perl-blib --- + BuildRequires: perl(blib) 19c20 - BuildRequires: perl(ExtUtils::MakeMaker) --- + BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 29d29 - Requires: perl(Exporter) >= 5.57 62,63c62,65 - %{perl_vendorlib}/* - %{_mandir}/man3/* --- + %dir %{perl_vendorlib}/File + %dir %{perl_vendorlib}/File/ShareDir + %{perl_vendorlib}/File/ShareDir/Tiny.pm + %{_mandir}/man3/File::ShareDir::Tiny.3pm* Changes look good. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-File-ShareDir-Tiny
FEDORA-2025-f6a84afc2c (perl-File-ShareDir-Tiny-0.001-3.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f6a84afc2c
FEDORA-2025-904e1c360b (perl-File-ShareDir-Tiny-0.001-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-904e1c360b
FEDORA-2025-0c6eabaca6 (perl-File-ShareDir-Tiny-0.001-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-0c6eabaca6
FEDORA-2025-512353a61b (perl-File-ShareDir-Tiny-0.001-3.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-512353a61b
FEDORA-2025-f6a84afc2c has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f6a84afc2c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f6a84afc2c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-904e1c360b has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-904e1c360b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-904e1c360b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-0c6eabaca6 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-0c6eabaca6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-0c6eabaca6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-0c6eabaca6 (perl-File-ShareDir-Tiny-0.001-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-904e1c360b (perl-File-ShareDir-Tiny-0.001-3.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-f6a84afc2c (perl-File-ShareDir-Tiny-0.001-3.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.