Created attachment 2089875 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-tikv-jemalloc-sys.spec SRPM URL: https://music.fedorapeople.org/rust-tikv-jemallocator-0.6.0-1.fc42.src.rpm Description: Rust FFI bindings to jemalloc. Fedora Account System Username: music
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Oops! Spec URL: https://music.fedorapeople.org/rust-tikv-jemalloc-sys.spec SRPM URL: https://music.fedorapeople.org/rust-tikv-jemalloc-sys-0.6.0-1.fc42.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9041681 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366367-rust-tikv-jemalloc-sys/fedora-rawhide-x86_64/09041681-rust-tikv-jemalloc-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/tikv- jemalloc-sys-0.6.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "Apache License (v2.0) or MIT license". 11 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/2366367-rust-tikv-jemalloc- sys/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- tikv-jemalloc-sys-devel , rust-tikv-jemalloc-sys+default-devel , rust- tikv-jemalloc-sys+background_threads-devel , rust-tikv-jemalloc- sys+background_threads_runtime_support-devel , rust-tikv-jemalloc- sys+debug-devel , rust-tikv-jemalloc-sys+profiling-devel , rust-tikv- jemalloc-sys+stats-devel , rust-tikv-jemalloc- sys+unprefixed_malloc_on_supported_platforms-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: rust-tikv-jemalloc-sys-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+default-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+background_threads-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+background_threads_runtime_support-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+debug-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+profiling-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+stats-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemalloc-sys-0.6.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppbn5wxs4')] checks: 32, packages: 9 rust-tikv-jemalloc-sys+background_threads-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+background_threads_runtime_support-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+debug-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+default-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+profiling-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+stats-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel.noarch: W: no-documentation rust-tikv-jemalloc-sys+background_threads_runtime_support-devel.noarch: E: description-line-too-long use the "background_threads_runtime_support" feature of the "tikv-jemalloc-sys" crate. rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel.noarch: E: description-line-too-long use the "unprefixed_malloc_on_supported_platforms" feature of the "tikv-jemalloc-sys" crate. 9 packages and 0 specfiles checked; 2 errors, 7 warnings, 42 filtered, 2 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8 rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel.noarch: E: description-line-too-long use the "unprefixed_malloc_on_supported_platforms" feature of the "tikv-jemalloc-sys" crate. rust-tikv-jemalloc-sys+background_threads_runtime_support-devel.noarch: E: description-line-too-long use the "background_threads_runtime_support" feature of the "tikv-jemalloc-sys" crate. 8 packages and 0 specfiles checked; 2 errors, 0 warnings, 45 filtered, 2 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/tikv-jemalloc-sys/0.6.0+5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7/download#/tikv-jemalloc-sys-0.6.0+5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7.crate : CHECKSUM(SHA256) this package : cd3c60906412afa9c2b5b5a48ca6a5abe5736aec9eb48ad05037a677e52e4e2d CHECKSUM(SHA256) upstream package : cd3c60906412afa9c2b5b5a48ca6a5abe5736aec9eb48ad05037a677e52e4e2d Requires -------- rust-tikv-jemalloc-sys-devel (rpmlib, GLIBC filtered): (crate(cc/default) >= 1.0.13 with crate(cc/default) < 2.0.0~) (crate(libc) >= 0.2.8 with crate(libc) < 0.3.0~) cargo pkgconfig(jemalloc) rust rust-tikv-jemalloc-sys+default-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) crate(tikv-jemalloc-sys/background_threads_runtime_support) crate(tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms) rust-tikv-jemalloc-sys+background_threads-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) crate(tikv-jemalloc-sys/background_threads_runtime_support) rust-tikv-jemalloc-sys+background_threads_runtime_support-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) rust-tikv-jemalloc-sys+debug-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) rust-tikv-jemalloc-sys+profiling-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) rust-tikv-jemalloc-sys+stats-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemalloc-sys) Provides -------- rust-tikv-jemalloc-sys-devel: crate(tikv-jemalloc-sys) rust-tikv-jemalloc-sys-devel rust-tikv-jemalloc-sys+default-devel: crate(tikv-jemalloc-sys/default) rust-tikv-jemalloc-sys+default-devel rust-tikv-jemalloc-sys+background_threads-devel: crate(tikv-jemalloc-sys/background_threads) rust-tikv-jemalloc-sys+background_threads-devel rust-tikv-jemalloc-sys+background_threads_runtime_support-devel: crate(tikv-jemalloc-sys/background_threads_runtime_support) rust-tikv-jemalloc-sys+background_threads_runtime_support-devel rust-tikv-jemalloc-sys+debug-devel: crate(tikv-jemalloc-sys/debug) rust-tikv-jemalloc-sys+debug-devel rust-tikv-jemalloc-sys+profiling-devel: crate(tikv-jemalloc-sys/profiling) rust-tikv-jemalloc-sys+profiling-devel rust-tikv-jemalloc-sys+stats-devel: crate(tikv-jemalloc-sys/stats) rust-tikv-jemalloc-sys+stats-devel rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel: crate(tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms) rust-tikv-jemalloc-sys+unprefixed_malloc_on_supported_platforms-devel Diff spec file in url and in SRPM --------------------------------- --- /home/pemensik/fedora/rawhide/2366367-rust-tikv-jemalloc-sys/srpm/rust-tikv-jemalloc-sys.spec 2025-05-21 19:19:00.659153497 +0200 +++ /home/pemensik/fedora/rawhide/2366367-rust-tikv-jemalloc-sys/srpm-unpacked/rust-tikv-jemalloc-sys.spec 2025-05-14 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 1 @@ -171,3 +181,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed May 14 2025 John Doe <packager> - 0.6.0-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2366367 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: SugarActivity, Haskell, Python, fonts, R, Perl, PHP, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Haven't found any problematic part blocking review passing. Just wondering, whether it should be at least tried to ask upstream to support system-wide jemalloc linked dynamically somehow.
(In reply to Petr Menšík from comment #6) > Haven't found any problematic part blocking review passing. Just wondering, > whether it should be at least tried to ask upstream to support system-wide > jemalloc linked dynamically somehow. They do provide a mechanism to do that, by setting the environment variable JEMALLOC_OVERRIDE to the path to a static or shared library. However, this isn’t quite suitable for our needs, because (1) we would have to make sure every package that directly or indirectly depended on this one defined that environment variable, which is impractical and error-prone, and (2) we don’t want the RPM-packaged version of this to include or support building with a bundled jemalloc *at all*. We therefore are stuck with a downstream patch to make sure the system jemalloc is used *unconditionally*. Pretty much every Rust -sys package in Fedora carries a similar patch in one form or another.
Anything further you need from me? Thanks!
Oh, I see you actually approved this! Thank you for the review, then.
https://release-monitoring.org/project/378155/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tikv-jemalloc-sys
FEDORA-2025-ec5c551ff7 (rust-tikv-jemalloc-sys-0.6.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ec5c551ff7
FEDORA-2025-09176442ed (rust-tikv-jemalloc-sys-0.6.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-09176442ed
FEDORA-2025-ec5c551ff7 (rust-tikv-jemalloc-sys-0.6.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-60e4f1e018 (rust-tikv-jemalloc-sys-0.6.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-60e4f1e018
FEDORA-EPEL-2025-24eb524d32 (rust-tikv-jemalloc-sys-0.6.0-1.el10_1) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-24eb524d32
FEDORA-EPEL-2025-24eb524d32 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-24eb524d32 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-09176442ed has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-09176442ed \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-09176442ed See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-60e4f1e018 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-60e4f1e018 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-60e4f1e018 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-24eb524d32 (rust-tikv-jemalloc-sys-0.6.0-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-60e4f1e018 (rust-tikv-jemalloc-sys-0.6.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-09176442ed (rust-tikv-jemalloc-sys-0.6.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.