Created attachment 2089876 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-tikv-jemallocator.spec SRPM URL: https://music.fedorapeople.org/rust-tikv-jemallocator-0.6.0-1.fc42.src.rpm Description: A Rust allocator backed by jemalloc. Fedora Account System Username: music COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/tikv-jemallocator/build/9041362/
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
To prove this out end-to-end, I tested this locally with https://src.fedoraproject.org/rpms/uv/pull-request/56, and a corresponding COPR build is running as https://copr.fedorainfracloud.org/coprs/music/tikv-jemallocator/build/9041592/.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9228088 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2366368-rust-tikv-jemallocator/fedora-rawhide-x86_64/09228088-rust-tikv-jemallocator/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I decided to take this review, regardless of the proposed swap; Thanks for all the Rust reviews you've done for the AI/ML SIG. :)
Along with the review items, I emphasized checking the following items: ----------------------------------------------------------------------- - Package was built with rust2rpm, so the specfile complies with the relevant guidelines. (I checked by regenerating it locally and diffing, and checking the manual items: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_rust2rpm ) - Any warnings below (or during lint) are known to occur with rust2rpm, and are acceptable. - Package correctly regenerates the SRPM and builds in mock. - License is present, acceptable, and SPDX expression is correct. - Package contains content acceptable for Fedora. - Package preserves timestamps from crate. - Package does not include extraneous files. Package is APPROVED. Status is ACCEPT. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "Apache License (v2.0) or MIT license". 11 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/rust-tikv-jemallocator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- tikv-jemallocator-devel , rust-tikv-jemallocator+default-devel , rust- tikv-jemallocator+alloc_trait-devel , rust-tikv- jemallocator+background_threads-devel , rust-tikv- jemallocator+background_threads_runtime_support-devel , rust-tikv- jemallocator+debug-devel , rust-tikv-jemallocator+profiling-devel , rust-tikv-jemallocator+stats-devel , rust-tikv- jemallocator+unprefixed_malloc_on_supported_platforms-devel (Known issue with rust2rpm.) [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-tikv-jemallocator-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+default-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+alloc_trait-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+background_threads-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+background_threads_runtime_support-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+debug-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+profiling-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+stats-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator+unprefixed_malloc_on_supported_platforms-devel-0.6.0-1.fc43.noarch.rpm rust-tikv-jemallocator-0.6.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpctoo4yb5')] checks: 32, packages: 10 rust-tikv-jemallocator+background_threads_runtime_support-devel.noarch: E: description-line-too-long use the "background_threads_runtime_support" feature of the "tikv-jemallocator" crate. rust-tikv-jemallocator+unprefixed_malloc_on_supported_platforms-devel.noarch: E: description-line-too-long use the "unprefixed_malloc_on_supported_platforms" feature of the "tikv-jemallocator" crate. 10 packages and 0 specfiles checked; 2 errors, 0 warnings, 55 filtered, 2 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-tikv-jemallocator+stats-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+background_threads_runtime_support-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+background_threads-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+debug-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+default-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+profiling-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+alloc_trait-devel". (none): E: there is no installed rpm "rust-tikv-jemallocator+unprefixed_malloc_on_supported_platforms-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/tikv-jemallocator/0.6.0/download#/tikv-jemallocator-0.6.0.crate : CHECKSUM(SHA256) this package : 4cec5ff18518d81584f477e9bfdf957f5bb0979b0bac3af4ca30b5b3ae2d2865 CHECKSUM(SHA256) upstream package : 4cec5ff18518d81584f477e9bfdf957f5bb0979b0bac3af4ca30b5b3ae2d2865 Requires -------- rust-tikv-jemallocator-devel (rpmlib, GLIBC filtered): (crate(libc) >= 0.2.8 with crate(libc) < 0.3.0~) (crate(tikv-jemalloc-sys) >= 0.6.0 with crate(tikv-jemalloc-sys) < 0.7.0~) cargo rust-tikv-jemallocator+default-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemallocator) crate(tikv-jemallocator/background_threads_runtime_support) rust-tikv-jemallocator+alloc_trait-devel (rpmlib, GLIBC filtered): cargo crate(tikv-jemallocator) rust-tikv-jemallocator+background_threads-devel (rpmlib, GLIBC filtered): (crate(tikv-jemalloc-sys/background_threads) >= 0.6.0 with crate(tikv-jemalloc-sys/background_threads) < 0.7.0~) cargo crate(tikv-jemallocator) rust-tikv-jemallocator+background_threads_runtime_support-devel (rpmlib, GLIBC filtered): (crate(tikv-jemalloc-sys/background_threads_runtime_support) >= 0.6.0 with crate(tikv-jemalloc-sys/background_threads_runtime_support) < 0.7.0~) cargo crate(tikv-jemallocator) rust-tikv-jemallocator+debug-devel (rpmlib, GLIBC filtered): (crate(tikv-jemalloc-sys/debug) >= 0.6.0 with crate(tikv-jemalloc-sys/debug) < 0.7.0~) cargo crate(tikv-jemallocator) rust-tikv-jemallocator+profiling-devel (rpmlib, GLIBC filtered): (crate(tikv-jemalloc-sys/profiling) >= 0.6.0 with crate(tikv-jemalloc-sys/profiling) < 0.7.0~) cargo crate(tikv-jemallocator) rust-tikv-jemallocator+stats-devel (rpmlib, GLIBC filtered): (crate(tikv-jemalloc-sys/stats) >= 0.6.0 with crate(tikv-jemalloc-sys/stats) < 0.7.0~) cargo crate(tikv-jemallocator) rust-tikv-jemallocator+unprefixed_malloc_on_supported_platforms-devel (rpmlib, GLIBC filtered): (crate(tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms) >= 0.6.0 with crate(tikv-jemalloc-sys/unprefixed_malloc_on_supported_platforms) < 0.7.0~) cargo crate(tikv-jemallocator) Provides -------- rust-tikv-jemallocator-devel: crate(tikv-jemallocator) rust-tikv-jemallocator-devel rust-tikv-jemallocator+default-devel: crate(tikv-jemallocator/default) rust-tikv-jemallocator+default-devel rust-tikv-jemallocator+alloc_trait-devel: crate(tikv-jemallocator/alloc_trait) rust-tikv-jemallocator+alloc_trait-devel rust-tikv-jemallocator+background_threads-devel: crate(tikv-jemallocator/background_threads) rust-tikv-jemallocator+background_threads-devel rust-tikv-jemallocator+background_threads_runtime_support-devel: crate(tikv-jemallocator/background_threads_runtime_support) rust-tikv-jemallocator+background_threads_runtime_support-devel rust-tikv-jemallocator+debug-devel: crate(tikv-jemallocator/debug) rust-tikv-jemallocator+debug-devel rust-tikv-jemallocator+profiling-devel: crate(tikv-jemallocator/profiling) rust-tikv-jemallocator+profiling-devel rust-tikv-jemallocator+stats-devel: crate(tikv-jemallocator/stats) rust-tikv-jemallocator+stats-devel rust-tikv-jemallocator+unprefixed_malloc_on_supported_platforms-devel: crate(tikv-jemallocator/unprefixed_malloc_on_supported_platforms) rust-tikv-jemallocator+unprefixed_malloc_on_supported_platforms-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-tikv-jemallocator --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, Ocaml, Java, PHP, Haskell, R, fonts, Python, SugarActivity, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! https://release-monitoring.org/project/378157/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tikv-jemallocator
Closing since the following updates made it to stable: https://bodhi.fedoraproject.org/updates/FEDORA-2025-43a1ee1848 https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd2ff3c4d4 https://bodhi.fedoraproject.org/updates/FEDORA-2025-8aa74ac160 https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-61b874abde
Thanks! It seems that I forgot to associate this bug with the updates that contained the initial builds.