Bug 237754 - Wrong init script
Summary: Wrong init script
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: acpid
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zdenek Prikryl
QA Contact:
URL:
Whiteboard:
: 246860 (view as bug list)
Depends On: 237752
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-04-25 09:03 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-07-25 09:06:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michal Marciniszyn 2007-04-25 09:03:34 UTC
+++ This bug was initially created as a clone of Bug #237752 +++

Description of problem:
This construction returns error code 0 even when the service is not correctly
runned:

[ -x /usr/sbin/acpid ] || exit 0
[ -f /proc/acpi/event ] || exit 0

Also the status command (that should always return state of the service) is
ended withou even finding out the state.

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. rename conf file/change permissions on binary
2. service acpid start
3. echo $?
  
Actual results:
0

Expected results:
correct error code

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is implemented correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

Comment 1 Phil Knirsch 2007-05-16 15:54:32 UTC
So what would you suggest how to fix it? We can't really run the initscript
without kernel support. And letting it always fail with an error if the kernel
doesn't support ACPI isn't really good either.

Read ya, Phil

Comment 2 Zdenek Prikryl 2007-07-25 09:16:29 UTC
*** Bug 246860 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.