Bug 237978
| Summary: | Wrong init script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Michal Marciniszyn <mmarcini> | ||||
| Component: | dhcp | Assignee: | Dave Cantrell <dcantrell> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.0 | CC: | tvujec | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | RHBA-2008-0323 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-05-21 15:24:15 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 237789, 237984, 237985 | ||||||
| Attachments: |
|
||||||
Created attachment 206011 [details]
dhcpd.init
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Adding QA_ACK for 5.2 Fixed in dhcp-3.0.5-9.el5, moving to MODIFIED. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0323.html |
Description of problem: Following code ends init script with error code 0 even though the service is not started: [ ${NETWORKING} = "no" ] && exit 0 [ -f /usr/sbin/dhcpd ] || exit 0 There is also at least one place where is incorrect error code (unimplemented feature of the script). Version-Release number of selected component (if applicable): all How reproducible: always Steps to Reproduce: 1. service network stop 2. service dhcpd start/status 3. echo $? Actual results: 0 Expected results: non-zero error code/status code of the service Additional info: When fixing this bug, please obbey our init script guidelines and be sure that status command is run correctly. Our guidelines are on following two pages: http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html For an example of the script that returns the error codes correctly and always runs status see: http://devserv.devel.redhat.com/~mmarcini/amd This bug is tracked by 237789.