Bug 237985 - Wrong init script
Summary: Wrong init script
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: dhcp
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: David Cantrell
QA Contact:
URL:
Whiteboard:
Depends On: 237978
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-04-26 12:52 UTC by Michal Marciniszyn
Modified: 2014-02-10 23:02 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-04-26 18:49:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michal Marciniszyn 2007-04-26 12:52:27 UTC
+++ This bug was initially created as a clone of Bug #237978 +++

Description of problem:
Following code ends init script with error code 0 even though the service is not
started:
[ ${NETWORKING} = "no" ] && exit 0

[ -f /usr/sbin/dhcpd ] || exit 0
There is also at least one place where is incorrect error code (unimplemented
feature of the script).

Version-Release number of selected component (if applicable):
all

How reproducible:
always

Steps to Reproduce:
1. service network stop
2. service dhcpd start/status
3. echo $?
  
Actual results:
0

Expected results:
non-zero error code/status code of the service

Additional info:
When fixing this bug, please obbey our init script guidelines and be sure that
status command is run correctly.
Our guidelines are on following two pages:
http://intranet.corp.redhat.com/ic/intranet/InitscriptsSpec.html
http://intranet.corp.redhat.com/ic/intranet/InitscriptGuidelines.html

For an example of the script that returns the error codes correctly and always
runs status see:
http://devserv.devel.redhat.com/~mmarcini/amd

This bug is tracked by 237789.

Comment 1 David Cantrell 2007-04-26 18:49:55 UTC
Fixed in dhcp-3.0.5-34 in rawhide.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.