Spec URL: https://www.bachelot.org/fedora/SPECS/perl-AnyEvent-XSPromises.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-AnyEvent-XSPromises-0.006-1.fc43.src.rpm Description: This library provides a Promises interface, written in XS for performance, conforming to the Promises/A+ specification. Fedora Account System Username: xavierb
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package owns directories that are also owned by a package that this depends on. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership - No licence text. We should ask upstream to include it. ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/mavit/src/fedora/reviews/2383874-perl- AnyEvent-XSPromises/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/perl5/vendor_perl/AnyEvent(perl-AnyEvent) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 561 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-AnyEvent-XSPromises-0.006-1.fc43.x86_64.rpm perl-AnyEvent-XSPromises-0.006-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqnm86342')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: perl-AnyEvent-XSPromises-debuginfo-0.006-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_ys4_h70')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.5 s Unversioned so-files -------------------- perl-AnyEvent-XSPromises: /usr/lib64/perl5/vendor_perl/auto/AnyEvent/XSPromises/XSPromises.so Source checksums ---------------- http://www.cpan.org/modules/by-module/AnyEvent/AnyEvent-XSPromises-0.006.tar.gz : CHECKSUM(SHA256) this package : 16088a6420d4c1d4c628a9b7cdf7a7286de7dfdf6b408eb571846f6780bc74e6 CHECKSUM(SHA256) upstream package : 16088a6420d4c1d4c628a9b7cdf7a7286de7dfdf6b408eb571846f6780bc74e6 Requires -------- perl-AnyEvent-XSPromises (rpmlib, GLIBC filtered): libperl.so.5.42()(64bit) perl(:MODULE_COMPAT_5.42.0) perl(:VERSION) perl(AnyEvent) perl(AnyEvent::XSPromises::Loader) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) perl-libs rtld(GNU_HASH) Provides -------- perl-AnyEvent-XSPromises: perl(AnyEvent::XSPromises) perl(AnyEvent::XSPromises::Loader) perl-AnyEvent-XSPromises perl-AnyEvent-XSPromises(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2383874 Buildroot used: fedora-rawhide-x86_64 Active plugins: Perl, Shell-api, Generic Disabled plugins: Python, Haskell, Ocaml, fonts, R, C/C++, SugarActivity, PHP, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-AnyEvent-XSPromises.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-AnyEvent-XSPromises-0.006-2.fc43.src.rpm - Fixed directory ownership - Opened an issue about the missing license file, which should hopefully show up there shortly: https://rt.cpan.org/Dist/Display.html?Status=__Active__;Queue=AnyEvent-XSPromises
Copr build: https://copr.fedorainfracloud.org/coprs/build/9379763 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383874-perl-anyevent-xspromises/fedora-rawhide-x86_64/09379763-perl-AnyEvent-XSPromises/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Approved.
Thanks for the review Oliver !
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-AnyEvent-XSPromises