Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Cassandra-Client.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Cassandra-Client-0.21-1.fc43.src.rpm Description: Cassandra::Client is a Perl library giving its users access to the Cassandra database, through the native protocol. Both synchronous and asynchronous querying is supported, through various common calling styles. Fedora Account System Username: xavierb
URL is usable. Ok. FIX: Source0 URL returns an error. Please use <https://cpan.metacpan.org/authors/id/T/TV/TVDW/Cassandra-Client-%{version}.tar.gz> as advertised on the MetaCPAN page. Source0 file (SHA-512: 32a6a09bd8f31c96498ee043ccf387393be766e1ab70cdec65002d9d8f0f4c7980cfea4c32ff2cdbabc35ec508cfcf906351480af4e280d74df11b7855b0616c) is original. Ok. Patch0 file (SHA-512: 7a3812928de9f0e70476b3269d99012532a28594c62866d6c5d73eda7d8ae197a7171b1e530b708a2c4199bd1aa0afef74cadced8baabe44141fa6967e88aa68) is original. Ok. Summary verified from lib/Cassandra/Client.pm. Ok. Description verified from lib/Cassandra/Client.pm. Ok. License verified from README, Makefile.PL, various files in lib/Cassandra/Client, LICENSE, and ppport.h. Ok. This is an XS module, full-arch is Ok. FIX: Build-require `findutils' (perl-Cassandra-Client.spec:79). TODO: Replace `-exec rm -f {} \;' arguments with `-delete' in the file command. Test::Pod not used. Ok. TODO: Unset AUTHOR_TESTING, BENCHMARK, CASSANDRA_HOST environment variables in %check phase to make the tests more deterministic. FIX: Do not build-require `perl(Benchmark)'. It's not used if BENCHMARK environment variable is not true (t/06-async-utils.t:8). TODO: Most tests are skipped ("Missing Cassandra test environment)" if CASSANDRA_HOST environemnt variable is not set. I recommend removing the test files in %prep section and their build-time dependencies (e.g. File::Basename). The tests pass. Ok. $ rpmlint perl-Cassandra-Client.spec ../SRPMS/perl-Cassandra-Client-0.21-1.fc44.src.rpm ../RPMS/x86_64/perl-Cassandra-Client-* ======================================== rpmlint session starts ======================================= rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 perl-Cassandra-Client.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Cassandra-Client/LICENSE == 4 packages and 1 specfiles checked; 1 errors, 0 warnings, 13 filtered, 1 badness; has taken 0.6 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Cassandra-Client-0.21-1.fc44.x86_64.rpm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib/.build-id/af lrwxrwxrwx 1 root root 71 Jul 28 02:00 /usr/lib/.build-id/af/3f7315d2a2f31a5a40c98e9996f0b05a328afb -> ../../../../usr/lib64/perl5/vendor_perl/auto/Cassandra/Client/Client.so drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client -rw-r--r-- 1 root root 25485 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client.pm -rw-r--r-- 1 root root 4138 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/AsyncAnyEvent.pm -rw-r--r-- 1 root root 4271 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/AsyncEV.pm -rw-r--r-- 1 root root 3793 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Config.pm -rw-r--r-- 1 root root 37132 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Connection.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Error -rw-r--r-- 1 root root 912 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Error/Base.pm -rw-r--r-- 1 root root 699 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Error/ClientThrottlingError.pm -rw-r--r-- 1 root root 819 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Error/ReadTimeoutException.pm -rw-r--r-- 1 root root 710 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Error/UnavailableException.pm -rw-r--r-- 1 root root 777 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Error/WriteTimeoutException.pm -rw-r--r-- 1 root root 1270 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Metadata.pm -rw-r--r-- 1 root root 4534 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/NetworkStatus.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Auth -rw-r--r-- 1 root root 1208 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Auth/Password.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/LoadBalancing -rw-r--r-- 1 root root 3032 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/LoadBalancing/Default.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Queue -rw-r--r-- 1 root root 1240 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Queue/Default.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Retry -rw-r--r-- 1 root root 771 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Retry.pm -rw-r--r-- 1 root root 2239 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Retry/Default.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Throttle -rw-r--r-- 1 root root 2053 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Throttle/Adaptive.pm -rw-r--r-- 1 root root 709 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Policy/Throttle/Default.pm -rw-r--r-- 1 root root 7393 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Pool.pm -rw-r--r-- 1 root root 11559 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Protocol.pm -rw-r--r-- 1 root root 1697 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/ResultSet.pm -rw-r--r-- 1 root root 1854 Dec 18 2023 /usr/lib64/perl5/vendor_perl/Cassandra/Client/TLSHandling.pm -rw-r--r-- 1 root root 1732 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/Cassandra/Client/Util.pm drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/auto/Cassandra drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/auto/Cassandra/Client -rwxr-xr-x 1 root root 52816 Jul 28 02:00 /usr/lib64/perl5/vendor_perl/auto/Cassandra/Client/Client.so drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/share/doc/perl-Cassandra-Client -rw-r--r-- 1 root root 4061 Dec 18 2023 /usr/share/doc/perl-Cassandra-Client/Changes -rw-r--r-- 1 root root 413 Dec 18 2023 /usr/share/doc/perl-Cassandra-Client/README drwxr-xr-x 2 root root 0 Jul 28 02:00 /usr/share/licenses/perl-Cassandra-Client -rw-r--r-- 1 root root 18367 Dec 18 2023 /usr/share/licenses/perl-Cassandra-Client/LICENSE -rw-r--r-- 1 root root 5017 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client.3pm.gz -rw-r--r-- 1 root root 1077 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::AsyncAnyEvent.3pm.gz -rw-r--r-- 1 root root 1074 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::AsyncEV.3pm.gz -rw-r--r-- 1 root root 1071 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Config.3pm.gz -rw-r--r-- 1 root root 1071 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Connection.3pm.gz -rw-r--r-- 1 root root 1076 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Error::Base.3pm.gz -rw-r--r-- 1 root root 1084 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Error::ClientThrottlingError.3pm.gz -rw-r--r-- 1 root root 1089 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Error::ReadTimeoutException.3pm.gz -rw-r--r-- 1 root root 1088 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Error::UnavailableException.3pm.gz -rw-r--r-- 1 root root 1089 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Error::WriteTimeoutException.3pm.gz -rw-r--r-- 1 root root 1072 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Metadata.3pm.gz -rw-r--r-- 1 root root 1078 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::NetworkStatus.3pm.gz -rw-r--r-- 1 root root 1084 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::Auth::Password.3pm.gz -rw-r--r-- 1 root root 1093 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::LoadBalancing::Default.3pm.gz -rw-r--r-- 1 root root 1087 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::Queue::Default.3pm.gz -rw-r--r-- 1 root root 1078 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::Retry.3pm.gz -rw-r--r-- 1 root root 1085 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::Retry::Default.3pm.gz -rw-r--r-- 1 root root 1090 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::Throttle::Adaptive.3pm.gz -rw-r--r-- 1 root root 1088 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Policy::Throttle::Default.3pm.gz -rw-r--r-- 1 root root 1070 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Pool.3pm.gz -rw-r--r-- 1 root root 1073 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Protocol.3pm.gz -rw-r--r-- 1 root root 1408 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::ResultSet.3pm.gz -rw-r--r-- 1 root root 1075 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::TLSHandling.3pm.gz -rw-r--r-- 1 root root 1070 Jul 28 02:00 /usr/share/man/man3/Cassandra::Client::Util.3pm.gz File layout and file permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Cassandra-Client-0.21-1.fc44.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libperl.so.5.42()(64bit) 1 perl(:MODULE_COMPAT_5.42.0) 1 perl(:VERSION) >= 5.10.0 1 perl(AnyEvent::XSPromises) 1 perl(Cassandra::Client::AsyncAnyEvent) 1 perl(Cassandra::Client::AsyncEV) 1 perl(Cassandra::Client::Config) 1 perl(Cassandra::Client::Connection) 1 perl(Cassandra::Client::Error::Base) 1 perl(Cassandra::Client::Error::ClientThrottlingError) 1 perl(Cassandra::Client::Error::ReadTimeoutException) 1 perl(Cassandra::Client::Error::UnavailableException) 1 perl(Cassandra::Client::Error::WriteTimeoutException) 1 perl(Cassandra::Client::Metadata) 1 perl(Cassandra::Client::NetworkStatus) 1 perl(Cassandra::Client::Policy::Auth::Password) 1 perl(Cassandra::Client::Policy::LoadBalancing::Default) 1 perl(Cassandra::Client::Policy::Queue::Default) 1 perl(Cassandra::Client::Policy::Retry) 1 perl(Cassandra::Client::Policy::Retry::Default) 1 perl(Cassandra::Client::Policy::Throttle::Default) 1 perl(Cassandra::Client::Pool) 1 perl(Cassandra::Client::Protocol) 1 perl(Cassandra::Client::ResultSet) 1 perl(Cassandra::Client::TLSHandling) 1 perl(Cassandra::Client::Util) 1 perl(Clone) >= 0.36 1 perl(constant) 1 perl(Devel::GlobalDestruction) >= 0.11 1 perl(Encode) 1 perl(Errno) 1 perl(EV) >= 4 1 perl(Exporter) 1 perl(feature) 1 perl(if) 1 perl(IO::Socket::INET) 1 perl(IO::Socket::INET6) 1 perl(List::Util) 1 perl(Net::SSLeay) >= 1.63 1 perl(overload) 1 perl(parent) 1 perl(Ref::Util) >= 0.008 1 perl(Scalar::Util) 1 perl(Socket) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(vars) 1 perl(warnings) 1 perl(XSLoader) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) FIX: Run-require `perl(AnyEvent)` (lib/Cassandra/Client/AsyncAnyEvent.pm:16). FIX: Either run-require `perl(Math::BingInt)`, or remove it from build-requires (lib/Cassandra/Client/Protocol.pm:19). It's not needed on x86_64. You will need to check i686. $ rpm -q --provides -p ../RPMS/x86_64/perl-Cassandra-Client-0.21-1.fc44.x86_64.rpm | sort -f | uniq -c 1 perl(Cassandra::Client) = 0.21 1 perl(Cassandra::Client::AsyncAnyEvent) = 0.21 1 perl(Cassandra::Client::AsyncEV) = 0.21 1 perl(Cassandra::Client::Config) = 0.21 1 perl(Cassandra::Client::Connection) = 0.21 1 perl(Cassandra::Client::Error::Base) = 0.21 1 perl(Cassandra::Client::Error::ClientThrottlingError) = 0.21 1 perl(Cassandra::Client::Error::ReadTimeoutException) = 0.21 1 perl(Cassandra::Client::Error::UnavailableException) = 0.21 1 perl(Cassandra::Client::Error::WriteTimeoutException) = 0.21 1 perl(Cassandra::Client::Metadata) = 0.21 1 perl(Cassandra::Client::NetworkStatus) = 0.21 1 perl(Cassandra::Client::Policy::Auth::Password) = 0.21 1 perl(Cassandra::Client::Policy::LoadBalancing::Default) = 0.21 1 perl(Cassandra::Client::Policy::Queue::Default) = 0.21 1 perl(Cassandra::Client::Policy::Retry) = 0.21 1 perl(Cassandra::Client::Policy::Retry::Default) = 0.21 1 perl(Cassandra::Client::Policy::Throttle::Adaptive) = 0.21 1 perl(Cassandra::Client::Policy::Throttle::Default) = 0.21 1 perl(Cassandra::Client::Pool) = 0.21 1 perl(Cassandra::Client::Protocol) = 0.21 1 perl(Cassandra::Client::ResultSet) = 0.21 1 perl(Cassandra::Client::TLSHandling) = 0.21 1 perl(Cassandra::Client::TLSHandling::conn) = 0.21 1 perl(Cassandra::Client::Util) = 0.21 1 perl-Cassandra-Client = 0.21-1.fc44 1 perl-Cassandra-Client(x86-64) = 0.21-1.fc44 Biinary provides are Ok. $ resolvedeps f44-build ../RPMS/x86_64/perl-Cassandra-Client-0.21-1.fc44.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 44 (https://koji.fedoraproject.org/koji/taskinfo?taskID=138786344). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please, correct the FIX items, consider fixing TODO items, and provide an updated spec file.
Thanks for the review Petr ! Hopefully your comments should be addressed. Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Cassandra-Client.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Cassandra-Client-0.21-2.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9777225 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2383876-perl-cassandra-client/fedora-rawhide-x86_64/09777225-perl-Cassandra-Client/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
$ rpmlint perl-Cassandra-Client.spec ../SRPMS/perl-Cassandra-Client-0.21-2.fc44.src.rpm ../RPMS/x86_64/perl-Cassandra-Client-* ======================================== rpmlint session starts ======================================= rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 perl-Cassandra-Client.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Cassandra-Client/LICENSE == 4 packages and 1 specfiles checked; 1 errors, 0 warnings, 13 filtered, 1 badness; has taken 0.7 s == rpmlint is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Cassandra-Client-0.21-2.fc44.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libperl.so.5.42()(64bit) 1 perl(:MODULE_COMPAT_5.42.0) 1 perl(:VERSION) >= 5.10.0 1 perl(AnyEvent) 1 perl(AnyEvent::XSPromises) 1 perl(Cassandra::Client::AsyncAnyEvent) 1 perl(Cassandra::Client::AsyncEV) 1 perl(Cassandra::Client::Config) 1 perl(Cassandra::Client::Connection) 1 perl(Cassandra::Client::Error::Base) 1 perl(Cassandra::Client::Error::ClientThrottlingError) 1 perl(Cassandra::Client::Error::ReadTimeoutException) 1 perl(Cassandra::Client::Error::UnavailableException) 1 perl(Cassandra::Client::Error::WriteTimeoutException) 1 perl(Cassandra::Client::Metadata) 1 perl(Cassandra::Client::NetworkStatus) 1 perl(Cassandra::Client::Policy::Auth::Password) 1 perl(Cassandra::Client::Policy::LoadBalancing::Default) 1 perl(Cassandra::Client::Policy::Queue::Default) 1 perl(Cassandra::Client::Policy::Retry) 1 perl(Cassandra::Client::Policy::Retry::Default) 1 perl(Cassandra::Client::Policy::Throttle::Default) 1 perl(Cassandra::Client::Pool) 1 perl(Cassandra::Client::Protocol) 1 perl(Cassandra::Client::ResultSet) 1 perl(Cassandra::Client::TLSHandling) 1 perl(Cassandra::Client::Util) 1 perl(Clone) >= 0.36 1 perl(constant) 1 perl(Devel::GlobalDestruction) >= 0.11 1 perl(Encode) 1 perl(Errno) 1 perl(EV) >= 4 1 perl(Exporter) 1 perl(feature) 1 perl(if) 1 perl(IO::Socket::INET) 1 perl(IO::Socket::INET6) 1 perl(List::Util) 1 perl(Math::BingInt) 1 perl(Net::SSLeay) >= 1.63 1 perl(overload) 1 perl(parent) 1 perl(Ref::Util) >= 0.008 1 perl(Scalar::Util) 1 perl(Socket) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(vars) 1 perl(warnings) 1 perl(XSLoader) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. The package builds in Fedora 44 (https://koji.fedoraproject.org/koji/taskinfo?taskID=138819396). Ok. The package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Cassandra-Client