Spec URL: https://buckaroogeek.fedorapeople.org/reviews/kompose.spec SRPM URL: https://buckaroogeek.fedorapeople.org/reviews/kompose-1.38.0-1.fc45.src.rpm Description: Kompose is a conversion tool for Docker Compose files to container orchestrators such as Kubernetes. New spec generated via go2rpm with vendor profile. Fedora Account System Username: buckaroogeek
Copr build: https://copr.fedorainfracloud.org/coprs/build/9553527 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394974-kompose/fedora-rawhide-x86_64/09553527-kompose/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kompose Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Documentation size is 20278992 bytes in 151 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> %global gotestflags -short -compiler gc -race -cover I'd avoid this and just use the default Fedora compiler flags.
Thanks. Change made. Spec and src replaced. Re: Issues. 1. I have adopted the existing project which was orphaned. This review needed as the project was ophaned 2+ years ago. 2. Documentation is a web based user guide under the docs subdirectory. The --no-docs dnf flag will strip it out. [fedora-review-service-build]
Created attachment 2106559 [details] The .spec file difference from Copr build 9553527 to 9553792
Copr build: https://copr.fedorainfracloud.org/coprs/build/9553792 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394974-kompose/fedora-rawhide-x86_64/09553792-kompose/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kompose Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Documentation size is 20278992 bytes in 151 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> 2. Documentation is a web based user guide under the docs subdirectory. The --no-docs dnf flag will strip it out. It's still a guideline to put large documentation directories in a doc subpackage.
> %global go_ldflags -X %{goipath}/pkg/version.GITCOMMIT=%{release} > export GO_LDFLAGS="%{go_ldflags}" > (...) > export GO_LDFLAGS="%{go_ldflags}" would make more sense to just assign it to GO_LDFLAGS instead of doing it twice. Also, is required for the tests to have it assigned?
Many thanks Maxwell and Mikel. You comments improved the specfile. I created a docs subpackage. I often debate build and check settings in the spec file between following the upstream as, for example, defined in a Makefile or starting with the default settings for processing a golang project specfile. Not setting GO_LDFLAGS for check did not affect gotest results so I left it out in favour of simplicity. [fedora-review-service-build]
Created attachment 2106611 [details] The .spec file difference from Copr build 9553792 to 9554960
Copr build: https://copr.fedorainfracloud.org/coprs/build/9554960 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394974-kompose/fedora-rawhide-x86_64/09554960-kompose/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kompose Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, I see this package has not been looked at since the latest upload. * Build: - Local: RPM build warnings: /builddir/build/SPECS/kompose.spec line 40: autopatch: no matching patches in range File listed twice: /usr/share/licenses/kompose Finish: rpmbuild kompose-1.37.0-1.fc44.src.rpm - COPR: OK, with rpmlint issues Review: ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcgqkc62r')] checks: 32, packages: 3 kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/animate.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/owl.carousel.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/owl.theme.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/style.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/custom.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/live.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/menu-2.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/menu.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/plugins.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/validator.js kompose.spec: W: specfile-warning warning: /tmp/rpmlint.kompose-1.37.0-1.fc45.src.rpm._sda600y/kompose.spec line 40: autopatch: no matching patches in range kompose.x86_64: W: no-manual-page-for-binary kompose kompose-doc.x86_64: E: no-binary kompose.spec: W: invalid-url Source1: kompose-1.37.0-vendor.tar.bz2 kompose-doc.x86_64: E: files-duplicated-waste 159241 kompose.x86_64: W: files-duplicate /usr/share/licenses/kompose/vendor/sigs.k8s.io/structured-merge-diff/v4/LICENSE /usr/share/licenses/kompose/LICENSE:/usr/share/licenses/kompose/vendor/github.com/go-logr/logr/LICENSE:/usr/share/licenses/kompose/vendor/gopkg.in/yaml.v2/LICENSE kompose.x86_64: W: files-duplicate /usr/share/licenses/kompose/vendor/modules.txt /usr/share/licenses/kompose/modules.txt kompose-doc.x86_64: W: files-duplicate /usr/share/licenses/kompose-doc/LICENSE /usr/share/doc/kompose-doc/docs/LICENSE kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/favicon.ico /usr/share/doc/kompose-doc/docs/assets/favicons/favicon.ico kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/assets/icons/rev3.png /usr/share/doc/kompose-doc/docs/assets/icons/rev.png:/usr/share/doc/kompose-doc/docs/assets/icons/rev2.png kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/images/design_diagram.png /usr/share/doc/kompose-doc/docs/docs/images/design_diagram.png kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/images/kompose-maven-output-diagram.png /usr/share/doc/kompose-doc/docs/docs/images/kompose-maven-output-diagram.png 3 packages and 0 specfiles checked; 2 errors, 20 warnings, 97 filtered, 2 badness; has taken 2.0 s We can dig in and review upon new upload. Regards Phil
thanks! [fedora-review-service-build]
Created attachment 2131822 [details] The .spec file difference from Copr build 9554960 to 10185525
Copr build: https://copr.fedorainfracloud.org/coprs/build/10185525 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394974-kompose/fedora-rawhide-x86_64/10185525-kompose/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kompose Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, Local mock build: RPM build warnings: File listed twice: /usr/share/licenses/kompose You may wish to refer to below to improve the spec file. https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ Regards Phil
[fedora-review-service-build]
(In reply to Phil Wyett from comment #15) > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ > > Regards > > Phil Thanks for checking again. Updated spec and src rpm uploaded. In the spec I also changed Requires: rubygem-bundler to Recommended:. best regards Brad
Created attachment 2132036 [details] The .spec file difference from Copr build 10185525 to 10190617
Copr build: https://copr.fedorainfracloud.org/coprs/build/10190617 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2394974-kompose/fedora-rawhide-x86_64/10190617-kompose/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/kompose Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, * Builds are good both local and COPR. * /usr/share/doc/kompose-doc/docs/assets/video/ Three videos with one being unplayable mp4. * RPM Lint. ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyfhmhgku')] checks: 32, packages: 3 kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/animate.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/owl.carousel.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/owl.theme.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/css/style.css kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/custom.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/live.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/menu-2.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/menu.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/plugins.js kompose-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/kompose-doc/docs/assets/js/validator.js kompose.x86_64: W: no-manual-page-for-binary kompose kompose-doc.x86_64: E: no-binary kompose.spec: W: invalid-url Source1: kompose-1.38.0-vendor.tar.bz2 kompose-doc.x86_64: E: files-duplicated-waste 159241 kompose.x86_64: W: files-duplicate /usr/share/licenses/kompose/vendor/sigs.k8s.io/structured-merge-diff/v4/LICENSE /usr/share/licenses/kompose/LICENSE:/usr/share/licenses/kompose/vendor/github.com/go-logr/logr/LICENSE:/usr/share/licenses/kompose/vendor/gopkg.in/yaml.v2/LICENSE kompose-doc.x86_64: W: files-duplicate /usr/share/licenses/kompose-doc/LICENSE /usr/share/doc/kompose-doc/docs/LICENSE kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/favicon.ico /usr/share/doc/kompose-doc/docs/assets/favicons/favicon.ico kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/assets/icons/rev3.png /usr/share/doc/kompose-doc/docs/assets/icons/rev.png:/usr/share/doc/kompose-doc/docs/assets/icons/rev2.png kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/images/design_diagram.png /usr/share/doc/kompose-doc/docs/docs/images/design_diagram.png kompose-doc.x86_64: W: files-duplicate /usr/share/doc/kompose-doc/docs/images/kompose-maven-output-diagram.png /usr/share/doc/kompose-doc/docs/docs/images/kompose-maven-output-diagram.png 3 packages and 0 specfiles checked; 2 errors, 18 warnings, 95 filtered, 2 badness; has taken 1.6 s You may wish to review and either fix or justifiy. Regards Phil
The doc rpm basically installs the files needed for kompose.io and uses Jekyll. Installing a jekyll web site to /usr/share/doc does not seem to be easily doable. I am included to drop the doc rpm altogether and point users to the online site at kompose.io. thoughts?
Hi, * I would rm -f the 'mp4' file from the archive. The '.mp4' seems to not be called in docs or other in the built packages. * '%{archivename}' is not declared/set prior to use in the spec file. * Remove 'Enhances: kompose' from spec file. * doc packages should be 'noarch'. Fix these and do an upload of new spec and srpm and we will look again. Regards Phil
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.