Bug 239526 - Review Request: python-gammu - Python bindings for Gammu
Review Request: python-gammu - Python bindings for Gammu
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On: 239525
Blocks: 239527
  Show dependency treegraph
 
Reported: 2007-05-09 02:36 EDT by Xavier Lamien
Modified: 2007-11-30 17:12 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-12 21:49:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Xavier Lamien 2007-05-09 02:36:24 EDT
Spec URL: http://download.tuxfamily.org/lxtnow/fedora/SPECS/python-gammu.spec
SRPM URL: http://download.tuxfamily.org/lxtnow/temp/python-gammu-0.19-1.src.rpm
MockLog: http://download.tuxfamily.org/lxtnow/temp/python-gammu-0.19-build.log

Description:

Python bindings for Gammu library.
It currently does not support all Gammu features,but range of covered functions is increasing,if you need some specific, feel free to use bug tracking
system for feature requests.
Comment 1 Parag AN(पराग) 2007-05-14 01:58:46 EDT
So this package is also having similar rpmlint output like gammu have.
Got spurious-executable-perm and doc-file-depencecy with rpmlint 0.80 version.
Any comments on why both warnings should be ignored?
Comment 2 Xavier Lamien 2007-05-22 20:46:57 EDT
those are exemples script which could be check for extras use (such as manage
smsbackup).
upstream isn't more explicit about them... :(
Comment 3 Parag AN(पराग) 2007-05-22 21:08:21 EDT
but here rpmlint is showing doc-file-dependency warning...
Is gammu-python really using these scripts or its for end-user to explicitly use
them? if that is then you can chmod 644 to those scripts.
Comment 4 Xavier Lamien 2007-05-23 20:56:06 EDT
It's typically for end-user and sure these can be set to 0644.
i actually fix that but i need to import first new gammu release before add the
updated release of python-gammu which require gammu-1.10.7 to be able to build.



Comment 5 Xavier Lamien 2007-05-28 23:59:18 EDT
Well,

Here is the updated release 0.20 with its fix.
you'll find out srpm, spec and build.log files from link below.

http://download.tuxfamily.org/lxtnow/extras/gammu
Comment 6 Xavier Lamien 2007-06-04 12:28:41 EDT
ping : Parag ?
Comment 7 Parag AN(पराग) 2007-06-04 12:59:35 EDT
will do review by tomorrow
Comment 8 Parag AN(पराग) 2007-06-04 21:08:59 EDT
rpmlint on SRPM reports
W: python-gammu mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 4)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

you can correct this at time of cvs import. 
Comment 9 Parag AN(पराग) 2007-06-04 21:10:56 EDT
Review:
+ package builds in mock (development i386).
- rpmlint is NOT silent for SRPM
+ rpmlint is silent for RPM.
+ source files match upstream url
a2470a7336286805d9698b3d67bb23c1  python-gammu-0.20.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Provides: Core.so
+ Requires: gammu libGammu.so.1 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libm.so.6 libpthread.so.0
libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH)
APPROVED


Don't forget to solve rpmlint warning on SRPM.
Comment 10 Xavier Lamien 2007-06-05 10:04:09 EDT
I will fix that before request CVSsync, thanks Parag
Comment 11 Xavier Lamien 2007-06-06 01:02:12 EDT
Done,

New Package CVS Request
=======================
Package Name: python-gammu
Short Description: Python bindings for Gammu
Owners: lxtnow@gmail.com
Branches: FC-5 FC-6 F-7 EL-4 EL-5 Devel
InitialCC: 
Comment 12 Jason Tibbitts 2007-06-06 12:33:04 EDT
CVS done.
Comment 13 Xavier Lamien 2007-06-12 21:49:19 EDT
imported and built.

Thanks to all

Note You need to log in before you can comment on or make changes to this bug.