Spec URL: https://music.fedorapeople.org/rust-get-size-derive2.spec SRPM URL: https://music.fedorapeople.org/rust-get-size-derive2-0.6.3-1.fc42.src.rpm Description: Derives the GetSize trait. Fedora Account System Username: music This is a new indirect dependency for ruff 0.12.2 and later. The current upstream version is 0.7.0, but ruff just added support for that version in an unreleased commit (https://github.com/astral-sh/ruff/commit/32d00cd5694e1f47c12b6d222211b8b62ab0e7b1), and it included a code change. I am therefore choosing to package get-size-derive2/get-size2 0.6.x for now, and update to 0.7.0 once a ruff version that uses it is ready. COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9600663
Created attachment 2107574 [details] Configuration file for rust2rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/9600677 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398141-rust-get-size-derive2/fedora-rawhide-x86_64/09600677-rust-get-size-derive2/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Ben Beasley from comment #0) > COPR build with fedora-review enabled: > https://copr.fedorainfracloud.org/coprs/build/9600663 Correction: https://copr.fedorainfracloud.org/coprs/build/9601557
I’ve decided to start with the current 0.7.0 release of this package and try to jump forward to the very latest ruff version rather than working incrementally. New Spec URL: https://music.fedorapeople.org/20250926/rust-get-size-derive2.spec New SRPM URL: https://music.fedorapeople.org/20250926/rust-get-size-derive2-0.7.0-1.fc42.src.rpm New COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9602972
There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/20250926/rust-get-size-derive2-0.7.0-1.fc42.src.rpm Fetching it results in a 403 Forbidden error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 2107661 [details] The .spec file difference from Copr build 9600677 to 9603245
Copr build: https://copr.fedorainfracloud.org/coprs/build/9603245 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398141-rust-get-size-derive2/fedora-rawhide-x86_64/09603245-rust-get-size-derive2/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://release-monitoring.org/project/386121/
Package APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Tests depend circularly on the get-size2 crate [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-get-size-derive2
FEDORA-2025-41a85919fc (rust-get-size-derive2-0.7.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-41a85919fc
FEDORA-2025-41a85919fc (rust-get-size-derive2-0.7.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.