Created attachment 2107589 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-get-size2.spec SRPM URL: https://music.fedorapeople.org/rust-get-size2-0.6.3-1.fc42.src.rpm Description: Determine the size in bytes an object occupies inside RAM. Fedora Account System Username: music This is a new *direct* dependency for ruff 0.12.2 and later. The current upstream version is 0.7.0, but ruff just added support for that version in an unreleased commit (https://github.com/astral-sh/ruff/commit/32d00cd5694e1f47c12b6d222211b8b62ab0e7b1), and it included a code change. I am therefore choosing to package get-size-derive2/get-size2 0.6.x for now, and update to 0.7.0 once a ruff version that uses it is ready. COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9601515
Copr build: https://copr.fedorainfracloud.org/coprs/build/9601524 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398235-rust-get-size2/fedora-rawhide-x86_64/09601524-rust-get-size2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9601523 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398235-rust-get-size2/fedora-rawhide-x86_64/09601523-rust-get-size2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Ben Beasley from comment #0) > COPR build with fedora-review enabled: > https://copr.fedorainfracloud.org/coprs/build/9601515 Correction: https://copr.fedorainfracloud.org/coprs/build/9601569
I’ve decided to start with the current 0.7.0 release of this package and try to jump forward to the very latest ruff version rather than working incrementally. New Spec URL: https://music.fedorapeople.org/20250926/rust-get-size2.spec New SRPM URL: https://music.fedorapeople.org/20250926/rust-get-size2-0.7.0-1.fc42.src.rpm New COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/build/9602999
There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/20250926/rust-get-size2-0.7.0-1.fc42.src.rpm Fetching it results in a 403 Forbidden error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 2107663 [details] The .spec file difference from Copr build 9601524 to 9603243
Copr build: https://copr.fedorainfracloud.org/coprs/build/9603243 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2398235-rust-get-size2/fedora-rawhide-x86_64/09603243-rust-get-size2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://release-monitoring.org/project/386123/
Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 8 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust-get- size2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- get-size2-devel , rust-get-size2+default-devel , rust-get-size2+bytes- devel , rust-get-size2+chrono-devel , rust-get-size2+chrono-tz-devel , rust-get-size2+compact-str-devel , rust-get-size2+derive-devel , rust- get-size2+get-size-derive2-devel , rust-get-size2+hashbrown-devel , rust-get-size2+indexmap-devel , rust-get-size2+smallvec-devel , rust- get-size2+thin-vec-devel , rust-get-size2+url-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. The tests rely on using the crate as an external path-based dev-dependency. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-get-size2-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+default-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+bytes-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+chrono-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+chrono-tz-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+compact-str-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+derive-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+get-size-derive2-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+hashbrown-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+indexmap-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+smallvec-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+thin-vec-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2+url-devel-0.7.0-1.fc44.noarch.rpm rust-get-size2-0.7.0-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0l2scde_')] checks: 32, packages: 14 rust-get-size2-devel.noarch: E: world-writable /usr/share/cargo/registry/get-size2-0.7.0/LICENSE 666 rust-get-size2.src: W: strange-permission LICENSE 666 rust-get-size2.src: W: strange-permission get-size2-0.7.0.crate 666 rust-get-size2.src: W: strange-permission get-size2-fix-metadata.diff 666 rust-get-size2.src: W: strange-permission rust-get-size2.spec 666 14 packages and 0 specfiles checked; 1 errors, 4 warnings, 79 filtered, 1 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-get-size2+get-size-derive2-devel". (none): E: there is no installed rpm "rust-get-size2+derive-devel". (none): E: there is no installed rpm "rust-get-size2+chrono-devel". (none): E: there is no installed rpm "rust-get-size2+compact-str-devel". (none): E: there is no installed rpm "rust-get-size2+thin-vec-devel". (none): E: there is no installed rpm "rust-get-size2+smallvec-devel". (none): E: there is no installed rpm "rust-get-size2-devel". (none): E: there is no installed rpm "rust-get-size2+url-devel". (none): E: there is no installed rpm "rust-get-size2+bytes-devel". (none): E: there is no installed rpm "rust-get-size2+chrono-tz-devel". (none): E: there is no installed rpm "rust-get-size2+default-devel". (none): E: there is no installed rpm "rust-get-size2+hashbrown-devel". (none): E: there is no installed rpm "rust-get-size2+indexmap-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 13 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/bircni/get-size2/raw/b6f29700a268daa9e3fd1954bfe04906e43d90f7/LICENSE : CHECKSUM(SHA256) this package : 013ca8b1499479ce162f0d68ff25f4ac0a98dae625d55a8eabfb1fb4aa38933d CHECKSUM(SHA256) upstream package : 013ca8b1499479ce162f0d68ff25f4ac0a98dae625d55a8eabfb1fb4aa38933d https://crates.io/api/v1/crates/get-size2/0.7.0/download#/get-size2-0.7.0.crate : CHECKSUM(SHA256) this package : 5dfe2cec5b5ce8fb94dcdb16a1708baa4d0609cc3ce305ca5d3f6f2ffb59baed CHECKSUM(SHA256) upstream package : 5dfe2cec5b5ce8fb94dcdb16a1708baa4d0609cc3ce305ca5d3f6f2ffb59baed Requires -------- rust-get-size2-devel (rpmlib, GLIBC filtered): cargo rust-get-size2+default-devel (rpmlib, GLIBC filtered): cargo crate(get-size2) rust-get-size2+bytes-devel (rpmlib, GLIBC filtered): (crate(bytes) >= 1.0.0 with crate(bytes) < 2.0.0~) cargo crate(get-size2) rust-get-size2+chrono-devel (rpmlib, GLIBC filtered): (crate(chrono) >= 0.4.0 with crate(chrono) < 0.5.0~) cargo crate(get-size2) rust-get-size2+chrono-tz-devel (rpmlib, GLIBC filtered): (crate(chrono-tz) >= 0.10.0 with crate(chrono-tz) < 0.11.0~) cargo crate(get-size2) rust-get-size2+compact-str-devel (rpmlib, GLIBC filtered): (crate(compact_str) >= 0.9.0 with crate(compact_str) < 0.10.0~) cargo crate(get-size2) rust-get-size2+derive-devel (rpmlib, GLIBC filtered): cargo crate(get-size2) crate(get-size2/get-size-derive2) rust-get-size2+get-size-derive2-devel (rpmlib, GLIBC filtered): (crate(get-size-derive2/default) >= 0.7.0 with crate(get-size-derive2/default) < 0.8.0~) cargo crate(get-size2) rust-get-size2+hashbrown-devel (rpmlib, GLIBC filtered): (crate(hashbrown) >= 0.16.0 with crate(hashbrown) < 0.17.0~) cargo crate(get-size2) rust-get-size2+indexmap-devel (rpmlib, GLIBC filtered): (crate(indexmap) >= 2.10.0 with crate(indexmap) < 3.0.0~) cargo crate(get-size2) rust-get-size2+smallvec-devel (rpmlib, GLIBC filtered): (crate(smallvec) >= 1.0.0 with crate(smallvec) < 2.0.0~) cargo crate(get-size2) rust-get-size2+thin-vec-devel (rpmlib, GLIBC filtered): (crate(thin-vec) >= 0.2.0 with crate(thin-vec) < 0.3.0~) cargo crate(get-size2) rust-get-size2+url-devel (rpmlib, GLIBC filtered): (crate(url) >= 2.0.0 with crate(url) < 3.0.0~) cargo crate(get-size2) Provides -------- rust-get-size2-devel: crate(get-size2) rust-get-size2-devel rust-get-size2+default-devel: crate(get-size2/default) rust-get-size2+default-devel rust-get-size2+bytes-devel: crate(get-size2/bytes) rust-get-size2+bytes-devel rust-get-size2+chrono-devel: crate(get-size2/chrono) rust-get-size2+chrono-devel rust-get-size2+chrono-tz-devel: crate(get-size2/chrono-tz) rust-get-size2+chrono-tz-devel rust-get-size2+compact-str-devel: crate(get-size2/compact-str) rust-get-size2+compact-str-devel rust-get-size2+derive-devel: crate(get-size2/derive) rust-get-size2+derive-devel rust-get-size2+get-size-derive2-devel: crate(get-size2/get-size-derive2) rust-get-size2+get-size-derive2-devel rust-get-size2+hashbrown-devel: crate(get-size2/hashbrown) rust-get-size2+hashbrown-devel rust-get-size2+indexmap-devel: crate(get-size2/indexmap) rust-get-size2+indexmap-devel rust-get-size2+smallvec-devel: crate(get-size2/smallvec) rust-get-size2+smallvec-devel rust-get-size2+thin-vec-devel: crate(get-size2/thin-vec) rust-get-size2+thin-vec-devel rust-get-size2+url-devel: crate(get-size2/url) rust-get-size2+url-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-get-size2 --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, R, SugarActivity, Haskell, Ocaml, fonts, PHP, Python, C/C++, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! Looking forward to shipping some ruff updates.
Fixing the assignee.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-get-size2
Note that I will need to wait until rust-get-size-derive2, bug 2398141, is reviewed and approved before I can build this package. Otherwise, rust-get-size2+get-size-derive2-devel would fail to install.
FEDORA-2025-d8b35e47b6 (rust-get-size2-0.7.0-2.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-d8b35e47b6
FEDORA-2025-d8b35e47b6 (rust-get-size2-0.7.0-2.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.