Spec URL: https://download.copr.fedorainfracloud.org/results/asn/localkdc/fedora-43-x86_64/09632563-rust-zlink-core/rust-zlink-core.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/asn/localkdc/fedora-43-x86_64/09632563-rust-zlink-core/rust-zlink-core-0.1.1-1.fc43.src.rpm Description: The core crate of the zlink project. Fedora Account System Username: asn rust2rpm.toml: [features] hide = [ # Not packaged: rust-defmt "defmt", ]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9632622 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2400480-rust-zlink-core/fedora-rawhide-x86_64/09632622-rust-zlink-core/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Andreas Schneider from comment #0) > rust2rpm.toml: > > [features] > hide = [ > # Not packaged: rust-defmt > "defmt", > ] This was a good idea, but you still have installability problems: Problem: conflicting requests - nothing provides crate(zlink-core/defmt) = 0.1.1 needed by rust-zlink-core+embedded-devel-0.1.1-1.fc44.noarch from @commandline This is the kind of thing that the rust2rpm.toml(5) man page warns about: > NOTE: Care needs to be taken to only "hide" features / optional dependencies that are not > dependencies of other "non-hidden" features, otherwise the subpackages for the dependent > features will have unsatisfiable dependencies. All features that are marked as "hidden" > by this setting must be "unreachable" via feature dependencies from any feature > subpackages that are still present in the generated spec file. In some circumstances, > the only way to cleanly handle removal of unused non-default features is to patch > Cargo.toml instead. In this case, looking at Cargo.toml.orig, you should be able to get away with hiding defmt if you also hide the embedded feature. [features] hide = [ # Not packaged: rust-defmt "defmt", # Requires the defmt feature "embedded", ]
Spec URL: https://download.copr.fedorainfracloud.org/results/asn/localkdc/fedora-43-x86_64/09647448-rust-zlink-core/rust-zlink-core.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/asn/localkdc/fedora-43-x86_64/09647448-rust-zlink-core/rust-zlink-core-0.1.1-2.fc43.src.rpm
Created attachment 2108752 [details] The .spec file difference from Copr build 9632622 to 9647476
Copr build: https://copr.fedorainfracloud.org/coprs/build/9647476 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2400480-rust-zlink-core/fedora-rawhide-x86_64/09647476-rust-zlink-core/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
No issues found; the package is APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is exactly as generated by rust2rpm, except that rpmautospec macros are expanded; this greatly simplifies the review. The defmt and embedded features were hidden using rust2rpm.toml to avoid having to submit a rust-defmt package. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/zlink- core-0.1.1/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Not a serious problem; due to reasonable design decisions in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 62 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2400480-rust-zlink- core/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- zlink-core-devel , rust-zlink-core+default-devel , rust-zlink- core+bytes-devel , rust-zlink-core+chrono-devel , rust-zlink-core+idl- devel , rust-zlink-core+idl-parse-devel , rust-zlink-core+indexmap- devel , rust-zlink-core+introspection-devel , rust-zlink-core+io- buffer-16kb-devel , rust-zlink-core+io-buffer-1mb-devel , rust-zlink- core+io-buffer-2kb-devel , rust-zlink-core+io-buffer-4kb-devel , rust- zlink-core+proxy-devel , rust-zlink-core+std-devel , rust-zlink- core+time-devel , rust-zlink-core+tracing-devel , rust-zlink-core+url- devel , rust-zlink-core+uuid-devel [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=137839593 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: OK: this is an rpmautospec macro expansion, and this advice is dubious anyway, https://pagure.io/packaging-committee/issue/1449. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-zlink-core-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+default-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+bytes-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+chrono-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+idl-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+idl-parse-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+indexmap-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+introspection-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+io-buffer-16kb-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+io-buffer-1mb-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+io-buffer-2kb-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+io-buffer-4kb-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+proxy-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+std-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+time-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+tracing-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+url-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core+uuid-devel-0.1.1-2.fc44.noarch.rpm rust-zlink-core-0.1.1-2.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcn4bau2s')] checks: 32, packages: 19 19 packages and 0 specfiles checked; 0 errors, 0 warnings, 109 filtered, 0 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 18 18 packages and 0 specfiles checked; 0 errors, 0 warnings, 105 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/zlink-core/0.1.1/download#/zlink-core-0.1.1.crate : CHECKSUM(SHA256) this package : 51e1361a1fe6c1b7ce248a238a741c4859ccb2e0e2c7ad1376eff90a0ccf522e CHECKSUM(SHA256) upstream package : 51e1361a1fe6c1b7ce248a238a741c4859ccb2e0e2c7ad1376eff90a0ccf522e Requires -------- rust-zlink-core-devel (rpmlib, GLIBC filtered): (crate(futures-util) >= 0.3.31 with crate(futures-util) < 0.4.0~) (crate(futures-util/async-await) >= 0.3.31 with crate(futures-util/async-await) < 0.4.0~) (crate(futures-util/async-await-macro) >= 0.3.31 with crate(futures-util/async-await-macro) < 0.4.0~) (crate(mayheap) >= 0.2.0 with crate(mayheap) < 0.3.0~) (crate(mayheap/serde) >= 0.2.0 with crate(mayheap/serde) < 0.3.0~) (crate(memchr) >= 2.7.4 with crate(memchr) < 3.0.0~) (crate(pin-project-lite/default) >= 0.2.16 with crate(pin-project-lite/default) < 0.3.0~) (crate(serde) >= 1.0.218 with crate(serde) < 2.0.0~) (crate(serde/derive) >= 1.0.218 with crate(serde/derive) < 2.0.0~) (crate(zlink-macros/default) >= 0.1.0 with crate(zlink-macros/default) < 0.2.0~) cargo rust rust-zlink-core+default-devel (rpmlib, GLIBC filtered): cargo crate(zlink-core) crate(zlink-core/io-buffer-2kb) crate(zlink-core/proxy) crate(zlink-core/std) rust-zlink-core+bytes-devel (rpmlib, GLIBC filtered): (crate(bytes) >= 1.5.0 with crate(bytes) < 2.0.0~) cargo crate(zlink-core) rust-zlink-core+chrono-devel (rpmlib, GLIBC filtered): (crate(chrono) >= 0.4.0 with crate(chrono) < 0.5.0~) cargo crate(zlink-core) rust-zlink-core+idl-devel (rpmlib, GLIBC filtered): cargo crate(zlink-core) rust-zlink-core+idl-parse-devel (rpmlib, GLIBC filtered): (crate(winnow) >= 0.7.0 with crate(winnow) < 0.8.0~) (crate(winnow/alloc) >= 0.7.0 with crate(winnow/alloc) < 0.8.0~) (crate(zlink-macros/idl-parse) >= 0.1.0 with crate(zlink-macros/idl-parse) < 0.2.0~) cargo crate(zlink-core) crate(zlink-core/idl) crate(zlink-core/std) rust-zlink-core+indexmap-devel (rpmlib, GLIBC filtered): (crate(indexmap/default) >= 2.2.0 with crate(indexmap/default) < 3.0.0~) cargo crate(zlink-core) rust-zlink-core+introspection-devel (rpmlib, GLIBC filtered): (crate(zlink-macros/introspection) >= 0.1.0 with crate(zlink-macros/introspection) < 0.2.0~) cargo crate(zlink-core) crate(zlink-core/idl) rust-zlink-core+io-buffer-16kb-devel (rpmlib, GLIBC filtered): cargo crate(zlink-core) rust-zlink-core+io-buffer-1mb-devel (rpmlib, GLIBC filtered): cargo crate(zlink-core) rust-zlink-core+io-buffer-2kb-devel (rpmlib, GLIBC filtered): cargo crate(zlink-core) rust-zlink-core+io-buffer-4kb-devel (rpmlib, GLIBC filtered): cargo crate(zlink-core) rust-zlink-core+proxy-devel (rpmlib, GLIBC filtered): (crate(zlink-macros/proxy) >= 0.1.0 with crate(zlink-macros/proxy) < 0.2.0~) cargo crate(zlink-core) rust-zlink-core+std-devel (rpmlib, GLIBC filtered): (crate(mayheap/alloc) >= 0.2.0 with crate(mayheap/alloc) < 0.3.0~) (crate(memchr/std) >= 2.7.4 with crate(memchr/std) < 3.0.0~) (crate(serde/std) >= 1.0.218 with crate(serde/std) < 2.0.0~) (crate(serde_json/default) >= 1.0.139 with crate(serde_json/default) < 2.0.0~) (crate(zlink-macros/std) >= 0.1.0 with crate(zlink-macros/std) < 0.2.0~) cargo crate(zlink-core) crate(zlink-core/tracing) rust-zlink-core+time-devel (rpmlib, GLIBC filtered): (crate(time) >= 0.3.0 with crate(time) < 0.4.0~) cargo crate(zlink-core) rust-zlink-core+tracing-devel (rpmlib, GLIBC filtered): (crate(tracing) >= 0.1.41 with crate(tracing) < 0.2.0~) cargo crate(zlink-core) rust-zlink-core+url-devel (rpmlib, GLIBC filtered): (crate(url) >= 2.5.0 with crate(url) < 3.0.0~) cargo crate(zlink-core) rust-zlink-core+uuid-devel (rpmlib, GLIBC filtered): (crate(uuid) >= 1.0.0 with crate(uuid) < 2.0.0~) cargo crate(zlink-core) Provides -------- rust-zlink-core-devel: crate(zlink-core) rust-zlink-core-devel rust-zlink-core+default-devel: crate(zlink-core/default) rust-zlink-core+default-devel rust-zlink-core+bytes-devel: crate(zlink-core/bytes) rust-zlink-core+bytes-devel rust-zlink-core+chrono-devel: crate(zlink-core/chrono) rust-zlink-core+chrono-devel rust-zlink-core+idl-devel: crate(zlink-core/idl) rust-zlink-core+idl-devel rust-zlink-core+idl-parse-devel: crate(zlink-core/idl-parse) rust-zlink-core+idl-parse-devel rust-zlink-core+indexmap-devel: crate(zlink-core/indexmap) rust-zlink-core+indexmap-devel rust-zlink-core+introspection-devel: crate(zlink-core/introspection) rust-zlink-core+introspection-devel rust-zlink-core+io-buffer-16kb-devel: crate(zlink-core/io-buffer-16kb) rust-zlink-core+io-buffer-16kb-devel rust-zlink-core+io-buffer-1mb-devel: crate(zlink-core/io-buffer-1mb) rust-zlink-core+io-buffer-1mb-devel rust-zlink-core+io-buffer-2kb-devel: crate(zlink-core/io-buffer-2kb) rust-zlink-core+io-buffer-2kb-devel rust-zlink-core+io-buffer-4kb-devel: crate(zlink-core/io-buffer-4kb) rust-zlink-core+io-buffer-4kb-devel rust-zlink-core+proxy-devel: crate(zlink-core/proxy) rust-zlink-core+proxy-devel rust-zlink-core+std-devel: crate(zlink-core/std) rust-zlink-core+std-devel rust-zlink-core+time-devel: crate(zlink-core/time) rust-zlink-core+time-devel rust-zlink-core+tracing-devel: crate(zlink-core/tracing) rust-zlink-core+tracing-devel rust-zlink-core+url-devel: crate(zlink-core/url) rust-zlink-core+url-devel rust-zlink-core+uuid-devel: crate(zlink-core/uuid) rust-zlink-core+uuid-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2400480 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: Python, Java, PHP, Ocaml, fonts, Perl, SugarActivity, Haskell, C/C++, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zlink-core
FEDORA-2025-684775f2a8 (rust-zlink-0.1.1-1.fc44, rust-zlink-core-0.1.1-1.fc44, and 1 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-684775f2a8
FEDORA-2025-684775f2a8 (rust-zlink-0.1.1-1.fc44, rust-zlink-core-0.1.1-1.fc44, and 1 more) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.