Bug 2401792 - Review Request: rust-zlink-tokio - Zlink library for the Tokio runtime
Summary: Review Request: rust-zlink-tokio - Zlink library for the Tokio runtime
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/zlink-tokio
Whiteboard:
Depends On: 2400480
Blocks: 2401794
TreeView+ depends on / blocked
 
Reported: 2025-10-06 08:36 UTC by Andreas Schneider
Modified: 2025-10-09 08:33 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-10-09 08:33:40 UTC
Type: ---
Embargoed:
code: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2025-10-06 08:38:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9647501
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2401792-rust-zlink-tokio/fedora-rawhide-x86_64/09647501-rust-zlink-tokio/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2025-10-06 12:58:23 UTC
Package APPROVED, but please add an explanatory comment for zlink-tokio-fix-metadata.diff linking https://github.com/zeenix/zlink/issues/137 when you import the package. You can use package.cargo-toml-patch-comments in rust2rpm.toml to preserve the comment when re-generating the spec file; see the rust2rpm.toml(5) man page for details.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/cargo/registry/zlink-
  tokio-0.1.1/LICENSE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

- The Cargo.toml patch SHOULD have an explanatory comment,

  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment

  Please link the discussion in https://github.com/zeenix/zlink/issues/137. 

  If it took that much discussion to understand what should be done, imagine
  the plight of the packager who comes along and tries to understand it without
  context a year from now!

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 9 files have unknown license. Detailed output of
     licensecheck in /home/ben/fedora/review/2401792-rust-zlink-
     tokio/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     zlink-tokio-devel , rust-zlink-tokio+default-devel , rust-zlink-
     tokio+idl-devel , rust-zlink-tokio+idl-parse-devel , rust-zlink-
     tokio+introspection-devel , rust-zlink-tokio+io-buffer-16kb-devel ,
     rust-zlink-tokio+io-buffer-1mb-devel , rust-zlink-tokio+io-buffer-2kb-
     devel , rust-zlink-tokio+io-buffer-4kb-devel , rust-zlink-tokio+proxy-
     devel
[x]: Package functions as described.

     (tests pass, although there are only two tests that can be run)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.

     Please at least link https://github.com/zeenix/zlink/issues/137 to explain
     the Cargo.toml patch.

[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[-]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:

     OK: this is an rpmautospec macro expansion, and this advice is dubious
     anyway, https://pagure.io/packaging-committee/issue/1449.

[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-zlink-tokio-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+default-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+idl-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+idl-parse-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+introspection-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+io-buffer-16kb-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+io-buffer-1mb-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+io-buffer-2kb-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+io-buffer-4kb-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio+proxy-devel-0.1.1-1.fc44.noarch.rpm
          rust-zlink-tokio-0.1.1-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpyv2jtxm5')]
checks: 32, packages: 11

 11 packages and 0 specfiles checked; 0 errors, 0 warnings, 61 filtered, 0 badness; has taken 0.4 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 10

 10 packages and 0 specfiles checked; 0 errors, 0 warnings, 57 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://crates.io/api/v1/crates/zlink-tokio/0.1.1/download#/zlink-tokio-0.1.1.crate :
  CHECKSUM(SHA256) this package     : 8b8fb85421076d375b3cb49c76b9c7de75264c0383f531e4a8ec4994b51c7808
  CHECKSUM(SHA256) upstream package : 8b8fb85421076d375b3cb49c76b9c7de75264c0383f531e4a8ec4994b51c7808


Requires
--------
rust-zlink-tokio-devel (rpmlib, GLIBC filtered):
    (crate(futures-util) >= 0.3.31 with crate(futures-util) < 0.4.0~)
    (crate(futures-util/alloc) >= 0.3.31 with crate(futures-util/alloc) < 0.4.0~)
    (crate(futures-util/async-await) >= 0.3.31 with crate(futures-util/async-await) < 0.4.0~)
    (crate(tokio-stream) >= 0.1.17 with crate(tokio-stream) < 0.2.0~)
    (crate(tokio-stream/sync) >= 0.1.17 with crate(tokio-stream/sync) < 0.2.0~)
    (crate(tokio/default) >= 1.44.0 with crate(tokio/default) < 2.0.0~)
    (crate(tokio/io-util) >= 1.44.0 with crate(tokio/io-util) < 2.0.0~)
    (crate(tokio/net) >= 1.44.0 with crate(tokio/net) < 2.0.0~)
    (crate(zlink-core/default) >= 0.1.0 with crate(zlink-core/default) < 0.2.0~)
    cargo
    rust

rust-zlink-tokio+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+idl-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/idl) >= 0.1.0 with crate(zlink-core/idl) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+idl-parse-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/idl-parse) >= 0.1.0 with crate(zlink-core/idl-parse) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+introspection-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/introspection) >= 0.1.0 with crate(zlink-core/introspection) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+io-buffer-16kb-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/io-buffer-16kb) >= 0.1.0 with crate(zlink-core/io-buffer-16kb) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+io-buffer-1mb-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/io-buffer-1mb) >= 0.1.0 with crate(zlink-core/io-buffer-1mb) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+io-buffer-2kb-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/io-buffer-2kb) >= 0.1.0 with crate(zlink-core/io-buffer-2kb) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+io-buffer-4kb-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/io-buffer-4kb) >= 0.1.0 with crate(zlink-core/io-buffer-4kb) < 0.2.0~)
    cargo
    crate(zlink-tokio)

rust-zlink-tokio+proxy-devel (rpmlib, GLIBC filtered):
    (crate(zlink-core/proxy) >= 0.1.0 with crate(zlink-core/proxy) < 0.2.0~)
    cargo
    crate(zlink-tokio)



Provides
--------
rust-zlink-tokio-devel:
    crate(zlink-tokio)
    rust-zlink-tokio-devel

rust-zlink-tokio+default-devel:
    crate(zlink-tokio/default)
    rust-zlink-tokio+default-devel

rust-zlink-tokio+idl-devel:
    crate(zlink-tokio/idl)
    rust-zlink-tokio+idl-devel

rust-zlink-tokio+idl-parse-devel:
    crate(zlink-tokio/idl-parse)
    rust-zlink-tokio+idl-parse-devel

rust-zlink-tokio+introspection-devel:
    crate(zlink-tokio/introspection)
    rust-zlink-tokio+introspection-devel

rust-zlink-tokio+io-buffer-16kb-devel:
    crate(zlink-tokio/io-buffer-16kb)
    rust-zlink-tokio+io-buffer-16kb-devel

rust-zlink-tokio+io-buffer-1mb-devel:
    crate(zlink-tokio/io-buffer-1mb)
    rust-zlink-tokio+io-buffer-1mb-devel

rust-zlink-tokio+io-buffer-2kb-devel:
    crate(zlink-tokio/io-buffer-2kb)
    rust-zlink-tokio+io-buffer-2kb-devel

rust-zlink-tokio+io-buffer-4kb-devel:
    crate(zlink-tokio/io-buffer-4kb)
    rust-zlink-tokio+io-buffer-4kb-devel

rust-zlink-tokio+proxy-devel:
    crate(zlink-tokio/proxy)
    rust-zlink-tokio+proxy-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -L zlink-tokio-deps -b 2401792
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, Shell-api
Disabled plugins: C/C++, Ocaml, Haskell, R, Python, fonts, Perl, PHP, Java, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Built with local dependencies:
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+bytes-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+chrono-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+default-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+idl-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+idl-parse-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+indexmap-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+introspection-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+io-buffer-16kb-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+io-buffer-1mb-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+io-buffer-2kb-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+io-buffer-4kb-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+proxy-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+std-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+time-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+tracing-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+url-devel-0.1.1-2.fc44.noarch.rpm
    /home/ben/fedora/review/zlink-tokio-deps/rust-zlink-core+uuid-devel-0.1.1-2.fc44.noarch.rpm

Comment 3 Ben Beasley 2025-10-06 13:27:58 UTC
Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2025-10-08 11:52:47 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zlink-tokio

Comment 5 Fedora Update System 2025-10-09 08:29:36 UTC
FEDORA-2025-684775f2a8 (rust-zlink-0.1.1-1.fc44, rust-zlink-core-0.1.1-1.fc44, and 1 more) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-684775f2a8

Comment 6 Fedora Update System 2025-10-09 08:33:40 UTC
FEDORA-2025-684775f2a8 (rust-zlink-0.1.1-1.fc44, rust-zlink-core-0.1.1-1.fc44, and 1 more) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.