Bug 2402008 - Review Request: python-pyjson5 - JSON5 serializer and parser for Python 3 written in Cython.
Summary: Review Request: python-pyjson5 - JSON5 serializer and parser for Python 3 wri...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/Kijewski/pyjson5
Whiteboard:
Depends On:
Blocks: 2279791
TreeView+ depends on / blocked
 
Reported: 2025-10-06 20:34 UTC by Gwyn Ciesla
Modified: 2026-02-08 01:11 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-02-08 01:11:28 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)
Modified spec file with docs (2.00 KB, text/plain)
2026-01-30 15:08 UTC, Benson Muite
no flags Details

Description Gwyn Ciesla 2025-10-06 20:34:33 UTC
SRPM:https://fedorapeople.org/~limb/review/python-pyjson5/python-pyjson5-2.0.0-1.fc44.src.rpm
SPEC:https://fedorapeople.org/~limb/review/python-pyjson5/python-pyjson5.spec

Description:
The serializer returns ASCII data that can safely be used in an HTML template. Apostrophes, ampersands, greater-than, and less-then signs are encoded as unicode escaped sequences.

Comment 1 Fedora Review Service 2025-10-06 20:35:02 UTC
There seems to be some problem with the following file.
SRPM URL: https://fedorapeople.org/~limb/review/python-pyjson5/python-pyjson5-2.0.0-1.fc44.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benson Muite 2025-10-06 21:34:55 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* MIT License", "*No copyright* Apache License and/or
     MIT License", "MIT License", "Boost Software License 1.0". 496 files
     have unknown license. Detailed output of licensecheck in
     /home/benson/Projects/fedora-packaging/reviews/python-
     pyjson5/2402008-python-pyjson5/licensecheck.txt
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.14,
     /usr/lib64/python3.14/site-packages
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-pyjson5-2.0.0-1.fc44.x86_64.rpm
          python-pyjson5-2.0.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpo2rwapwf')]
checks: 32, packages: 2

python-pyjson5.src: W: summary-ended-with-dot JSON5 serializer and parser for Python 3 written in Cython.
python3-pyjson5.x86_64: W: summary-ended-with-dot JSON5 serializer and parser for Python 3 written in Cython.
python-pyjson5.src: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized')
python-pyjson5.src: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized')
python-pyjson5.src: E: spelling-error ('unicode', '%description -l en_US unicode -> Unicode, uni code, uni-code')
python3-pyjson5.x86_64: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('unicode', '%description -l en_US unicode -> Unicode, uni code, uni-code')
python3-pyjson5.x86_64: W: no-documentation
python-pyjson5.src: E: description-line-too-long The serializer returns ASCII data that can safely be used in an HTML template. Apostrophes, ampersands, greater-than, and less-then signs are encoded as unicode escaped sequences.
python3-pyjson5.x86_64: E: description-line-too-long The serializer returns ASCII data that can safely be used in an HTML template. Apostrophes, ampersands, greater-than, and less-then signs are encoded as unicode escaped sequences.
 2 packages and 0 specfiles checked; 8 errors, 3 warnings, 7 filtered, 8 badness; has taken 0.7 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-pyjson5.x86_64: W: summary-ended-with-dot JSON5 serializer and parser for Python 3 written in Cython.
python3-pyjson5.x86_64: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('unicode', '%description -l en_US unicode -> Unicode, uni code, uni-code')
python3-pyjson5.x86_64: W: no-documentation
python3-pyjson5.x86_64: E: description-line-too-long The serializer returns ASCII data that can safely be used in an HTML template. Apostrophes, ampersands, greater-than, and less-then signs are encoded as unicode escaped sequences.
 1 packages and 0 specfiles checked; 4 errors, 2 warnings, 3 filtered, 4 badness; has taken 0.2 s 



Unversioned so-files
--------------------
python3-pyjson5: /usr/lib64/python3.14/site-packages/pyjson5/pyjson5.cpython-314-x86_64-linux-gnu.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pyjson5/pyjson5-2.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7ccc98586cf87dfeadfa76de8df4c9cb0c3d21d1b559e28812dd9633748d6e25
  CHECKSUM(SHA256) upstream package : 7ccc98586cf87dfeadfa76de8df4c9cb0c3d21d1b559e28812dd9633748d6e25


Requires
--------
python3-pyjson5 (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    python(abi)
    rtld(GNU_HASH)



Provides
--------
python3-pyjson5:
    python-pyjson5
    python3-pyjson5
    python3-pyjson5(x86-64)
    python3.14-pyjson5
    python3.14dist(pyjson5)
    python3dist(pyjson5)



Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora-packaging/reviews/python-pyjson5/2402008-python-pyjson5/srpm/python-pyjson5.spec	2025-10-07 00:00:00.067546889 +0300
+++ /home/fedora-packaging/reviews/python-pyjson5/2402008-python-pyjson5/srpm-unpacked/python-pyjson5.spec	2025-10-06 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.1)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 Name:           python-pyjson5
 Version:        2.0.0
@@ -49,3 +59,6 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Mon Oct 06 2025 John Doe <packager> - 2.0.0-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2402008
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Python, Generic
Disabled plugins: R, Haskell, SugarActivity, PHP, fonts, Java, Ocaml, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Consider building the documentation
b) One file is under Boost Software license:

Boost Software License 1.0
--------------------------
python-pyjson5-2.0.0-build/pyjson5-2.0.0/src/dragonbox.cc
Please add this to the list of license
c)  A header only library is bundled:
https://github.com/lemire/fast_double_parser/tree/0f1fe9902d25847c8348e2f93ddc9dbe5521eab6
Either package it or indicate it as being bundled
d) Can tests be run, see:
https://github.com/Kijewski/pyjson5/blob/main/.github/workflows/ci.yml#L49-L53

Comment 3 Gwyn Ciesla 2025-10-07 16:29:06 UTC
Updated, same URLs. I didn't build the docs because we don't ship the required sphinx plugin.

Comment 5 Terje Rosten 2025-12-05 10:51:10 UTC
[fedora-review-service-build]

Comment 6 Fedora Review Service 2025-12-05 10:53:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9874014
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2402008-python-pyjson5/fedora-rawhide-x86_64/09874014-python-pyjson5/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Benson Muite 2026-01-25 14:02:00 UTC
[fedora-review-service-build]

Comment 8 Fedora Review Service 2026-01-25 14:04:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10056065
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2402008-python-pyjson5/fedora-rawhide-x86_64/10056065-python-pyjson5/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Benson Muite 2026-01-25 16:11:52 UTC
a) Changing
PYTHONPATH="${PYTHONPATH}:%{buildroot}%{python3_sitearch}" ./scripts/run-tests.py
PYTHONPATH="${PYTHONPATH}:%{buildroot}%{python3_sitearch}" ./scripts/run-minefield-test.py
to
PYTHONPATH="${PYTHONPATH}:%{buildroot}%{python3_sitearch}" %python3 /scripts/run-tests.py
PYTHONPATH="${PYTHONPATH}:%{buildroot}%{python3_sitearch}" %python3 /scripts/run-minefield-test.py

enables the package to build
https://koji.fedoraproject.org/koji/taskinfo?taskID=141558538

b) Please also shorten description line.

Comment 10 Gwyn Ciesla 2026-01-26 20:01:34 UTC
Done, same URLs.

Comment 11 Benson Muite 2026-01-30 06:27:12 UTC
[fedora-review-service-build]

Comment 12 Benson Muite 2026-01-30 15:07:10 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "*No copyright* MIT License", "*No copyright* Apache License and/or
     MIT License", "MIT License", "Boost Software License 1.0". 496 files
     have unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/python-pyjson5/2402008-python-
     pyjson5/licensecheck.txt
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/python3.14/site-
     packages, /usr/lib64/python3.14
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-pyjson5-2.0.0-1.fc44.x86_64.rpm
          python-pyjson5-2.0.0-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp_90rchdq')]
checks: 32, packages: 2

python-pyjson5.src: W: summary-ended-with-dot JSON5 serializer and parser for Python 3 written in Cython.
python3-pyjson5.x86_64: W: summary-ended-with-dot JSON5 serializer and parser for Python 3 written in Cython.
python-pyjson5.src: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized')
python-pyjson5.src: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: W: no-documentation
 2 packages and 0 specfiles checked; 4 errors, 3 warnings, 8 filtered, 4 badness; has taken 0.8 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-pyjson5.x86_64: W: summary-ended-with-dot JSON5 serializer and parser for Python 3 written in Cython.
python3-pyjson5.x86_64: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized')
python3-pyjson5.x86_64: W: no-documentation
 1 packages and 0 specfiles checked; 2 errors, 2 warnings, 3 filtered, 2 badness; has taken 0.2 s 



Unversioned so-files
--------------------
python3-pyjson5: /usr/lib64/python3.14/site-packages/pyjson5/pyjson5.cpython-314-x86_64-linux-gnu.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pyjson5/pyjson5-2.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7ccc98586cf87dfeadfa76de8df4c9cb0c3d21d1b559e28812dd9633748d6e25
  CHECKSUM(SHA256) upstream package : 7ccc98586cf87dfeadfa76de8df4c9cb0c3d21d1b559e28812dd9633748d6e25


Requires
--------
python3-pyjson5 (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    python(abi)
    rtld(GNU_HASH)



Provides
--------
python3-pyjson5:
    python-pyjson5
    python3-pyjson5
    python3-pyjson5(x86-64)
    python3.14-pyjson5
    python3.14dist(pyjson5)
    python3dist(pyjson5)



Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora-packaging/reviews/python-pyjson5/2402008-python-pyjson5/srpm/python-pyjson5.spec	2026-01-30 09:30:09.748691835 +0300
+++ /home/fedora-packaging/reviews/python-pyjson5/2402008-python-pyjson5/srpm-unpacked/python-pyjson5.spec	2026-01-26 03:00:00.000000000 +0300
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.3)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 Name:           python-pyjson5
 Version:        2.0.0
@@ -50,3 +60,6 @@
 
 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Mon Jan 26 2026 John Doe <packager> - 2.0.0-1
+- Uncommitted changes
+## END: Generated by rpmautospec


Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2402008
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic, C/C++
Disabled plugins: SugarActivity, Haskell, R, fonts, Java, PHP, Perl, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=141683856
b) Please remove the full stop at the end of the summary
c) Approved - fix (b) before import.
d) The documentation can be built, but not required see:
https://koji.fedoraproject.org/koji/taskinfo?taskID=141689491
will attach example spec file
e) Review of:
https://bugzilla.redhat.com/show_bug.cgi?id=2432752
would be appreciated.

Comment 13 Benson Muite 2026-01-30 15:08:41 UTC
Created attachment 2127522 [details]
Modified spec file with docs

Comment 14 Gwyn Ciesla 2026-01-30 16:02:42 UTC
Thank you, will fix and take that review.

Comment 15 Fedora Admin user for bugzilla script actions 2026-01-30 16:13:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyjson5

Comment 16 Fedora Update System 2026-01-30 16:33:46 UTC
FEDORA-2026-2022d11f81 (python-pyjson5-2.0.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-2022d11f81

Comment 17 Fedora Review Service 2026-01-31 01:39:58 UTC
There seems to be some problem with the following file.
SRPM URL: https://fedorapeople.org/~limb/review/python-pyjson5/python-pyjson5-2.0.0-1.fc44.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 18 Fedora Update System 2026-01-31 16:55:31 UTC
FEDORA-2026-2022d11f81 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-2022d11f81 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-2022d11f81

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 19 Fedora Update System 2026-02-08 01:11:28 UTC
FEDORA-2026-2022d11f81 (python-pyjson5-2.0.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.