Created attachment 2111547 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-fixed_decimal.spec SRPM URL: https://music.fedorapeople.org/rust-fixed_decimal-0.7.1-1.fc42.src.rpm Description: An API for representing numbers in a human-readable form. Fedora Account System Username: music This is in the dependency tree for uutils 0.3.0. This is an ICU4X utility crate.
There seems to be some problem with the following file. SRPM URL: https://music.fedorapeople.org/rust-fixed_decimal-0.7.1-1.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9750616 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2408499-rust-fixed_decimal/fedora-rawhide-x86_64/09750616-rust-fixed_decimal/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Until https://bodhi.fedoraproject.org/updates/FEDORA-2025-34c0492cae reaches a compose, this needs to be reviewed with the "--mock_options=--enablerepo=local" option for fedora-review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/fixed_decimal-0.7.1/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files Harmless ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-fixed_decimal-devel-0.7.1-1.fc44.noarch.rpm rust-fixed_decimal+default-devel-0.7.1-1.fc44.noarch.rpm rust-fixed_decimal+experimental-devel-0.7.1-1.fc44.noarch.rpm rust-fixed_decimal+ryu-devel-0.7.1-1.fc44.noarch.rpm rust-fixed_decimal-0.7.1-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp964c8vi5')] checks: 32, packages: 5 5 packages and 0 specfiles checked; 0 errors, 0 warnings, 25 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 21 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/fixed_decimal/0.7.1/download#/fixed_decimal-0.7.1.crate : CHECKSUM(SHA256) this package : 35eabf480f94d69182677e37571d3be065822acfafd12f2f085db44fbbcc8e57 CHECKSUM(SHA256) upstream package : 35eabf480f94d69182677e37571d3be065822acfafd12f2f085db44fbbcc8e57 Requires -------- rust-fixed_decimal-devel (rpmlib, GLIBC filtered): (crate(displaydoc) >= 0.2.3 with crate(displaydoc) < 0.3.0~) (crate(smallvec) >= 1.10.0 with crate(smallvec) < 2.0.0~) (crate(writeable) >= 0.6.0 with crate(writeable) < 0.7.0~) (crate(writeable/alloc) >= 0.6.0 with crate(writeable/alloc) < 0.7.0~) cargo rust rust-fixed_decimal+default-devel (rpmlib, GLIBC filtered): cargo crate(fixed_decimal) rust-fixed_decimal+experimental-devel (rpmlib, GLIBC filtered): cargo crate(fixed_decimal) rust-fixed_decimal+ryu-devel (rpmlib, GLIBC filtered): (crate(ryu) >= 1.0.5 with crate(ryu) < 2.0.0~) (crate(ryu/small) >= 1.0.5 with crate(ryu/small) < 2.0.0~) cargo crate(fixed_decimal) Provides -------- rust-fixed_decimal-devel: crate(fixed_decimal) rust-fixed_decimal-devel rust-fixed_decimal+default-devel: crate(fixed_decimal/default) rust-fixed_decimal+default-devel rust-fixed_decimal+experimental-devel: crate(fixed_decimal/experimental) rust-fixed_decimal+experimental-devel rust-fixed_decimal+ryu-devel: crate(fixed_decimal/ryu) rust-fixed_decimal+ryu-devel Summary: -------- All good, just a minor comment: would it make sense to add rust2rpm.toml file with [package] cargo-toml-patch-comments = [ ... ] to track patch comments? This is not a blocker as such, package is APPROVED.
Thank you for the review! (In reply to Terje Rosten from comment #6) > All good, just a minor comment: would it make sense > to add rust2rpm.toml file with > > [package] > cargo-toml-patch-comments = [ ... ] > > to track patch comments? I agree! See the attachment to https://bugzilla.redhat.com/show_bug.cgi?id=2408499#c0. https://release-monitoring.org/project/386811/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fixed_decimal
FEDORA-2025-37718a1834 (rust-fixed_decimal-0.7.1-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2025-37718a1834
FEDORA-2025-37718a1834 (rust-fixed_decimal-0.7.1-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-34030bfae7 (rust-fixed_decimal-0.7.1-1.fc43 and rust-icu_decimal_data-2.1.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-34030bfae7
FEDORA-2025-1dee9d8d2d (rust-fixed_decimal-0.7.1-1.fc42 and rust-icu_decimal_data-2.1.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dee9d8d2d
FEDORA-EPEL-2025-3390ea67a7 (rust-fixed_decimal-0.7.1-1.el9 and rust-icu_decimal_data-2.1.1-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3390ea67a7
FEDORA-2025-34030bfae7 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-34030bfae7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-34030bfae7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-3390ea67a7 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3390ea67a7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-1dee9d8d2d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1dee9d8d2d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dee9d8d2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.