Bug 2408520 - Review Request: rust-icu_decimal - API for formatting basic decimal numbers in a locale-sensitive way
Summary: Review Request: rust-icu_decimal - API for formatting basic decimal numbers i...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Terje Rosten
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/icu_decimal
Whiteboard:
Depends On: 2408421 2408499
Blocks: 2326739
TreeView+ depends on / blocked
 
Reported: 2025-10-30 22:28 UTC by Ben Beasley
Modified: 2025-12-03 01:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-11-20 13:42:44 UTC
Type: Bug
Embargoed:
terjeros: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (510 bytes, text/plain)
2025-10-30 22:28 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2025-10-30 22:28:34 UTC
Created attachment 2111557 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-icu_decimal.spec
SRPM URL: https://music.fedorapeople.org/rust-icu_decimal-2.1.1-1.fc42.src.rpm
Description: API for formatting basic decimal numbers in a locale-sensitive way.
Fedora Account System Username: music

This is in the dependency tree for uutils 0.3.0.

Until https://bodhi.fedoraproject.org/updates/FEDORA-2025-34c0492cae appears in a Rawhide compose (ideally in a day or two), this will need to be reviewed by passing the "--mock-options=--enablerepo=local" option to fedora-review.

Comment 1 Fedora Review Service 2025-10-30 22:30:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9750747
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2408520-rust-icu_decimal/fedora-rawhide-x86_64/09750747-rust-icu_decimal/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2025-10-30 22:31:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9750748
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2408520-rust-icu_decimal/fedora-rawhide-x86_64/09750748-rust-icu_decimal/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Terje Rosten 2025-11-19 11:12:57 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/cargo/registry/icu_decimal-2.1.1/LICENSE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

 - Harmless
 
===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-icu_decimal-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal+default-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal+alloc-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal+compiled_data-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal+datagen-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal+ryu-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal+serde-devel-2.1.1-1.fc44.noarch.rpm
          rust-icu_decimal-2.1.1-1.fc44.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmphnlkj5lh')]
checks: 32, packages: 8

 8 packages and 0 specfiles checked; 0 errors, 0 warnings, 43 filtered, 0 badness; has taken 0.3 s 

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 7

 7 packages and 0 specfiles checked; 0 errors, 0 warnings, 39 filtered, 0 badness; has taken 0.0 s 

Source checksums
----------------
https://crates.io/api/v1/crates/icu_decimal/2.1.1/download#/icu_decimal-2.1.1.crate :
  CHECKSUM(SHA256) this package     : a38c52231bc348f9b982c1868a2af3195199623007ba2c7650f432038f5b3e8e
  CHECKSUM(SHA256) upstream package : a38c52231bc348f9b982c1868a2af3195199623007ba2c7650f432038f5b3e8e

Requires
--------
rust-icu_decimal-devel (rpmlib, GLIBC filtered):
    (crate(fixed_decimal) >= 0.7.0 with crate(fixed_decimal) < 0.8.0~)
    (crate(icu_locale_core) >= 2.1.1 with crate(icu_locale_core) < 3.0.0~)
    (crate(icu_provider) >= 2.1.1 with crate(icu_provider) < 3.0.0~)
    (crate(writeable) >= 0.6.0 with crate(writeable) < 0.7.0~)
    (crate(zerovec) >= 0.11.3 with crate(zerovec) < 0.12.0~)
    (crate(zerovec/alloc) >= 0.11.3 with crate(zerovec/alloc) < 0.12.0~)
    cargo
    rust

rust-icu_decimal+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(icu_decimal)
    crate(icu_decimal/compiled_data)

rust-icu_decimal+alloc-devel (rpmlib, GLIBC filtered):
    (crate(serde) >= 1.0.220 with crate(serde) < 2.0.0~)
    (crate(serde/alloc) >= 1.0.220 with crate(serde/alloc) < 2.0.0~)
    (crate(serde/derive) >= 1.0.220 with crate(serde/derive) < 2.0.0~)
    (crate(zerovec/alloc) >= 0.11.3 with crate(zerovec/alloc) < 0.12.0~)
    cargo
    crate(icu_decimal)

rust-icu_decimal+compiled_data-devel (rpmlib, GLIBC filtered):
    (crate(icu_decimal_data) >= 2.1.1 with crate(icu_decimal_data) < 2.2.0~)
    (crate(icu_locale) >= 2.1.1 with crate(icu_locale) < 2.2.0~)
    (crate(icu_locale/compiled_data) >= 2.1.1 with crate(icu_locale/compiled_data) < 2.2.0~)
    (crate(icu_provider/baked) >= 2.1.1 with crate(icu_provider/baked) < 3.0.0~)
    cargo
    crate(icu_decimal)

rust-icu_decimal+datagen-devel (rpmlib, GLIBC filtered):
    (crate(databake) >= 0.2.0 with crate(databake) < 0.3.0~)
    (crate(databake/derive) >= 0.2.0 with crate(databake/derive) < 0.3.0~)
    (crate(icu_provider/export) >= 2.1.1 with crate(icu_provider/export) < 3.0.0~)
    (crate(zerovec/databake) >= 0.11.3 with crate(zerovec/databake) < 0.12.0~)
    cargo
    crate(icu_decimal)
    crate(icu_decimal/alloc)
    crate(icu_decimal/serde)

rust-icu_decimal+ryu-devel (rpmlib, GLIBC filtered):
    (crate(fixed_decimal/ryu) >= 0.7.0 with crate(fixed_decimal/ryu) < 0.8.0~)
    cargo
    crate(icu_decimal)

rust-icu_decimal+serde-devel (rpmlib, GLIBC filtered):
    (crate(icu_provider/serde) >= 2.1.1 with crate(icu_provider/serde) < 3.0.0~)
    (crate(serde) >= 1.0.220 with crate(serde) < 2.0.0~)
    (crate(serde/derive) >= 1.0.220 with crate(serde/derive) < 2.0.0~)
    (crate(zerovec/serde) >= 0.11.3 with crate(zerovec/serde) < 0.12.0~)
    cargo
    crate(icu_decimal)



Provides
--------
rust-icu_decimal-devel:
    crate(icu_decimal)
    rust-icu_decimal-devel

rust-icu_decimal+default-devel:
    crate(icu_decimal/default)
    rust-icu_decimal+default-devel

rust-icu_decimal+alloc-devel:
    crate(icu_decimal/alloc)
    rust-icu_decimal+alloc-devel

rust-icu_decimal+compiled_data-devel:
    crate(icu_decimal/compiled_data)
    rust-icu_decimal+compiled_data-devel

rust-icu_decimal+datagen-devel:
    crate(icu_decimal/datagen)
    rust-icu_decimal+datagen-devel

rust-icu_decimal+ryu-devel:
    crate(icu_decimal/ryu)
    rust-icu_decimal+ryu-devel

rust-icu_decimal+serde-devel:
    crate(icu_decimal/serde)
    rust-icu_decimal+serde-devel

All good,

 package is APPROVED.

Comment 4 Ben Beasley 2025-11-20 13:20:54 UTC
Thank you!

https://release-monitoring.org/project/386965/

Comment 5 Fedora Admin user for bugzilla script actions 2025-11-20 13:24:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_decimal

Comment 6 Fedora Update System 2025-11-20 13:39:21 UTC
FEDORA-2025-c3235c8abb (rust-icu_decimal-2.1.1-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c3235c8abb

Comment 7 Fedora Update System 2025-11-20 13:42:44 UTC
FEDORA-2025-c3235c8abb (rust-icu_decimal-2.1.1-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-11-20 21:46:35 UTC
FEDORA-2025-34030bfae7 (rust-fixed_decimal-0.7.1-1.fc43, rust-icu_collator_data-2.1.1-1.fc43, and 2 more) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-34030bfae7

Comment 9 Fedora Update System 2025-11-20 22:06:00 UTC
FEDORA-2025-1dee9d8d2d (rust-fixed_decimal-0.7.1-1.fc42, rust-icu_collator_data-2.1.1-1.fc42, and 2 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dee9d8d2d

Comment 10 Fedora Update System 2025-11-21 13:51:07 UTC
FEDORA-EPEL-2025-3390ea67a7 (rust-fixed_decimal-0.7.1-1.el9, rust-icu_collator_data-2.1.1-1.el9, and 4 more) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3390ea67a7

Comment 11 Fedora Update System 2025-11-22 01:48:41 UTC
FEDORA-EPEL-2025-3390ea67a7 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3390ea67a7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-11-22 01:58:50 UTC
FEDORA-2025-1dee9d8d2d has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1dee9d8d2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dee9d8d2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-11-22 02:22:45 UTC
FEDORA-2025-34030bfae7 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-34030bfae7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-34030bfae7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-11-25 01:48:45 UTC
FEDORA-EPEL-2025-3390ea67a7 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3390ea67a7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-11-25 01:58:45 UTC
FEDORA-2025-34030bfae7 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-34030bfae7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-34030bfae7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2025-11-25 02:21:10 UTC
FEDORA-2025-1dee9d8d2d has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-1dee9d8d2d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-1dee9d8d2d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2025-12-03 00:26:56 UTC
FEDORA-EPEL-2025-3390ea67a7 (rust-fixed_decimal-0.7.1-1.el9, rust-icu_collator-2.1.1-1.el9, and 5 more) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2025-12-03 00:52:15 UTC
FEDORA-2025-34030bfae7 (rust-fixed_decimal-0.7.1-1.fc43, rust-icu_collator-2.1.1-1.fc43, and 3 more) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2025-12-03 01:05:38 UTC
FEDORA-2025-1dee9d8d2d (rust-fixed_decimal-0.7.1-1.fc42, rust-icu_collator-2.1.1-1.fc42, and 3 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.