Created attachment 2120523 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-av-scenechange.spec SRPM URL: https://music.fedorapeople.org/rust-av-scenechange-0.14.1-1.fc43.src.rpm Description: Estimates frames in a video where a scenecut would be ideal. Fedora Account System Username: music This is required for updating rust-rav1e, which is required for updating rust-ravif, which is required for updating rust-image. This built in COPR, https://copr.fedorainfracloud.org/coprs/music/rust-image/build/9961087/, although the fedora-review support in COPR no longer appears to provide very useful output.
Note that this is *not* the latest upstream release, which would be 0.20.0, but it *is* the version required for the latest rav1e, and it’s not the kind of dependency I would want to try to update ahead of upstream.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9961736 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426260-rust-av-scenechange/fedora-rawhide-x86_64/09961736-rust-av-scenechange/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/9961737 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2426260-rust-av-scenechange/fedora-rawhide-x86_64/09961737-rust-av-scenechange/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This requires nasm-rs ^0.3.0 to build. How would you like to handle this? I can try to do a local test build for the review with the nasm-rs 0.3.1 PR as a pre-dep?
(In reply to Fabio Valentini from comment #4) > This requires nasm-rs ^0.3.0 to build. How would you like to handle this? 1. Only rust-rav1e currently requires nasm-rs. 2. I’m packaging rust-av-scenechange as a dependency for an updated rust-rav1e. 3. The updated rust-rav1e also requires nasm-rs ^0.3.0. So when it comes to actually building things, it will be straightforward: rust-nasm-rs-0.3.0, this package, and the updated rust-rav1e can all be built together in the same side tags. > I can try to do a local test build for the review with the nasm-rs 0.3.1 PR > as a pre-dep? That sounds like a good way to review this.
Package was generated with rust2rpm, simplifying the review. The local test build for the review was done on top of the Fedora CI scratch build results for the rust-nasm-rs v0.3 update ("fedora-review -L rpms/ -b 2426260", with the RPM packages in the rpms/ directory). === It appears that most of this project used to be part of rav1e and was just split off into a separate crate (plus command-line utility that wasn't present before). Patches are well-documented and justified (either for being downstream-only, or having already been submitted to upstream). ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide (tested with nasm-rs v0.3.1 available) ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review! I will request the repository for now, and finish importing the package once everything else is lined up for the rust-image update.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-av-scenechange