Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/fedora-42-x86_64/10203696-OpenVSP/OpenVSP.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm-builds/10203696/OpenVSP-3.47.0-1.src.rpm Description: OpenVSP is a parametric aircraft geometry tool. OpenVSP allows the user to create a 3D model of an aircraft defined by common engineering parameters. This model can be processed into formats suitable for engineering analysis. Fedora Account System Username: Mumble07 This will be my first submission, and I will require sponsorship. Assistance would also be appreciated. I am in contact with Rob McDonald, the developer of OpenVSP.
The following built-in dependencies were not packaged into the RPM: * libcartesian.so * libcfd_mesh.so * libgeom_api.so * libgeom_api_g.so * libgeom_core.so * libglfont2.so * libgui_and_draw.so * librobust.so * libsixseries.so * libstb_image.so * libtritri.so * libutil.so * libutil_api.so * libviewerscreens.so * libvsp_graphic.so * libvspaero_lib.so * libwavedragEL.so * libxmlvsp.so The bundled CMake RPM packager correctly included them. Is there a way to fix this in the .spec file?
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to marc from comment #1) > The following built-in dependencies were not packaged into the RPM: > * libcartesian.so > * libcfd_mesh.so > * libgeom_api.so > * libgeom_api_g.so > * libgeom_core.so > * libglfont2.so > * libgui_and_draw.so > * librobust.so > * libsixseries.so > * libstb_image.so > * libtritri.so > * libutil.so > * libutil_api.so > * libviewerscreens.so > * libvsp_graphic.so > * libvspaero_lib.so > * libwavedragEL.so > * libxmlvsp.so > > The bundled CMake RPM packager correctly included them. Is there a way to > fix this in the .spec file? Fixed, will upload a new .srpm/.spec
(In reply to Fedora Review Service from comment #2) > Cannot find any valid SRPM URL for this ticket. Common causes are: > > - You didn't specify `SRPM URL: ...` in the ticket description > or any of your comments > - The URL schema isn't HTTP or HTTPS > - The SRPM package linked in your URL doesn't match the package name > specified > in the ticket summary > > > --- > This comment was created by the fedora-review-service > https://github.com/FrostyX/fedora-review-service > > If you want to trigger a new Copr build, add a comment containing new > Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/fedora-42-x86_64/10203696-OpenVSP/OpenVSP.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm-builds/10203696/OpenVSP-3.47.0-1.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10203941 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10203941-OpenVSP/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fedora Review Service from comment #5) > Copr build: > https://copr.fedorainfracloud.org/coprs/build/10203941 > (failed) > > Build log: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > review-2445636-openvsp/fedora-rawhide-x86_64/10203941-OpenVSP/builder-live. > log.gz > > Please make sure the package builds successfully at least for Fedora Rawhide. > > - If the build failed for unrelated reasons (e.g. temporary network > unavailability), please ignore it. > - If the build failed because of missing BuildRequires, please make sure they > are listed in the "Depends On" field > > > --- > This comment was created by the fedora-review-service > https://github.com/FrostyX/fedora-review-service > > If you want to trigger a new Copr build, add a comment containing new > Spec and SRPM URLs or [fedora-review-service-build] string. Rawhide does not appear to have gcc-14. The version of STEPCode in OpenVSP does not compile with gcc-15, and is unlikely to compile with gcc-16 (though I haven't checked). Rawhide compatibility is a bigger ask than f42 and f43 for the moment. Is that workable for now?
Copr build: https://copr.fedorainfracloud.org/coprs/build/10203972 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10203972-OpenVSP/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Is it possible to start by packaging one of the dependencies: clipper2 delabella exprparse libIGES OpenABF pinocchio STEPcode triangle
Sure, but not all of them. Some are quite a pain to compile, and/or have documented issues when using them as shared libraries.
(In reply to Benson Muite from comment #8) > Is it possible to start by packaging one of the dependencies: > clipper2 > delabella > exprparse > libIGES > OpenABF > pinocchio > STEPcode > triangle Would you like these in a separate bug report, or appended to this one?
SPEC : https://github.com/Mumbri-systems/OpenVSP/blob/fedora-3.47.0/pkg/rpm/OpenVSP.spec SRPM : https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm-builds/10209437
(In reply to marc from comment #11) > SPEC : > https://github.com/Mumbri-systems/OpenVSP/blob/fedora-3.47.0/pkg/rpm/OpenVSP. > spec > SRPM : > https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm- > builds/10209437 Wrong link https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm-builds/10209437/OpenVSP-3.47.0-1.src.rpm
Created attachment 2133111 [details] The .spec file difference from Copr build 10203972 to 10218154
Copr build: https://copr.fedorainfracloud.org/coprs/build/10218154 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10218154-OpenVSP/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'NASA-1.3'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
New build incorporating the latest version of STEPCode, and passing internal self tests: SRPM: https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm-builds/10282799/OpenVSP-3.47.0-1.src.rpm SPEC: https://download.copr.fedorainfracloud.org/results/mumble07/OpenVSP/srpm-builds/10282799/OpenVSP.spec When STEPCode is included in repos, I will switch to using system STEPCode (along with other dependencies).
Copr build: https://copr.fedorainfracloud.org/coprs/build/10284293 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10284293-OpenVSP/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'NASA-1.3'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Permanent links: SPEC: https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/pkg/rpm/OpenVSP.spec SRPM: https://github.com/Mumbri-systems/OpenVSP/releases/download/openvsp_3.49.0-fedora/OpenVSP-3.49.0.20260422git6637418-1.src.rpm Some outstanding issues remain; Eigen is still using version 3. I also noticed Angelscript is available in the repo, but using the system package breaks the build due to addons not being found. I'll look into it.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10356169 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10356169-OpenVSP/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'NASA-1.3'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
New build with system stepcode. The source repo has been shifted to upstream, and all changes are now patches. SRPM: https://mumble07.fedorapeople.org/SRPMS/OpenVSP-3.50.3-1.src.rpm SPEC: https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/pkg/rpm/OpenVSP.spec Known outstanding issues: CPPTest is out of date in fedora repos, and is unusable Bundled libraries have not been removed from the source as per https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Angelscript requires addons, which are not available in the fedora repos. Guidance would be appreciated.
New build with system clipper2 (in repos as polyclipping2). Also started removing bundled libs as per packaging guidelines: SRPM: https://mumble07.fedorapeople.org/SRPMS/OpenVSP-3.50.3-1.fc45.src.rpm SPEC: https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/pkg/rpm/OpenVSP.spec
Copr build: https://copr.fedorainfracloud.org/coprs/build/10551679 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10551679-OpenVSP/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'NASA-1.3'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Made the following changes: * Added bundled libs as Provides: * Fixed unowned directory for icons/hicolor/scalable/apps * Used desktop-file-install * moved /usr/share files into -data subpackage * enabled %ctest, disabled python tests because I can't see an easy way to enable venv within the build process SRPM: https://mumble07.fedorapeople.org/SRPMS/OpenVSP-3.50.3-1.fc45.src.rpm SPEC: https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/pkg/rpm/OpenVSP.spec rmplint finds the following errors: Rpmlint ------- Checking: OpenVSP-3.50.3-1.fc45.x86_64.rpm OpenVSP-data-3.50.3-1.fc45.noarch.rpm OpenVSP-3.50.3-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpni0vys1e')] checks: 32, packages: 3 OpenVSP.spec:59: W: unversioned-explicit-provides angelscript OpenVSP.spec:60: W: unversioned-explicit-provides fltk OpenVSP.spec:61: W: unversioned-explicit-provides cpptest OpenVSP.spec:62: W: unversioned-explicit-provides Code-Eli OpenVSP.spec:63: W: unversioned-explicit-provides delabella OpenVSP.spec:64: W: unversioned-explicit-provides exprparse OpenVSP.spec:65: W: unversioned-explicit-provides libiges OpenVSP.spec:66: W: unversioned-explicit-provides openabf OpenVSP.spec:67: W: unversioned-explicit-provides Pinocchio OpenVSP.spec:68: W: unversioned-explicit-provides Triangle OpenVSP.x86_64: W: no-manual-page-for-binary vsp OpenVSP.x86_64: W: no-manual-page-for-binary vspaero OpenVSP.x86_64: W: no-manual-page-for-binary vspaero_opt OpenVSP.x86_64: W: no-manual-page-for-binary vsploads OpenVSP.x86_64: W: no-manual-page-for-binary vspscript OpenVSP.x86_64: W: no-manual-page-for-binary vspviewer OpenVSP-data.noarch: W: no-documentation OpenVSP.src: W: invalid-license NASA-1.3 OpenVSP.x86_64: W: invalid-license NASA-1.3 OpenVSP-data.noarch: W: invalid-license NASA-1.3 OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/AdvLink.html /usr/help/AdvLink.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/AttributeExplorer.html /usr/help/AttributeExplorer.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/GeometryAnalysis.html /usr/help/GeometryAnalysis.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/SetEdit.html /usr/help/SetEdit.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/StackPresets.html /usr/help/StackPresets.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/github-pandoc.css /usr/help/github-pandoc.css OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/AdvLink_example.png /usr/help/images/AdvLink_example.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineDefinition.png /usr/help/images/EngineDefinition.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineNacelleOnly.png /usr/help/images/EngineNacelleOnly.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineNacelleWithNegativeFlowpath.png /usr/help/images/EngineNacelleWithNegativeFlowpath.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineNegativeFlowpathOnly.png /usr/help/images/EngineNegativeFlowpathOnly.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineRepresentation.png /usr/help/images/EngineRepresentation.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/EngineStations.png /usr/help/images/EngineStations.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowpathInlet.png /usr/help/images/NacelleFlowpathInlet.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowpathInletOutlet.png /usr/help/images/NacelleFlowpathInletOutlet.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowpathOutlet.png /usr/help/images/NacelleFlowpathOutlet.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowthruInletOrigin.png /usr/help/images/NacelleFlowthruInletOrigin.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowthruMidOrigin.png /usr/help/images/NacelleFlowthruMidOrigin.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleFlowthruOutletOrigin.png /usr/help/images/NacelleFlowthruOutletOrigin.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletFaceOutletLip.png /usr/help/images/NacelleInletFaceOutletLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletLipOutletFace.png /usr/help/images/NacelleInletLipOutletFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletOutletFace.png /usr/help/images/NacelleInletOutletFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletOutletToLip.png /usr/help/images/NacelleInletOutletToLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletToFace.png /usr/help/images/NacelleInletToFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleInletToLip.png /usr/help/images/NacelleInletToLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleOutletToFace.png /usr/help/images/NacelleOutletToFace.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/NacelleOutletToLip.png /usr/help/images/NacelleOutletToLip.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_body.png /usr/help/images/SetEditor_body.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_footer.png /usr/help/images/SetEditor_footer.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_header.png /usr/help/images/SetEditor_header.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/images/SetEditor_window.png /usr/help/images/SetEditor_window.png OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/index.html /usr/help/index.html OpenVSP.x86_64: E: hardlink-across-partition /usr/python/openvsp/openvsp/help_vsp/vsp_help /usr/help/vsp_help OpenVSP.x86_64: W: files-duplicate /usr/share/doc/VSP/README.md /usr/share/doc/OpenVSP/README.md OpenVSP.x86_64: W: files-duplicate /usr/share/licenses/OpenVSP/LICENSE /usr/share/doc/VSP/LICENSE OpenVSP-data.noarch: W: desktopfile-without-binary /usr/share/applications/openvsp.desktop /usr/bin/vsp 3 packages and 0 specfiles checked; 33 errors, 23 warnings, 46 filtered, 33 badness; has taken 8.2 s I think I found the offending file in https://github.com/Mumbri-systems/OpenVSP/raw/openvsp-fedora/src/help/CMakeLists.txt I don't understand how copying is leading to bad hardlinks, or how to fix it. The only reference I can find is this: https://docs.fedoraproject.org/en-US/fedora/latest/release-notes/developers/#_hardlink_identical_files_in_packages_by_default Guidance would be appreciated.
Created attachment 2144292 [details] The .spec file difference from Copr build 10551679 to 10569912
Copr build: https://copr.fedorainfracloud.org/coprs/build/10569912 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445636-openvsp/fedora-rawhide-x86_64/10569912-OpenVSP/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'NASA-1.3'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The copr build confirms that the hardlink issue only shows up starting from f44.