Spec URL: https://github.com/Mumbri-systems/delabella/raw/master/pkg/rpm/delabella.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mumble07/delabella/srpm-builds/10208288/delabella-2.0-1.src.rpm Description: 2D Exact Delaunay triangulation Fedora Account System Username: Mumble07 I am not in contact with the maintainer of this software. This is packaged as a dependency for OpenVSP. I do not currently have a sponsor.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10249668 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2446445-delabella/fedora-rawhide-x86_64/10249668-delabella/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
spec: https://github.com/Mumbri-systems/delabella/raw/master/pkg/rpm/delabella.spec srpm: https://packages.redhat.com/api/pulp-content/public-copr/mumble07/delabella/fedora-rawhide-x86_64/Packages/d/delabella-2.0-1.fc45.src.rpm
Mostly seems ok. Can the URL be updated to: https://github.com/msokalski/delabella Can the source be updated to %{url}/archive/V%{version}/delabella-%{version}.tar.gz Please also change: %{_libdir}/libdelabella.so.%{version} %{_libdir}/libdelabella.so.%(echo %{version} | cut -d. -f1) to %{_libdir}/libdelabella.so.2{,.*} Soname changes should be tracked and changed manually so that changes can be announced to prevent other software from failing to work when there is an ABI change.
Done. I changed the source to the upstream repo and put the changes into patch files. I'll do a PR with the upstream repo once this package is accepted. SPEC: https://download.copr.fedorainfracloud.org/results/mumble07/delabella/srpm-builds/10275569/delabella.spec SRPM: https://download.copr.fedorainfracloud.org/results/mumble07/delabella/srpm-builds/10275569/delabella-2.0-1.src.rpm
Created attachment 2135519 [details] The .spec file difference from Copr build 10249668 to 10275650
Copr build: https://copr.fedorainfracloud.org/coprs/build/10275650 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2446445-delabella/fedora-rawhide-x86_64/10275650-delabella/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The patches were accepted as PRs so I got rid of them and now point to the latest commit. I don't know why the change to major version numbers wasn't done, I thought I had put that in. In any case, it's been applied now SRPM : https://packages.redhat.com/api/pulp-content/public-copr/mumble07/delabella/fedora-rawhide-x86_64/Packages/d/delabella-2.0%5E20260402git0b8d371-1.fc45.src.rpm SPEC : https://download.copr.fedorainfracloud.org/results/mumble07/delabella/fedora-rawhide-x86_64/10288338-delabella/delabella.spec
Created attachment 2135840 [details] The .spec file difference from Copr build 10275650 to 10288808
Copr build: https://copr.fedorainfracloud.org/coprs/build/10288808 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2446445-delabella/fedora-rawhide-x86_64/10288808-delabella/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.