Here _datadir seems to be used correctly.

Another remark:
This is pretty clumsy:

%prep
if [ ! -d %{name}-%{version} ]; then mkdir %{name}-%{version}; fi
%setup -q -n %{name}-%{version} -D -T -a 0

It can be written much shorter:
%prep
%setup -q -c -a 0

[rsp. .... -a 0 -a 1 ... -a N, for packages consisting of more tarballs.]

How about add another dict next time? So I think it is better to use the same
scheme as other dic spec files.

<In reply to comment #2)
> How about add another dict next time?
Add another -a <N>

> So I think it is better to use the same
> scheme as other dic spec files.
OK, more bluntly: Your construct is a broken hack.

If you prefer one line per packages, then at least do it the rpm way:
%setup -c -T -n %{name}-%{version}
%setup -q -n %{name}-%{version} -D -T -a 0
%setup -q -n %{name}-%{version} -D -T -a 1

Compare what happens using this construct:

+ rm -rf stardict-dic-ja-2.4.2
+ /bin/mkdir -p stardict-dic-ja-2.4.2
+ cd stardict-dic-ja-2.4.2
++ /usr/bin/id -u
+ '[' 1005 = 0 ']'
++ /usr/bin/id -u
+ '[' 1005 = 0 ']'
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ cd /home/user/src/rpms/BUILD
+ cd stardict-dic-ja-2.4.2
+ /usr/bin/bzip2 -dc /home/user/src/rpms/SOURCES/stardict-edict-2.4.2.tar.bz2

Against what happens with your contruct:
+ '[' '!' -d stardict-dic-ja-2.4.2 ']'
+ cd /home/user/src/rpms/BUILD
+ cd stardict-dic-ja-2.4.2
+ /usr/bin/bzip2 -dc /home/user/src/rpms/SOURCES/stardict-edict-2.4.2.tar.bz2
+ tar -xf -

=> MUSTFIX

Fixed as the same file :)
Thank you!

Note that convention is to increase the release and add a changelog for each
change (even during review). This allows reviewers to tell when an item was
fixed and to confirm that they have the latest version for review. 

OK, I will do this next time.

Can we approve them now? In fact, these packages come from a approved spec file
ago, so I think they can be stable now.

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
f164dcb24b1084e1cfa2b1cb63d590e6  stardict-dictd_www.dict.org_wn-2.4.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text is NOT included in package.
- no %doc files as I think dictd_www.dict.org_wn.ifo is not %doc
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains content.
+ no static libraries.
+ no .pc files are present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Requires: stardict >= 2.4.2

APPROVED.

Notice, because of bandwidth issue, I didn't upload the newest SRPM, you can
download the old srpm, replace the spec file with the newest one and rebuild to
get the newest srpm file.

New Package CVS Request
=======================
Package Name: stardict-dic-en
Short Description: English(en) dictionaries for StarDict
Owners: zhu
Branches: F-7
InitialCC: 

stardict-dic-en-2.4.2-3.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.